* [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
@ 2021-10-22 13:15 Peng Fan (OSS)
2021-11-20 12:04 ` Peng Fan
2021-11-20 20:18 ` Abel Vesa
0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2021-10-22 13:15 UTC (permalink / raw)
To: sboyd, mturquette, abel.vesa, s.hauer
Cc: kernel, festevam, linux-imx, linux-clk, linux-arm-kernel,
linux-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
The clock driver is registered as platform devices and
it is possible to reloading the driver at runtime.
But actually the clocks should never be removed to make system work,
attempting to bind again would result in a crash, because almost all
devices depends on clock to function well.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
Update commit log to explain more
drivers/clk/imx/clk-imx8ulp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
index 6699437e17b8..8eb1af2d6429 100644
--- a/drivers/clk/imx/clk-imx8ulp.c
+++ b/drivers/clk/imx/clk-imx8ulp.c
@@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
.probe = imx8ulp_clk_probe,
.driver = {
.name = KBUILD_MODNAME,
+ .suppress_bind_attrs = true,
.of_match_table = imx8ulp_clk_dt_ids,
},
};
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
2021-10-22 13:15 [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true Peng Fan (OSS)
@ 2021-11-20 12:04 ` Peng Fan
2021-11-22 13:13 ` Abel Vesa
2021-11-20 20:18 ` Abel Vesa
1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan @ 2021-11-20 12:04 UTC (permalink / raw)
To: Peng Fan (OSS), sboyd, mturquette, Abel Vesa, s.hauer
Cc: kernel, festevam, dl-linux-imx, linux-clk, linux-arm-kernel,
linux-kernel
> Subject: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
Ping..
Thanks,
Peng.
>
> From: Peng Fan <peng.fan@nxp.com>
>
> The clock driver is registered as platform devices and it is possible to reloading
> the driver at runtime.
>
> But actually the clocks should never be removed to make system work,
> attempting to bind again would result in a crash, because almost all devices
> depends on clock to function well.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V2:
> Update commit log to explain more
>
> drivers/clk/imx/clk-imx8ulp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> index 6699437e17b8..8eb1af2d6429 100644
> --- a/drivers/clk/imx/clk-imx8ulp.c
> +++ b/drivers/clk/imx/clk-imx8ulp.c
> @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
> .probe = imx8ulp_clk_probe,
> .driver = {
> .name = KBUILD_MODNAME,
> + .suppress_bind_attrs = true,
> .of_match_table = imx8ulp_clk_dt_ids,
> },
> };
> --
> 2.30.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
2021-10-22 13:15 [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true Peng Fan (OSS)
2021-11-20 12:04 ` Peng Fan
@ 2021-11-20 20:18 ` Abel Vesa
1 sibling, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2021-11-20 20:18 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: sboyd, mturquette, s.hauer, kernel, festevam, linux-imx,
linux-clk, linux-arm-kernel, linux-kernel, Peng Fan
On 21-10-22 21:15:13, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> The clock driver is registered as platform devices and
> it is possible to reloading the driver at runtime.
>
> But actually the clocks should never be removed to make system work,
> attempting to bind again would result in a crash, because almost all
> devices depends on clock to function well.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
I'll apply it to clk/imx on Monday.
> ---
>
> V2:
> Update commit log to explain more
>
> drivers/clk/imx/clk-imx8ulp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> index 6699437e17b8..8eb1af2d6429 100644
> --- a/drivers/clk/imx/clk-imx8ulp.c
> +++ b/drivers/clk/imx/clk-imx8ulp.c
> @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
> .probe = imx8ulp_clk_probe,
> .driver = {
> .name = KBUILD_MODNAME,
> + .suppress_bind_attrs = true,
> .of_match_table = imx8ulp_clk_dt_ids,
> },
> };
> --
> 2.30.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
2021-11-20 12:04 ` Peng Fan
@ 2021-11-22 13:13 ` Abel Vesa
0 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2021-11-22 13:13 UTC (permalink / raw)
To: Peng Fan
Cc: Peng Fan (OSS),
sboyd, mturquette, s.hauer, kernel, festevam, dl-linux-imx,
linux-clk, linux-arm-kernel, linux-kernel
On 21-11-20 14:04:30, Peng Fan wrote:
> > Subject: [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true
>
> Ping..
>
Applied, thanks.
> Thanks,
> Peng.
>
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The clock driver is registered as platform devices and it is possible to reloading
> > the driver at runtime.
> >
> > But actually the clocks should never be removed to make system work,
> > attempting to bind again would result in a crash, because almost all devices
> > depends on clock to function well.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V2:
> > Update commit log to explain more
> >
> > drivers/clk/imx/clk-imx8ulp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/imx/clk-imx8ulp.c b/drivers/clk/imx/clk-imx8ulp.c
> > index 6699437e17b8..8eb1af2d6429 100644
> > --- a/drivers/clk/imx/clk-imx8ulp.c
> > +++ b/drivers/clk/imx/clk-imx8ulp.c
> > @@ -559,6 +559,7 @@ static struct platform_driver imx8ulp_clk_driver = {
> > .probe = imx8ulp_clk_probe,
> > .driver = {
> > .name = KBUILD_MODNAME,
> > + .suppress_bind_attrs = true,
> > .of_match_table = imx8ulp_clk_dt_ids,
> > },
> > };
> > --
> > 2.30.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-22 13:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 13:15 [PATCH V2] clk: imx: imx8ulp: set suppress_bind_attrs to true Peng Fan (OSS)
2021-11-20 12:04 ` Peng Fan
2021-11-22 13:13 ` Abel Vesa
2021-11-20 20:18 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).