* [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-09 10:06 ` Ulf Hansson
2022-01-05 16:39 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset " Florian Fainelli
` (13 subsequent siblings)
14 siblings, 2 replies; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB SDHCI controller Device Tree binding to YAML.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/mmc/brcm,sdhci-brcmstb.txt | 53 ----------
.../bindings/mmc/brcm,sdhci-brcmstb.yaml | 100 ++++++++++++++++++
2 files changed, 100 insertions(+), 53 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
create mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
deleted file mode 100644
index ae2074184528..000000000000
--- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-* BROADCOM BRCMSTB/BMIPS SDHCI Controller
-
-This file documents differences between the core properties in mmc.txt
-and the properties used by the sdhci-brcmstb driver.
-
-NOTE: The driver disables all UHS speed modes by default and depends
-on Device Tree properties to enable them for SoC/Board combinations
-that support them.
-
-Required properties:
-- compatible: should be one of the following
- - "brcm,bcm7425-sdhci"
- - "brcm,bcm7445-sdhci"
- - "brcm,bcm7216-sdhci"
-
-Refer to clocks/clock-bindings.txt for generic clock consumer properties.
-
-Example:
-
- sdhci@84b0000 {
- sd-uhs-sdr50;
- sd-uhs-ddr50;
- sd-uhs-sdr104;
- sdhci,auto-cmd12;
- compatible = "brcm,bcm7216-sdhci",
- "brcm,bcm7445-sdhci",
- "brcm,sdhci-brcmstb";
- reg = <0x84b0000 0x260 0x84b0300 0x200>;
- reg-names = "host", "cfg";
- interrupts = <0x0 0x26 0x4>;
- interrupt-names = "sdio0_0";
- clocks = <&scmi_clk 245>;
- clock-names = "sw_sdio";
- };
-
- sdhci@84b1000 {
- mmc-ddr-1_8v;
- mmc-hs200-1_8v;
- mmc-hs400-1_8v;
- mmc-hs400-enhanced-strobe;
- supports-cqe;
- non-removable;
- bus-width = <0x8>;
- compatible = "brcm,bcm7216-sdhci",
- "brcm,bcm7445-sdhci",
- "brcm,sdhci-brcmstb";
- reg = <0x84b1000 0x260 0x84b1300 0x200>;
- reg-names = "host", "cfg";
- interrupts = <0x0 0x27 0x4>;
- interrupt-names = "sdio1_0";
- clocks = <&scmi_clk 245>;
- clock-names = "sw_sdio";
- };
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
new file mode 100644
index 000000000000..dccd5ad96981
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/brcm,sdhci-brcmstb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BRCMSTB/BMIPS SDHCI Controller binding
+
+maintainers:
+ - Al Cooper <alcooperx@gmail.com>
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+allOf:
+ - $ref: mmc-controller.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - brcm,bcm7216-sdhci
+ - const: brcm,bcm7445-sdhci
+ - const: brcm,sdhci-brcmstb
+ - items:
+ - enum:
+ - brcm,bcm7445-sdhci
+ - const: brcm,sdhci-brcmstb
+ - items:
+ - enum:
+ - brcm,bcm7425-sdhci
+ - const: brcm,sdhci-brcmstb
+
+ reg:
+ minItems: 2
+
+ reg-names:
+ items:
+ - const: host
+ - const: cfg
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+ description:
+ handle to core clock for the sdhci controller.
+
+ clock-names:
+ items:
+ - const: sw_sdio
+
+ sdhci,auto-cmd12:
+ type: boolean
+ description: Specifies that controller should use auto CMD12
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ mmc@84b0000 {
+ sd-uhs-sdr50;
+ sd-uhs-ddr50;
+ sd-uhs-sdr104;
+ sdhci,auto-cmd12;
+ compatible = "brcm,bcm7216-sdhci",
+ "brcm,bcm7445-sdhci",
+ "brcm,sdhci-brcmstb";
+ reg = <0x84b0000 0x260>, <0x84b0300 0x200>;
+ reg-names = "host", "cfg";
+ interrupts = <0x0 0x26 0x4>;
+ interrupt-names = "sdio0_0";
+ clocks = <&scmi_clk 245>;
+ clock-names = "sw_sdio";
+ };
+
+ mmc@84b1000 {
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ supports-cqe;
+ non-removable;
+ bus-width = <0x8>;
+ compatible = "brcm,bcm7216-sdhci",
+ "brcm,bcm7445-sdhci",
+ "brcm,sdhci-brcmstb";
+ reg = <0x84b1000 0x260>, <0x84b1300 0x200>;
+ reg-names = "host", "cfg";
+ interrupts = <0x0 0x27 0x4>;
+ interrupt-names = "sdio1_0";
+ clocks = <&scmi_clk 245>;
+ clock-names = "sw_sdio";
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding to YAML
2021-12-08 0:37 ` [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding " Florian Fainelli
@ 2021-12-09 10:06 ` Ulf Hansson
2022-01-05 16:39 ` Rob Herring
1 sibling, 0 replies; 38+ messages in thread
From: Ulf Hansson @ 2021-12-09 10:06 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Rob Herring, Linus Walleij, open list,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...
- trimmed cc list
On Wed, 8 Dec 2021 at 01:37, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Convert the Broadcom STB SDHCI controller Device Tree binding to YAML.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> .../bindings/mmc/brcm,sdhci-brcmstb.txt | 53 ----------
> .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 100 ++++++++++++++++++
> 2 files changed, 100 insertions(+), 53 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
> deleted file mode 100644
> index ae2074184528..000000000000
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
> +++ /dev/null
> @@ -1,53 +0,0 @@
> -* BROADCOM BRCMSTB/BMIPS SDHCI Controller
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci-brcmstb driver.
> -
> -NOTE: The driver disables all UHS speed modes by default and depends
> -on Device Tree properties to enable them for SoC/Board combinations
> -that support them.
> -
> -Required properties:
> -- compatible: should be one of the following
> - - "brcm,bcm7425-sdhci"
> - - "brcm,bcm7445-sdhci"
> - - "brcm,bcm7216-sdhci"
> -
> -Refer to clocks/clock-bindings.txt for generic clock consumer properties.
> -
> -Example:
> -
> - sdhci@84b0000 {
> - sd-uhs-sdr50;
> - sd-uhs-ddr50;
> - sd-uhs-sdr104;
> - sdhci,auto-cmd12;
> - compatible = "brcm,bcm7216-sdhci",
> - "brcm,bcm7445-sdhci",
> - "brcm,sdhci-brcmstb";
> - reg = <0x84b0000 0x260 0x84b0300 0x200>;
> - reg-names = "host", "cfg";
> - interrupts = <0x0 0x26 0x4>;
> - interrupt-names = "sdio0_0";
> - clocks = <&scmi_clk 245>;
> - clock-names = "sw_sdio";
> - };
> -
> - sdhci@84b1000 {
> - mmc-ddr-1_8v;
> - mmc-hs200-1_8v;
> - mmc-hs400-1_8v;
> - mmc-hs400-enhanced-strobe;
> - supports-cqe;
> - non-removable;
> - bus-width = <0x8>;
> - compatible = "brcm,bcm7216-sdhci",
> - "brcm,bcm7445-sdhci",
> - "brcm,sdhci-brcmstb";
> - reg = <0x84b1000 0x260 0x84b1300 0x200>;
> - reg-names = "host", "cfg";
> - interrupts = <0x0 0x27 0x4>;
> - interrupt-names = "sdio1_0";
> - clocks = <&scmi_clk 245>;
> - clock-names = "sw_sdio";
> - };
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> new file mode 100644
> index 000000000000..dccd5ad96981
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/brcm,sdhci-brcmstb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BRCMSTB/BMIPS SDHCI Controller binding
> +
> +maintainers:
> + - Al Cooper <alcooperx@gmail.com>
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +allOf:
> + - $ref: mmc-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm7216-sdhci
> + - const: brcm,bcm7445-sdhci
> + - const: brcm,sdhci-brcmstb
> + - items:
> + - enum:
> + - brcm,bcm7445-sdhci
> + - const: brcm,sdhci-brcmstb
> + - items:
> + - enum:
> + - brcm,bcm7425-sdhci
> + - const: brcm,sdhci-brcmstb
> +
> + reg:
> + minItems: 2
> +
> + reg-names:
> + items:
> + - const: host
> + - const: cfg
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description:
> + handle to core clock for the sdhci controller.
> +
> + clock-names:
> + items:
> + - const: sw_sdio
> +
> + sdhci,auto-cmd12:
> + type: boolean
> + description: Specifies that controller should use auto CMD12
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + mmc@84b0000 {
> + sd-uhs-sdr50;
> + sd-uhs-ddr50;
> + sd-uhs-sdr104;
> + sdhci,auto-cmd12;
> + compatible = "brcm,bcm7216-sdhci",
> + "brcm,bcm7445-sdhci",
> + "brcm,sdhci-brcmstb";
> + reg = <0x84b0000 0x260>, <0x84b0300 0x200>;
> + reg-names = "host", "cfg";
> + interrupts = <0x0 0x26 0x4>;
> + interrupt-names = "sdio0_0";
> + clocks = <&scmi_clk 245>;
> + clock-names = "sw_sdio";
> + };
> +
> + mmc@84b1000 {
> + mmc-ddr-1_8v;
> + mmc-hs200-1_8v;
> + mmc-hs400-1_8v;
> + mmc-hs400-enhanced-strobe;
> + supports-cqe;
> + non-removable;
> + bus-width = <0x8>;
> + compatible = "brcm,bcm7216-sdhci",
> + "brcm,bcm7445-sdhci",
> + "brcm,sdhci-brcmstb";
> + reg = <0x84b1000 0x260>, <0x84b1300 0x200>;
> + reg-names = "host", "cfg";
> + interrupts = <0x0 0x27 0x4>;
> + interrupt-names = "sdio1_0";
> + clocks = <&scmi_clk 245>;
> + clock-names = "sw_sdio";
> + };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding to YAML
2021-12-08 0:37 ` [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding " Florian Fainelli
2021-12-09 10:06 ` Ulf Hansson
@ 2022-01-05 16:39 ` Rob Herring
1 sibling, 0 replies; 38+ messages in thread
From: Rob Herring @ 2022-01-05 16:39 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Damien Le Moal, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Tue, Dec 7, 2021 at 6:37 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Convert the Broadcom STB SDHCI controller Device Tree binding to YAML.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/mmc/brcm,sdhci-brcmstb.txt | 53 ----------
> .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 100 ++++++++++++++++++
> 2 files changed, 100 insertions(+), 53 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
> create mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
> deleted file mode 100644
> index ae2074184528..000000000000
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.txt
> +++ /dev/null
> @@ -1,53 +0,0 @@
> -* BROADCOM BRCMSTB/BMIPS SDHCI Controller
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci-brcmstb driver.
> -
> -NOTE: The driver disables all UHS speed modes by default and depends
> -on Device Tree properties to enable them for SoC/Board combinations
> -that support them.
> -
> -Required properties:
> -- compatible: should be one of the following
> - - "brcm,bcm7425-sdhci"
> - - "brcm,bcm7445-sdhci"
> - - "brcm,bcm7216-sdhci"
> -
> -Refer to clocks/clock-bindings.txt for generic clock consumer properties.
> -
> -Example:
> -
> - sdhci@84b0000 {
> - sd-uhs-sdr50;
> - sd-uhs-ddr50;
> - sd-uhs-sdr104;
> - sdhci,auto-cmd12;
> - compatible = "brcm,bcm7216-sdhci",
> - "brcm,bcm7445-sdhci",
> - "brcm,sdhci-brcmstb";
> - reg = <0x84b0000 0x260 0x84b0300 0x200>;
> - reg-names = "host", "cfg";
> - interrupts = <0x0 0x26 0x4>;
> - interrupt-names = "sdio0_0";
> - clocks = <&scmi_clk 245>;
> - clock-names = "sw_sdio";
> - };
> -
> - sdhci@84b1000 {
> - mmc-ddr-1_8v;
> - mmc-hs200-1_8v;
> - mmc-hs400-1_8v;
> - mmc-hs400-enhanced-strobe;
> - supports-cqe;
> - non-removable;
> - bus-width = <0x8>;
> - compatible = "brcm,bcm7216-sdhci",
> - "brcm,bcm7445-sdhci",
> - "brcm,sdhci-brcmstb";
> - reg = <0x84b1000 0x260 0x84b1300 0x200>;
> - reg-names = "host", "cfg";
> - interrupts = <0x0 0x27 0x4>;
> - interrupt-names = "sdio1_0";
> - clocks = <&scmi_clk 245>;
> - clock-names = "sw_sdio";
> - };
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> new file mode 100644
> index 000000000000..dccd5ad96981
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/brcm,sdhci-brcmstb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BRCMSTB/BMIPS SDHCI Controller binding
> +
> +maintainers:
> + - Al Cooper <alcooperx@gmail.com>
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +allOf:
> + - $ref: mmc-controller.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm7216-sdhci
> + - const: brcm,bcm7445-sdhci
> + - const: brcm,sdhci-brcmstb
> + - items:
> + - enum:
> + - brcm,bcm7445-sdhci
> + - const: brcm,sdhci-brcmstb
> + - items:
> + - enum:
> + - brcm,bcm7425-sdhci
> + - const: brcm,sdhci-brcmstb
> +
> + reg:
> + minItems: 2
> +
> + reg-names:
> + items:
> + - const: host
> + - const: cfg
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description:
> + handle to core clock for the sdhci controller.
> +
> + clock-names:
> + items:
> + - const: sw_sdio
> +
> + sdhci,auto-cmd12:
> + type: boolean
> + description: Specifies that controller should use auto CMD12
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + mmc@84b0000 {
> + sd-uhs-sdr50;
> + sd-uhs-ddr50;
> + sd-uhs-sdr104;
> + sdhci,auto-cmd12;
> + compatible = "brcm,bcm7216-sdhci",
> + "brcm,bcm7445-sdhci",
> + "brcm,sdhci-brcmstb";
> + reg = <0x84b0000 0x260>, <0x84b0300 0x200>;
> + reg-names = "host", "cfg";
> + interrupts = <0x0 0x26 0x4>;
> + interrupt-names = "sdio0_0";
Not documented.
Rob
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-09 9:41 ` Philipp Zabel
2021-12-14 17:47 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 03/15] dt-bindings: pwm: Convert BCM7038 PWM binding " Florian Fainelli
` (12 subsequent siblings)
14 siblings, 2 replies; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB SW_INIT style reset controller binding to YAML.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/reset/brcm,brcmstb-reset.txt | 27 -----------
.../bindings/reset/brcm,brcmstb-reset.yaml | 48 +++++++++++++++++++
2 files changed, 48 insertions(+), 27 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
create mode 100644 Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.yaml
diff --git a/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt b/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
deleted file mode 100644
index ee59409640f2..000000000000
--- a/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-Broadcom STB SW_INIT-style reset controller
-===========================================
-
-Broadcom STB SoCs have a SW_INIT-style reset controller with separate
-SET/CLEAR/STATUS registers and possibly multiple banks, each of 32 bit
-reset lines.
-
-Please also refer to reset.txt in this directory for common reset
-controller binding usage.
-
-Required properties:
-- compatible: should be brcm,brcmstb-reset
-- reg: register base and length
-- #reset-cells: must be set to 1
-
-Example:
-
- reset: reset-controller@8404318 {
- compatible = "brcm,brcmstb-reset";
- reg = <0x8404318 0x30>;
- #reset-cells = <1>;
- };
-
- ðernet_switch {
- resets = <&reset 26>;
- reset-names = "switch";
- };
diff --git a/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.yaml b/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.yaml
new file mode 100644
index 000000000000..e00efa88a198
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/reset/brcm,brcmstb-reset.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Broadcom STB SW_INIT-style reset controller
+
+description:
+ Broadcom STB SoCs have a SW_INIT-style reset controller with separate
+ SET/CLEAR/STATUS registers and possibly multiple banks, each of 32 bit
+ reset lines.
+
+ Please also refer to reset.txt in this directory for common reset
+ controller binding usage.
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+properties:
+ compatible:
+ const: brcm,brcmstb-reset
+
+ reg:
+ maxItems: 1
+
+ "#reset-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - "#reset-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ reset: reset-controller@8404318 {
+ compatible = "brcm,brcmstb-reset";
+ reg = <0x8404318 0x30>;
+ #reset-cells = <1>;
+ };
+
+ ethernet_switch {
+ resets = <&reset 26>;
+ reset-names = "switch";
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset to YAML
2021-12-08 0:37 ` [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset " Florian Fainelli
@ 2021-12-09 9:41 ` Philipp Zabel
2021-12-09 23:25 ` Florian Fainelli
2021-12-14 17:47 ` Rob Herring
1 sibling, 1 reply; 38+ messages in thread
From: Philipp Zabel @ 2021-12-09 9:41 UTC (permalink / raw)
To: Florian Fainelli, devicetree
Cc: Damien Le Moal, Rob Herring, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Herbert Xu, Ray Jui,
Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Tue, 2021-12-07 at 16:37 -0800, Florian Fainelli wrote:
> Convert the Broadcom STB SW_INIT style reset controller binding to YAML.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset to YAML
2021-12-09 9:41 ` Philipp Zabel
@ 2021-12-09 23:25 ` Florian Fainelli
0 siblings, 0 replies; 38+ messages in thread
From: Florian Fainelli @ 2021-12-09 23:25 UTC (permalink / raw)
To: Philipp Zabel, Florian Fainelli, devicetree
Cc: Damien Le Moal, Rob Herring, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Herbert Xu, Ray Jui,
Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On 12/9/21 1:41 AM, Philipp Zabel wrote:
> On Tue, 2021-12-07 at 16:37 -0800, Florian Fainelli wrote:
>> Convert the Broadcom STB SW_INIT style reset controller binding to YAML.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Thanks, sorry for not carrying your Ack that you provided in v2 already.
--
Florian
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset to YAML
2021-12-08 0:37 ` [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset " Florian Fainelli
2021-12-09 9:41 ` Philipp Zabel
@ 2021-12-14 17:47 ` Rob Herring
1 sibling, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 17:47 UTC (permalink / raw)
To: Florian Fainelli
Cc: Amit Kucheria, linux-arm-kernel, Thierry Reding,
Uwe Kleine-König, linux-rtc, Markus Mayer, linux-mmc,
bcm-kernel-feedback-list, Ray Jui, linux-pwm, Daniel Lezcano,
Greg Kroah-Hartman, Philipp Zabel, Damien Le Moal, Marc Zyngier,
Scott Branden, Zhang Rui, linux-ide, Gregory Fong, linux-crypto,
Herbert Xu, Alessandro Zummo, Rafael J. Wysocki, Linus Walleij,
Rob Herring, linux-pm, Bartosz Golaszewski, Doug Berger,
linux-usb, Thomas Gleixner, Al Cooper, Alexandre Belloni,
Lee Jones, linux-gpio, linux-kernel, Ulf Hansson, devicetree
On Tue, 07 Dec 2021 16:37:13 -0800, Florian Fainelli wrote:
> Convert the Broadcom STB SW_INIT style reset controller binding to YAML.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/reset/brcm,brcmstb-reset.txt | 27 -----------
> .../bindings/reset/brcm,brcmstb-reset.yaml | 48 +++++++++++++++++++
> 2 files changed, 48 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.txt
> create mode 100644 Documentation/devicetree/bindings/reset/brcm,brcmstb-reset.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 03/15] dt-bindings: pwm: Convert BCM7038 PWM binding to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding " Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 17:47 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 04/15] dt-bindings: rtc: Convert Broadcom STB waketimer " Florian Fainelli
` (11 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Uwe Kleine-König, Damien Le Moal,
Rob Herring, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Lee Jones, Philipp Zabel, Herbert Xu, Ray Jui, Scott Branden,
Alessandro Zummo, Alexandre Belloni, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Markus Mayer,
Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB BCM7038 PWM Device Tree binding to YAML to help
with validation.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/pwm/brcm,bcm7038-pwm.txt | 20 ---------
.../bindings/pwm/brcm,bcm7038-pwm.yaml | 43 +++++++++++++++++++
2 files changed, 43 insertions(+), 20 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.txt
create mode 100644 Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
diff --git a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.txt b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.txt
deleted file mode 100644
index 0e662d7f6bd1..000000000000
--- a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-Broadcom BCM7038 PWM controller (BCM7xxx Set Top Box PWM controller)
-
-Required properties:
-
-- compatible: must be "brcm,bcm7038-pwm"
-- reg: physical base address and length for this controller
-- #pwm-cells: should be 2. See pwm.yaml in this directory for a description
- of the cells format
-- clocks: a phandle to the reference clock for this block which is fed through
- its internal variable clock frequency generator
-
-
-Example:
-
- pwm: pwm@f0408000 {
- compatible = "brcm,bcm7038-pwm";
- reg = <0xf0408000 0x28>;
- #pwm-cells = <2>;
- clocks = <&upg_fixed>;
- };
diff --git a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
new file mode 100644
index 000000000000..4080e098f746
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/brcm,bcm7038-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM7038 PWM controller (BCM7xxx Set Top Box PWM controller)
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ const: brcm,bcm7038-pwm
+
+ reg:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 2
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - "#pwm-cells"
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ pwm: pwm@f0408000 {
+ compatible = "brcm,bcm7038-pwm";
+ reg = <0xf0408000 0x28>;
+ #pwm-cells = <2>;
+ clocks = <&upg_fixed>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 03/15] dt-bindings: pwm: Convert BCM7038 PWM binding to YAML
2021-12-08 0:37 ` [PATCH v3 03/15] dt-bindings: pwm: Convert BCM7038 PWM binding " Florian Fainelli
@ 2021-12-14 17:47 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 17:47 UTC (permalink / raw)
To: Florian Fainelli
Cc: Uwe Kleine-König, Ulf Hansson, Ray Jui, Doug Berger,
Herbert Xu, devicetree, bcm-kernel-feedback-list, Zhang Rui,
Greg Kroah-Hartman, Philipp Zabel, Marc Zyngier,
Alessandro Zummo, Markus Mayer, linux-ide, linux-usb, linux-rtc,
Bartosz Golaszewski, Damien Le Moal, linux-pwm, linux-crypto,
Rafael J. Wysocki, Linus Walleij, Scott Branden,
linux-arm-kernel, linux-gpio, Rob Herring, Lee Jones,
Thomas Gleixner, Amit Kucheria, Alexandre Belloni,
Thierry Reding, Al Cooper, linux-pm, linux-kernel,
Daniel Lezcano, linux-mmc, Gregory Fong
On Tue, 07 Dec 2021 16:37:14 -0800, Florian Fainelli wrote:
> Convert the Broadcom STB BCM7038 PWM Device Tree binding to YAML to help
> with validation.
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/pwm/brcm,bcm7038-pwm.txt | 20 ---------
> .../bindings/pwm/brcm,bcm7038-pwm.yaml | 43 +++++++++++++++++++
> 2 files changed, 43 insertions(+), 20 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.txt
> create mode 100644 Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 04/15] dt-bindings: rtc: Convert Broadcom STB waketimer to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (2 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 03/15] dt-bindings: pwm: Convert BCM7038 PWM binding " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 18:00 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
` (10 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB waketimer Device Tree binding to YAML to help
with validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/rtc/brcm,brcmstb-waketimer.txt | 20 ---------
.../bindings/rtc/brcm,brcmstb-waketimer.yaml | 44 +++++++++++++++++++
2 files changed, 44 insertions(+), 20 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.txt
create mode 100644 Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.yaml
diff --git a/Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.txt b/Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.txt
deleted file mode 100644
index d946f28502b3..000000000000
--- a/Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-Broadcom STB wake-up Timer
-
-The Broadcom STB wake-up timer provides a 27Mhz resolution timer, with the
-ability to wake up the system from low-power suspend/standby modes.
-
-Required properties:
-- compatible : should contain "brcm,brcmstb-waketimer"
-- reg : the register start and length for the WKTMR block
-- interrupts : The TIMER interrupt
-- clocks : The phandle to the UPG fixed clock (27Mhz domain)
-
-Example:
-
-waketimer@f0411580 {
- compatible = "brcm,brcmstb-waketimer";
- reg = <0xf0411580 0x14>;
- interrupts = <0x3>;
- interrupt-parent = <&aon_pm_l2_intc>;
- clocks = <&upg_fixed>;
-};
diff --git a/Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.yaml b/Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.yaml
new file mode 100644
index 000000000000..9fe079917a98
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/brcm,brcmstb-waketimer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom STB wake-up Timer
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+description:
+ The Broadcom STB wake-up timer provides a 27Mhz resolution timer, with the
+ ability to wake up the system from low-power suspend/standby modes.
+
+allOf:
+ - $ref: "rtc.yaml#"
+
+properties:
+ compatible:
+ const: brcm,brcmstb-waketimer
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ description: the TIMER interrupt
+ maxItems: 1
+
+ clocks:
+ description: clock reference in the 27MHz domain
+ maxItems: 1
+
+additionalProperties: false
+
+examples:
+ - |
+ rtc@f0411580 {
+ compatible = "brcm,brcmstb-waketimer";
+ reg = <0xf0411580 0x14>;
+ interrupts = <0x3>;
+ interrupt-parent = <&aon_pm_l2_intc>;
+ clocks = <&upg_fixed>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 04/15] dt-bindings: rtc: Convert Broadcom STB waketimer to YAML
2021-12-08 0:37 ` [PATCH v3 04/15] dt-bindings: rtc: Convert Broadcom STB waketimer " Florian Fainelli
@ 2021-12-14 18:00 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:00 UTC (permalink / raw)
To: Florian Fainelli
Cc: Thierry Reding, Marc Zyngier, Zhang Rui, Gregory Fong,
Linus Walleij, linux-ide, Herbert Xu, Rafael J. Wysocki,
Greg Kroah-Hartman, linux-arm-kernel, Damien Le Moal, Ray Jui,
Philipp Zabel, Daniel Lezcano, devicetree, Al Cooper,
Rob Herring, linux-usb, linux-mmc, Lee Jones, Amit Kucheria,
Scott Branden, Doug Berger, linux-crypto, Markus Mayer,
Thomas Gleixner, linux-pm, Bartosz Golaszewski, Alessandro Zummo,
Uwe Kleine-König, Alexandre Belloni, linux-kernel,
Ulf Hansson, linux-pwm, linux-gpio, linux-rtc,
bcm-kernel-feedback-list
On Tue, 07 Dec 2021 16:37:15 -0800, Florian Fainelli wrote:
> Convert the Broadcom STB waketimer Device Tree binding to YAML to help
> with validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/rtc/brcm,brcmstb-waketimer.txt | 20 ---------
> .../bindings/rtc/brcm,brcmstb-waketimer.yaml | 44 +++++++++++++++++++
> 2 files changed, 44 insertions(+), 20 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/brcm,brcmstb-waketimer.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (3 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 04/15] dt-bindings: rtc: Convert Broadcom STB waketimer " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-10 1:44 ` Linus Walleij
` (2 more replies)
2021-12-08 0:37 ` [PATCH v3 06/15] dt-binding: interrupt-controller: Convert BCM7038 L1 intc " Florian Fainelli
` (9 subsequent siblings)
14 siblings, 3 replies; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Gregory Fong, Damien Le Moal, Rob Herring,
Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Thomas Gleixner,
Marc Zyngier, Ulf Hansson, Thierry Reding, Uwe Kleine-König,
Lee Jones, Philipp Zabel, Herbert Xu, Ray Jui, Scott Branden,
Alessandro Zummo, Alexandre Belloni, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Markus Mayer,
Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB GPIO Device Tree binding to YAML to help with
validation.
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/gpio/brcm,brcmstb-gpio.txt | 83 --------------
.../bindings/gpio/brcm,brcmstb-gpio.yaml | 105 ++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 106 insertions(+), 84 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
create mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
diff --git a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
deleted file mode 100644
index 5d468ecd1809..000000000000
--- a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
+++ /dev/null
@@ -1,83 +0,0 @@
-Broadcom STB "UPG GIO" GPIO controller
-
-The controller's registers are organized as sets of eight 32-bit
-registers with each set controlling a bank of up to 32 pins. A single
-interrupt is shared for all of the banks handled by the controller.
-
-Required properties:
-
-- compatible:
- Must be "brcm,brcmstb-gpio"
-
-- reg:
- Define the base and range of the I/O address space containing
- the brcmstb GPIO controller registers
-
-- #gpio-cells:
- Should be <2>. The first cell is the pin number (within the controller's
- pin space), and the second is used for the following:
- bit[0]: polarity (0 for active-high, 1 for active-low)
-
-- gpio-controller:
- Specifies that the node is a GPIO controller.
-
-- brcm,gpio-bank-widths:
- Number of GPIO lines for each bank. Number of elements must
- correspond to number of banks suggested by the 'reg' property.
-
-Optional properties:
-
-- interrupts:
- The interrupt shared by all GPIO lines for this controller.
-
-- interrupts-extended:
- Alternate form of specifying interrupts and parents that allows for
- multiple parents. This takes precedence over 'interrupts' and
- 'interrupt-parent'. Wakeup-capable GPIO controllers often route their
- wakeup interrupt lines through a different interrupt controller than the
- primary interrupt line, making this property necessary.
-
-- #interrupt-cells:
- Should be <2>. The first cell is the GPIO number, the second should specify
- flags. The following subset of flags is supported:
- - bits[3:0] trigger type and level flags
- 1 = low-to-high edge triggered
- 2 = high-to-low edge triggered
- 4 = active high level-sensitive
- 8 = active low level-sensitive
- Valid combinations are 1, 2, 3, 4, 8.
- See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
-
-- interrupt-controller:
- Marks the device node as an interrupt controller
-
-- wakeup-source:
- GPIOs for this controller can be used as a wakeup source
-
-Example:
- upg_gio: gpio@f040a700 {
- #gpio-cells = <2>;
- #interrupt-cells = <2>;
- compatible = "brcm,bcm7445-gpio", "brcm,brcmstb-gpio";
- gpio-controller;
- interrupt-controller;
- reg = <0xf040a700 0x80>;
- interrupt-parent = <&irq0_intc>;
- interrupts = <0x6>;
- brcm,gpio-bank-widths = <32 32 32 24>;
- };
-
- upg_gio_aon: gpio@f04172c0 {
- #gpio-cells = <2>;
- #interrupt-cells = <2>;
- compatible = "brcm,bcm7445-gpio", "brcm,brcmstb-gpio";
- gpio-controller;
- interrupt-controller;
- reg = <0xf04172c0 0x40>;
- interrupt-parent = <&irq0_aon_intc>;
- interrupts = <0x6>;
- interrupts-extended = <&irq0_aon_intc 0x6>,
- <&aon_pm_l2_intc 0x5>;
- wakeup-source;
- brcm,gpio-bank-widths = <18 4>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
new file mode 100644
index 000000000000..8c27932df2c5
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/brcm,brcmstb-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom STB "UPG GIO" GPIO controller
+
+description: >
+ The controller's registers are organized as sets of eight 32-bit
+ registers with each set controlling a bank of up to 32 pins. A single
+ interrupt is shared for all of the banks handled by the controller.
+
+maintainers:
+ - Doug Berger <opendmb@gmail.com>
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - brcm,bcm7445-gpio
+ - const: brcm,brcmstb-gpio
+
+ reg:
+ maxItems: 1
+ description: >
+ Define the base and range of the I/O address space containing
+ the brcmstb GPIO controller registers
+
+ "#gpio-cells":
+ const: 2
+ description: >
+ The first cell is the pin number (within the controller's
+ pin space), and the second is used for the following:
+ bit[0]: polarity (0 for active-high, 1 for active-low)
+
+ gpio-controller: true
+
+ "brcm,gpio-bank-widths":
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description: >
+ Number of GPIO lines for each bank. Number of elements must
+ correspond to number of banks suggested by the 'reg' property.
+
+ interrupts:
+ maxItems: 1
+ description: >
+ The interrupt shared by all GPIO lines for this controller.
+
+ "#interrupt-cells":
+ const: 2
+ description: |
+ The first cell is the GPIO number, the second should specify
+ flags. The following subset of flags is supported:
+ - bits[3:0] trigger type and level flags
+ 1 = low-to-high edge triggered
+ 2 = high-to-low edge triggered
+ 4 = active high level-sensitive
+ 8 = active low level-sensitive
+ Valid combinations are 1, 2, 3, 4, 8.
+
+ interrupt-controller: true
+
+ wakeup-source:
+ type: boolean
+ description: >
+ GPIOs for this controller can be used as a wakeup source
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - "#gpio-cells"
+ - "brcm,gpio-bank-widths"
+
+additionalProperties: false
+
+examples:
+ - |
+ upg_gio: gpio@f040a700 {
+ #gpio-cells = <2>;
+ #interrupt-cells = <2>;
+ compatible = "brcm,bcm7445-gpio", "brcm,brcmstb-gpio";
+ gpio-controller;
+ interrupt-controller;
+ reg = <0xf040a700 0x80>;
+ interrupt-parent = <&irq0_intc>;
+ interrupts = <0x6>;
+ brcm,gpio-bank-widths = <32 32 32 24>;
+ };
+
+ upg_gio_aon: gpio@f04172c0 {
+ #gpio-cells = <2>;
+ #interrupt-cells = <2>;
+ compatible = "brcm,bcm7445-gpio", "brcm,brcmstb-gpio";
+ gpio-controller;
+ interrupt-controller;
+ reg = <0xf04172c0 0x40>;
+ interrupt-parent = <&irq0_aon_intc>;
+ interrupts = <0x6>;
+ wakeup-source;
+ brcm,gpio-bank-widths = <18 4>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a2345ce8521..9ac67c885159 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3761,7 +3761,7 @@ BROADCOM BRCMSTB GPIO DRIVER
M: Gregory Fong <gregory.0xf0@gmail.com>
L: bcm-kernel-feedback-list@broadcom.com
S: Supported
-F: Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
+F: Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
F: drivers/gpio/gpio-brcmstb.c
BROADCOM BRCMSTB I2C DRIVER
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO to YAML
2021-12-08 0:37 ` [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
@ 2021-12-10 1:44 ` Linus Walleij
2021-12-10 15:22 ` Bartosz Golaszewski
2021-12-14 18:02 ` Rob Herring
2 siblings, 0 replies; 38+ messages in thread
From: Linus Walleij @ 2021-12-10 1:44 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Gregory Fong, Damien Le Moal, Rob Herring,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Thomas Gleixner,
Marc Zyngier, Ulf Hansson, Thierry Reding, Uwe Kleine-König,
Lee Jones, Philipp Zabel, Herbert Xu, Ray Jui, Scott Branden,
Alessandro Zummo, Alexandre Belloni, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Markus Mayer,
Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Wed, Dec 8, 2021 at 1:37 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
> Convert the Broadcom STB GPIO Device Tree binding to YAML to help with
> validation.
>
> Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Looks good to me.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO to YAML
2021-12-08 0:37 ` [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
2021-12-10 1:44 ` Linus Walleij
@ 2021-12-10 15:22 ` Bartosz Golaszewski
2021-12-14 18:02 ` Rob Herring
2 siblings, 0 replies; 38+ messages in thread
From: Bartosz Golaszewski @ 2021-12-10 15:22 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Gregory Fong, Damien Le Moal, Rob Herring,
Linus Walleij, maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Wed, Dec 8, 2021 at 1:37 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Convert the Broadcom STB GPIO Device Tree binding to YAML to help with
> validation.
>
> Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO to YAML
2021-12-08 0:37 ` [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
2021-12-10 1:44 ` Linus Walleij
2021-12-10 15:22 ` Bartosz Golaszewski
@ 2021-12-14 18:02 ` Rob Herring
2 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:02 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, linux-ide, linux-usb, Philipp Zabel,
bcm-kernel-feedback-list, linux-pwm, Rob Herring, linux-mmc,
linux-gpio, Marc Zyngier, Damien Le Moal, Amit Kucheria,
Markus Mayer, Alessandro Zummo, linux-kernel, Gregory Fong,
Ray Jui, Zhang Rui, Bartosz Golaszewski, Al Cooper,
Uwe Kleine-König, Ulf Hansson, Alexandre Belloni, linux-pm,
Rafael J. Wysocki, devicetree, Linus Walleij, Lee Jones,
Herbert Xu, Thomas Gleixner, Greg Kroah-Hartman, Doug Berger,
Scott Branden, linux-crypto, linux-rtc, Daniel Lezcano,
Thierry Reding
On Tue, 07 Dec 2021 16:37:16 -0800, Florian Fainelli wrote:
> Convert the Broadcom STB GPIO Device Tree binding to YAML to help with
> validation.
>
> Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/gpio/brcm,brcmstb-gpio.txt | 83 --------------
> .../bindings/gpio/brcm,brcmstb-gpio.yaml | 105 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 106 insertions(+), 84 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 06/15] dt-binding: interrupt-controller: Convert BCM7038 L1 intc to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (4 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 18:04 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 07/15] dt-bindings: interrupt-controller: Convert BCM7120 L2 " Florian Fainelli
` (8 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB BCM7038 Level 1 interrupt controller Device
Tree binding to YAML to help with validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../brcm,bcm7038-l1-intc.txt | 61 -------------
.../brcm,bcm7038-l1-intc.yaml | 91 +++++++++++++++++++
2 files changed, 91 insertions(+), 61 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.yaml
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt
deleted file mode 100644
index 5ddef1dc0c1a..000000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt
+++ /dev/null
@@ -1,61 +0,0 @@
-Broadcom BCM7038-style Level 1 interrupt controller
-
-This block is a first level interrupt controller that is typically connected
-directly to one of the HW INT lines on each CPU. Every BCM7xxx set-top chip
-since BCM7038 has contained this hardware.
-
-Key elements of the hardware design include:
-
-- 64, 96, 128, or 160 incoming level IRQ lines
-
-- Most onchip peripherals are wired directly to an L1 input
-
-- A separate instance of the register set for each CPU, allowing individual
- peripheral IRQs to be routed to any CPU
-
-- Atomic mask/unmask operations
-
-- No polarity/level/edge settings
-
-- No FIFO or priority encoder logic; software is expected to read all
- 2-5 status words to determine which IRQs are pending
-
-Required properties:
-
-- compatible: should be "brcm,bcm7038-l1-intc"
-- reg: specifies the base physical address and size of the registers;
- the number of supported IRQs is inferred from the size argument
-- interrupt-controller: identifies the node as an interrupt controller
-- #interrupt-cells: specifies the number of cells needed to encode an interrupt
- source, should be 1.
-- interrupts: specifies the interrupt line(s) in the interrupt-parent controller
- node; valid values depend on the type of parent interrupt controller
-
-Optional properties:
-
-- brcm,irq-can-wake: If present, this means the L1 controller can be used as a
- wakeup source for system suspend/resume.
-
-Optional properties:
-
-- brcm,int-fwd-mask: if present, a bit mask to indicate which interrupts
- have already been configured by the firmware and should be left unmanaged.
- This should have one 32-bit word per status/set/clear/mask group.
-
-If multiple reg ranges and interrupt-parent entries are present on an SMP
-system, the driver will allow IRQ SMP affinity to be set up through the
-/proc/irq/ interface. In the simplest possible configuration, only one
-reg range and one interrupt-parent is needed.
-
-Example:
-
-periph_intc: periph_intc@1041a400 {
- compatible = "brcm,bcm7038-l1-intc";
- reg = <0x1041a400 0x30 0x1041a600 0x30>;
-
- interrupt-controller;
- #interrupt-cells = <1>;
-
- interrupt-parent = <&cpu_intc>;
- interrupts = <2>, <3>;
-};
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.yaml
new file mode 100644
index 000000000000..5ecb6faa70dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm7038-l1-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM7038-style Level 1 interrupt controller
+
+description: >
+ This block is a first level interrupt controller that is typically connected
+ directly to one of the HW INT lines on each CPU. Every BCM7xxx set-top chip
+ since BCM7038 has contained this hardware.
+
+ Key elements of the hardware design include:
+
+ - 64, 96, 128, or 160 incoming level IRQ lines
+
+ - Most onchip peripherals are wired directly to an L1 input
+
+ - A separate instance of the register set for each CPU, allowing individual
+ peripheral IRQs to be routed to any CPU
+
+ - Atomic mask/unmask operations
+
+ - No polarity/level/edge settings
+
+ - No FIFO or priority encoder logic; software is expected to read all
+ 2-5 status words to determine which IRQs are pending
+
+ If multiple reg ranges and interrupt-parent entries are present on an SMP
+ system, the driver will allow IRQ SMP affinity to be set up through the
+ /proc/irq/ interface. In the simplest possible configuration, only one
+ reg range and one interrupt-parent is needed.
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+allOf:
+ - $ref: /schemas/interrupt-controller.yaml#
+
+properties:
+ compatible:
+ const: brcm,bcm7038-l1-intc
+
+ reg:
+ description: >
+ Specifies the base physical address and size of the registers
+ the number of supported IRQs is inferred from the size argument
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 1
+
+ interrupts:
+ description: >
+ Specifies the interrupt line(s) in the interrupt-parent controller node;
+ valid values depend on the type of parent interrupt controller
+
+ brcm,irq-can-wake:
+ type: boolean
+ description: >
+ If present, this means the L1 controller can be used as a
+ wakeup source for system suspend/resume.
+
+ brcm,int-fwd-mask:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ If present, a bit mask to indicate which interrupts have already been
+ configured by the firmware and should be left unmanaged. This should
+ have one 32-bit word per status/set/clear/mask group.
+
+required:
+ - compatible
+ - reg
+ - interrupt-controller
+ - "#interrupt-cells"
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ periph_intc: interrupt-controller@1041a400 {
+ compatible = "brcm,bcm7038-l1-intc";
+ reg = <0x1041a400 0x30>, <0x1041a600 0x30>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ interrupt-parent = <&cpu_intc>;
+ interrupts = <2>, <3>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 06/15] dt-binding: interrupt-controller: Convert BCM7038 L1 intc to YAML
2021-12-08 0:37 ` [PATCH v3 06/15] dt-binding: interrupt-controller: Convert BCM7038 L1 intc " Florian Fainelli
@ 2021-12-14 18:04 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:04 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-crypto, Alexandre Belloni, Al Cooper, linux-arm-kernel,
linux-rtc, Zhang Rui, linux-usb, Doug Berger, Philipp Zabel,
linux-ide, Damien Le Moal, Thierry Reding, Rafael J. Wysocki,
Lee Jones, linux-pwm, Marc Zyngier, Scott Branden, linux-pm,
linux-mmc, Bartosz Golaszewski, Daniel Lezcano, Amit Kucheria,
devicetree, Linus Walleij, Ulf Hansson, Greg Kroah-Hartman,
Ray Jui, Herbert Xu, Thomas Gleixner, Alessandro Zummo,
Markus Mayer, Gregory Fong, bcm-kernel-feedback-list,
Rob Herring, linux-kernel, Uwe Kleine-König, linux-gpio
On Tue, 07 Dec 2021 16:37:17 -0800, Florian Fainelli wrote:
> Convert the Broadcom STB BCM7038 Level 1 interrupt controller Device
> Tree binding to YAML to help with validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../brcm,bcm7038-l1-intc.txt | 61 -------------
> .../brcm,bcm7038-l1-intc.yaml | 91 +++++++++++++++++++
> 2 files changed, 91 insertions(+), 61 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.txt
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7038-l1-intc.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 07/15] dt-bindings: interrupt-controller: Convert BCM7120 L2 to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (5 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 06/15] dt-binding: interrupt-controller: Convert BCM7038 L1 intc " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 18:06 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 08/15] dt-bindings: interrupt-controller: Merge BCM3380 with BCM7120 Florian Fainelli
` (7 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom BCM7120 Level 2 interrupt controller Device Tree
binding to YAML to help with validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../brcm,bcm7120-l2-intc.txt | 88 -------------
.../brcm,bcm7120-l2-intc.yaml | 123 ++++++++++++++++++
2 files changed, 123 insertions(+), 88 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt
deleted file mode 100644
index addd86b6ca2f..000000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt
+++ /dev/null
@@ -1,88 +0,0 @@
-Broadcom BCM7120-style Level 2 interrupt controller
-
-This interrupt controller hardware is a second level interrupt controller that
-is hooked to a parent interrupt controller: e.g: ARM GIC for ARM-based
-platforms. It can be found on BCM7xxx products starting with BCM7120.
-
-Such an interrupt controller has the following hardware design:
-
-- outputs multiple interrupts signals towards its interrupt controller parent
-
-- controls how some of the interrupts will be flowing, whether they will
- directly output an interrupt signal towards the interrupt controller parent,
- or if they will output an interrupt signal at this 2nd level interrupt
- controller, in particular for UARTs
-
-- has one 32-bit enable word and one 32-bit status word
-
-- no atomic set/clear operations
-
-- not all bits within the interrupt controller actually map to an interrupt
-
-The typical hardware layout for this controller is represented below:
-
-2nd level interrupt line Outputs for the parent controller (e.g: ARM GIC)
-
-0 -----[ MUX ] ------------|==========> GIC interrupt 75
- \-----------\
- |
-1 -----[ MUX ] --------)---|==========> GIC interrupt 76
- \------------|
- |
-2 -----[ MUX ] --------)---|==========> GIC interrupt 77
- \------------|
- |
-3 ---------------------|
-4 ---------------------|
-5 ---------------------|
-7 ---------------------|---|===========> GIC interrupt 66
-9 ---------------------|
-10 --------------------|
-11 --------------------/
-
-6 ------------------------\
- |===========> GIC interrupt 64
-8 ------------------------/
-
-12 ........................ X
-13 ........................ X (not connected)
-..
-31 ........................ X
-
-Required properties:
-
-- compatible: should be "brcm,bcm7120-l2-intc"
-- reg: specifies the base physical address and size of the registers
-- interrupt-controller: identifies the node as an interrupt controller
-- #interrupt-cells: specifies the number of cells needed to encode an interrupt
- source, should be 1.
-- interrupts: specifies the interrupt line(s) in the interrupt-parent controller
- node, valid values depend on the type of parent interrupt controller
-- brcm,int-map-mask: 32-bits bit mask describing how many and which interrupts
- are wired to this 2nd level interrupt controller, and how they match their
- respective interrupt parents. Should match exactly the number of interrupts
- specified in the 'interrupts' property.
-
-Optional properties:
-
-- brcm,irq-can-wake: if present, this means the L2 controller can be used as a
- wakeup source for system suspend/resume.
-
-- brcm,int-fwd-mask: if present, a bit mask to configure the interrupts which
- have a mux gate, typically UARTs. Setting these bits will make their
- respective interrupt outputs bypass this 2nd level interrupt controller
- completely; it is completely transparent for the interrupt controller
- parent. This should have one 32-bit word per enable/status pair.
-
-Example:
-
-irq0_intc: interrupt-controller@f0406800 {
- compatible = "brcm,bcm7120-l2-intc";
- interrupt-parent = <&intc>;
- #interrupt-cells = <1>;
- reg = <0xf0406800 0x8>;
- interrupt-controller;
- interrupts = <0x0 0x42 0x0>, <0x0 0x40 0x0>;
- brcm,int-map-mask = <0xeb8>, <0x140>;
- brcm,int-fwd-mask = <0x7>;
-};
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
new file mode 100644
index 000000000000..e0c6dce40d13
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
@@ -0,0 +1,123 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm7120-l2-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM7120-style Level 2 interrupt controller
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+description: >
+ This interrupt controller hardware is a second level interrupt controller that
+ is hooked to a parent interrupt controller: e.g: ARM GIC for ARM-based
+ platforms. It can be found on BCM7xxx products starting with BCM7120.
+
+ Such an interrupt controller has the following hardware design:
+
+ - outputs multiple interrupts signals towards its interrupt controller parent
+
+ - controls how some of the interrupts will be flowing, whether they will
+ directly output an interrupt signal towards the interrupt controller parent,
+ or if they will output an interrupt signal at this 2nd level interrupt
+ controller, in particular for UARTs
+
+ - has one 32-bit enable word and one 32-bit status word
+
+ - no atomic set/clear operations
+
+ - not all bits within the interrupt controller actually map to an interrupt
+
+ The typical hardware layout for this controller is represented below:
+
+ 2nd level interrupt line Outputs for the parent controller (e.g: ARM GIC)
+
+ 0 -----[ MUX ] ------------|==========> GIC interrupt 75
+ \-----------\
+ |
+ 1 -----[ MUX ] --------)---|==========> GIC interrupt 76
+ \------------|
+ |
+ 2 -----[ MUX ] --------)---|==========> GIC interrupt 77
+ \------------|
+ |
+ 3 ---------------------|
+ 4 ---------------------|
+ 5 ---------------------|
+ 7 ---------------------|---|===========> GIC interrupt 66
+ 9 ---------------------|
+ 10 --------------------|
+ 11 --------------------/
+
+ 6 ------------------------\
+ |===========> GIC interrupt 64
+ 8 ------------------------/
+
+ 12 ........................ X
+ 13 ........................ X (not connected)
+ ..
+ 31 ........................ X
+
+allOf:
+ - $ref: /schemas/interrupt-controller.yaml#
+
+properties:
+ compatible:
+ const: brcm,bcm7120-l2-intc
+
+ reg:
+ description: >
+ Specifies the base physical address and size of the registers
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 1
+
+ interrupts: true
+
+ "brcm,int-map-mask":
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description: >
+ 32-bits bit mask describing how many and which interrupts are wired to
+ this 2nd level interrupt controller, and how they match their respective
+ interrupt parents. Should match exactly the number of interrupts
+ specified in the 'interrupts' property.
+
+ brcm,irq-can-wake:
+ type: boolean
+ description: >
+ If present, this means the L2 controller can be used as a wakeup source
+ for system suspend/resume.
+
+ brcm,int-fwd-mask:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: >
+ if present, a bit mask to configure the interrupts which have a mux gate,
+ typically UARTs. Setting these bits will make their respective interrupt
+ outputs bypass this 2nd level interrupt controller completely; it is
+ completely transparent for the interrupt controller parent. This should
+ have one 32-bit word per enable/status pair.
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupt-controller
+ - "#interrupt-cells"
+ - interrupts
+
+examples:
+ - |
+ irq0_intc: interrupt-controller@f0406800 {
+ compatible = "brcm,bcm7120-l2-intc";
+ interrupt-parent = <&intc>;
+ #interrupt-cells = <1>;
+ reg = <0xf0406800 0x8>;
+ interrupt-controller;
+ interrupts = <0x0 0x42 0x0>, <0x0 0x40 0x0>;
+ brcm,int-map-mask = <0xeb8>, <0x140>;
+ brcm,int-fwd-mask = <0x7>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 07/15] dt-bindings: interrupt-controller: Convert BCM7120 L2 to YAML
2021-12-08 0:37 ` [PATCH v3 07/15] dt-bindings: interrupt-controller: Convert BCM7120 L2 " Florian Fainelli
@ 2021-12-14 18:06 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:06 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Damien Le Moal, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Tue, Dec 07, 2021 at 04:37:18PM -0800, Florian Fainelli wrote:
> Convert the Broadcom BCM7120 Level 2 interrupt controller Device Tree
> binding to YAML to help with validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../brcm,bcm7120-l2-intc.txt | 88 -------------
> .../brcm,bcm7120-l2-intc.yaml | 123 ++++++++++++++++++
> 2 files changed, 123 insertions(+), 88 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt
> deleted file mode 100644
> index addd86b6ca2f..000000000000
> --- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt
> +++ /dev/null
> @@ -1,88 +0,0 @@
> -Broadcom BCM7120-style Level 2 interrupt controller
> -
> -This interrupt controller hardware is a second level interrupt controller that
> -is hooked to a parent interrupt controller: e.g: ARM GIC for ARM-based
> -platforms. It can be found on BCM7xxx products starting with BCM7120.
> -
> -Such an interrupt controller has the following hardware design:
> -
> -- outputs multiple interrupts signals towards its interrupt controller parent
> -
> -- controls how some of the interrupts will be flowing, whether they will
> - directly output an interrupt signal towards the interrupt controller parent,
> - or if they will output an interrupt signal at this 2nd level interrupt
> - controller, in particular for UARTs
> -
> -- has one 32-bit enable word and one 32-bit status word
> -
> -- no atomic set/clear operations
> -
> -- not all bits within the interrupt controller actually map to an interrupt
> -
> -The typical hardware layout for this controller is represented below:
> -
> -2nd level interrupt line Outputs for the parent controller (e.g: ARM GIC)
> -
> -0 -----[ MUX ] ------------|==========> GIC interrupt 75
> - \-----------\
> - |
> -1 -----[ MUX ] --------)---|==========> GIC interrupt 76
> - \------------|
> - |
> -2 -----[ MUX ] --------)---|==========> GIC interrupt 77
> - \------------|
> - |
> -3 ---------------------|
> -4 ---------------------|
> -5 ---------------------|
> -7 ---------------------|---|===========> GIC interrupt 66
> -9 ---------------------|
> -10 --------------------|
> -11 --------------------/
> -
> -6 ------------------------\
> - |===========> GIC interrupt 64
> -8 ------------------------/
> -
> -12 ........................ X
> -13 ........................ X (not connected)
> -..
> -31 ........................ X
> -
> -Required properties:
> -
> -- compatible: should be "brcm,bcm7120-l2-intc"
> -- reg: specifies the base physical address and size of the registers
> -- interrupt-controller: identifies the node as an interrupt controller
> -- #interrupt-cells: specifies the number of cells needed to encode an interrupt
> - source, should be 1.
> -- interrupts: specifies the interrupt line(s) in the interrupt-parent controller
> - node, valid values depend on the type of parent interrupt controller
> -- brcm,int-map-mask: 32-bits bit mask describing how many and which interrupts
> - are wired to this 2nd level interrupt controller, and how they match their
> - respective interrupt parents. Should match exactly the number of interrupts
> - specified in the 'interrupts' property.
> -
> -Optional properties:
> -
> -- brcm,irq-can-wake: if present, this means the L2 controller can be used as a
> - wakeup source for system suspend/resume.
> -
> -- brcm,int-fwd-mask: if present, a bit mask to configure the interrupts which
> - have a mux gate, typically UARTs. Setting these bits will make their
> - respective interrupt outputs bypass this 2nd level interrupt controller
> - completely; it is completely transparent for the interrupt controller
> - parent. This should have one 32-bit word per enable/status pair.
> -
> -Example:
> -
> -irq0_intc: interrupt-controller@f0406800 {
> - compatible = "brcm,bcm7120-l2-intc";
> - interrupt-parent = <&intc>;
> - #interrupt-cells = <1>;
> - reg = <0xf0406800 0x8>;
> - interrupt-controller;
> - interrupts = <0x0 0x42 0x0>, <0x0 0x40 0x0>;
> - brcm,int-map-mask = <0xeb8>, <0x140>;
> - brcm,int-fwd-mask = <0x7>;
> -};
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
> new file mode 100644
> index 000000000000..e0c6dce40d13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm7120-l2-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM7120-style Level 2 interrupt controller
> +
> +maintainers:
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +description: >
> + This interrupt controller hardware is a second level interrupt controller that
> + is hooked to a parent interrupt controller: e.g: ARM GIC for ARM-based
> + platforms. It can be found on BCM7xxx products starting with BCM7120.
> +
> + Such an interrupt controller has the following hardware design:
> +
> + - outputs multiple interrupts signals towards its interrupt controller parent
> +
> + - controls how some of the interrupts will be flowing, whether they will
> + directly output an interrupt signal towards the interrupt controller parent,
> + or if they will output an interrupt signal at this 2nd level interrupt
> + controller, in particular for UARTs
> +
> + - has one 32-bit enable word and one 32-bit status word
> +
> + - no atomic set/clear operations
> +
> + - not all bits within the interrupt controller actually map to an interrupt
> +
> + The typical hardware layout for this controller is represented below:
> +
> + 2nd level interrupt line Outputs for the parent controller (e.g: ARM GIC)
> +
> + 0 -----[ MUX ] ------------|==========> GIC interrupt 75
> + \-----------\
> + |
> + 1 -----[ MUX ] --------)---|==========> GIC interrupt 76
> + \------------|
> + |
> + 2 -----[ MUX ] --------)---|==========> GIC interrupt 77
> + \------------|
> + |
> + 3 ---------------------|
> + 4 ---------------------|
> + 5 ---------------------|
> + 7 ---------------------|---|===========> GIC interrupt 66
> + 9 ---------------------|
> + 10 --------------------|
> + 11 --------------------/
> +
> + 6 ------------------------\
> + |===========> GIC interrupt 64
> + 8 ------------------------/
> +
> + 12 ........................ X
> + 13 ........................ X (not connected)
space followed by tab.
> + ..
> + 31 ........................ X
> +
> +allOf:
> + - $ref: /schemas/interrupt-controller.yaml#
> +
> +properties:
> + compatible:
> + const: brcm,bcm7120-l2-intc
> +
> + reg:
> + description: >
> + Specifies the base physical address and size of the registers
That's every 'reg'. How many?
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 1
> +
> + interrupts: true
No, how many and what are they if more than 1.
> +
> + "brcm,int-map-mask":
No need for quotes.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description: >
> + 32-bits bit mask describing how many and which interrupts are wired to
> + this 2nd level interrupt controller, and how they match their respective
> + interrupt parents. Should match exactly the number of interrupts
> + specified in the 'interrupts' property.
> +
> + brcm,irq-can-wake:
> + type: boolean
> + description: >
> + If present, this means the L2 controller can be used as a wakeup source
> + for system suspend/resume.
> +
> + brcm,int-fwd-mask:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: >
> + if present, a bit mask to configure the interrupts which have a mux gate,
> + typically UARTs. Setting these bits will make their respective interrupt
> + outputs bypass this 2nd level interrupt controller completely; it is
> + completely transparent for the interrupt controller parent. This should
> + have one 32-bit word per enable/status pair.
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
> +
> +examples:
> + - |
> + irq0_intc: interrupt-controller@f0406800 {
> + compatible = "brcm,bcm7120-l2-intc";
> + interrupt-parent = <&intc>;
> + #interrupt-cells = <1>;
> + reg = <0xf0406800 0x8>;
> + interrupt-controller;
> + interrupts = <0x0 0x42 0x0>, <0x0 0x40 0x0>;
> + brcm,int-map-mask = <0xeb8>, <0x140>;
> + brcm,int-fwd-mask = <0x7>;
> + };
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 08/15] dt-bindings: interrupt-controller: Merge BCM3380 with BCM7120
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (6 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 07/15] dt-bindings: interrupt-controller: Convert BCM7120 L2 " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 09/15] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML Florian Fainelli
` (6 subsequent siblings)
14 siblings, 0 replies; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
The two bindings are very similar and should be covered by the same
document, do that so we can get rid of an additional binding file.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../brcm,bcm3380-l2-intc.txt | 39 -------------------
.../brcm,bcm7120-l2-intc.yaml | 30 +++++++++++++-
2 files changed, 28 insertions(+), 41 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm3380-l2-intc.txt
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm3380-l2-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm3380-l2-intc.txt
deleted file mode 100644
index 37aea40d5430..000000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm3380-l2-intc.txt
+++ /dev/null
@@ -1,39 +0,0 @@
-Broadcom BCM3380-style Level 1 / Level 2 interrupt controller
-
-This interrupt controller shows up in various forms on many BCM338x/BCM63xx
-chipsets. It has the following properties:
-
-- outputs a single interrupt signal to its interrupt controller parent
-
-- contains one or more enable/status word pairs, which often appear at
- different offsets in different blocks
-
-- no atomic set/clear operations
-
-Required properties:
-
-- compatible: should be "brcm,bcm3380-l2-intc"
-- reg: specifies one or more enable/status pairs, in the following format:
- <enable_reg 0x4 status_reg 0x4>...
-- interrupt-controller: identifies the node as an interrupt controller
-- #interrupt-cells: specifies the number of cells needed to encode an interrupt
- source, should be 1.
-- interrupts: specifies the interrupt line in the interrupt-parent controller
- node, valid values depend on the type of parent interrupt controller
-
-Optional properties:
-
-- brcm,irq-can-wake: if present, this means the L2 controller can be used as a
- wakeup source for system suspend/resume.
-
-Example:
-
-irq0_intc: interrupt-controller@10000020 {
- compatible = "brcm,bcm3380-l2-intc";
- reg = <0x10000024 0x4 0x1000002c 0x4>,
- <0x10000020 0x4 0x10000028 0x4>;
- interrupt-controller;
- #interrupt-cells = <1>;
- interrupt-parent = <&cpu_intc>;
- interrupts = <2>;
-};
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
index e0c6dce40d13..8be7fe29e6a9 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm7120-l2-intc.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Broadcom BCM7120-style Level 2 interrupt controller
+title: Broadcom BCM7120-style Level 2 and Broadcom BCM3380 Level 1 / Level 2
maintainers:
- Florian Fainelli <f.fainelli@gmail.com>
@@ -59,16 +59,31 @@ description: >
..
31 ........................ X
+ The BCM3380 Level 1 / Level 2 interrrupt controller shows up in various forms
+ on many BCM338x/BCM63xx chipsets. It has the following properties:
+
+ - outputs a single interrupt signal to its interrupt controller parent
+
+ - contains one or more enable/status word pairs, which often appear at
+ different offsets in different blocks
+
+ - no atomic set/clear operations
+
allOf:
- $ref: /schemas/interrupt-controller.yaml#
properties:
compatible:
- const: brcm,bcm7120-l2-intc
+ items:
+ - enum:
+ - brcm,bcm7120-l2-intc
+ - brcm,bcm3380-l2-intc
reg:
description: >
Specifies the base physical address and size of the registers
+ minItems: 1
+ maxItems: 4
interrupt-controller: true
@@ -121,3 +136,14 @@ examples:
brcm,int-map-mask = <0xeb8>, <0x140>;
brcm,int-fwd-mask = <0x7>;
};
+
+ - |
+ irq1_intc: interrupt-controller@10000020 {
+ compatible = "brcm,bcm3380-l2-intc";
+ reg = <0x10000024 0x4>, <0x1000002c 0x4>,
+ <0x10000020 0x4>, <0x10000028 0x4>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ interrupt-parent = <&cpu_intc>;
+ interrupts = <2>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH v3 09/15] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (7 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 08/15] dt-bindings: interrupt-controller: Merge BCM3380 with BCM7120 Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 18:14 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 10/15] dt-bindings: rng: Convert iProc RNG200 " Florian Fainelli
` (5 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB L2 generic Level 2 interrupt controller Device
Tree binding to YAML to help with validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../interrupt-controller/brcm,l2-intc.txt | 31 --------
.../interrupt-controller/brcm,l2-intc.yaml | 71 +++++++++++++++++++
2 files changed, 71 insertions(+), 31 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.yaml
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
deleted file mode 100644
index 021cf822395c..000000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
+++ /dev/null
@@ -1,31 +0,0 @@
-Broadcom Generic Level 2 Interrupt Controller
-
-Required properties:
-
-- compatible: should be one of:
- "brcm,hif-spi-l2-intc" or
- "brcm,upg-aux-aon-l2-intc" or
- "brcm,l2-intc" for latched interrupt controllers
- should be "brcm,bcm7271-l2-intc" for level interrupt controllers
-- reg: specifies the base physical address and size of the registers
-- interrupt-controller: identifies the node as an interrupt controller
-- #interrupt-cells: specifies the number of cells needed to encode an
- interrupt source. Should be 1.
-- interrupts: specifies the interrupt line in the interrupt-parent irq space
- to be used for cascading
-
-Optional properties:
-
-- brcm,irq-can-wake: If present, this means the L2 controller can be used as a
- wakeup source for system suspend/resume.
-
-Example:
-
-hif_intr2_intc: interrupt-controller@f0441000 {
- compatible = "brcm,l2-intc";
- reg = <0xf0441000 0x30>;
- interrupt-controller;
- #interrupt-cells = <1>;
- interrupt-parent = <&intc>;
- interrupts = <0x0 0x20 0x0>;
-};
diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.yaml
new file mode 100644
index 000000000000..c197c85084d1
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/brcm,l2-intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom Generic Level 2 Interrupt Controller
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+allOf:
+ - $ref: /schemas/interrupt-controller.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - brcm,hif-spi-l2-intc
+ - brcm,upg-aux-aon-l2-intc
+ - const: brcm,l2-intc
+ - items:
+ - enum:
+ - brcm,bcm2711-l2-intc
+ - const: brcm,l2-intc
+ - items:
+ - const: brcm,bcm7271-l2-intc
+ - items:
+ - const: brcm,l2-intc
+
+ reg:
+ maxItems: 1
+ description: >
+ Specifies the base physical address and size of the registers
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 1
+
+ interrupts: true
+
+ interrupt-names:
+ maxItems: 1
+
+ brcm,irq-can-wake:
+ type: boolean
+ description: >
+ If present, this means the L2 controller can be used as a wakeup source
+ for system suspend/resume.
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupt-controller
+ - "#interrupt-cells"
+ - interrupts
+
+examples:
+ - |
+ hif_intr2_intc: interrupt-controller@f0441000 {
+ compatible = "brcm,l2-intc";
+ reg = <0xf0441000 0x30>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ interrupt-parent = <&intc>;
+ interrupts = <0x0 0x20 0x0>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 09/15] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML
2021-12-08 0:37 ` [PATCH v3 09/15] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML Florian Fainelli
@ 2021-12-14 18:14 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:14 UTC (permalink / raw)
To: Florian Fainelli
Cc: Thierry Reding, Ray Jui, Gregory Fong, Daniel Lezcano,
Uwe Kleine-König, Zhang Rui, Rob Herring, Al Cooper,
linux-usb, Damien Le Moal, Doug Berger, Lee Jones, linux-ide,
Greg Kroah-Hartman, linux-rtc, Bartosz Golaszewski, Herbert Xu,
linux-mmc, linux-arm-kernel, Marc Zyngier, Alexandre Belloni,
linux-crypto, Rafael J. Wysocki, Philipp Zabel,
bcm-kernel-feedback-list, linux-pwm, Markus Mayer,
Alessandro Zummo, Linus Walleij, Amit Kucheria, Scott Branden,
linux-pm, Ulf Hansson, linux-kernel, Thomas Gleixner, linux-gpio,
devicetree
On Tue, 07 Dec 2021 16:37:20 -0800, Florian Fainelli wrote:
> Convert the Broadcom STB L2 generic Level 2 interrupt controller Device
> Tree binding to YAML to help with validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../interrupt-controller/brcm,l2-intc.txt | 31 --------
> .../interrupt-controller/brcm,l2-intc.yaml | 71 +++++++++++++++++++
> 2 files changed, 71 insertions(+), 31 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 10/15] dt-bindings: rng: Convert iProc RNG200 to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (8 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 09/15] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 18:17 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 11/15] dt-bindings: thermal: Convert Broadcom TMON " Florian Fainelli
` (4 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom iProc RNG200 HWRNG Device Tree binding to YAML to
help with validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/rng/brcm,iproc-rng200.txt | 16 ----------
.../bindings/rng/brcm,iproc-rng200.yaml | 29 +++++++++++++++++++
2 files changed, 29 insertions(+), 16 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
create mode 100644 Documentation/devicetree/bindings/rng/brcm,iproc-rng200.yaml
diff --git a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
deleted file mode 100644
index 802523196ee5..000000000000
--- a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-HWRNG support for the iproc-rng200 driver
-
-Required properties:
-- compatible : Must be one of:
- "brcm,bcm2711-rng200"
- "brcm,bcm7211-rng200"
- "brcm,bcm7278-rng200"
- "brcm,iproc-rng200"
-- reg : base address and size of control register block
-
-Example:
-
-rng {
- compatible = "brcm,iproc-rng200";
- reg = <0x18032000 0x28>;
-};
diff --git a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.yaml b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.yaml
new file mode 100644
index 000000000000..53baaec966e0
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.yaml
@@ -0,0 +1,29 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/rng/brcm,iproc-rng200.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: HWRNG support for the iproc-rng200 driver
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+properties:
+ compatible:
+ enum:
+ - brcm,bcm2711-rng200
+ - brcm,bcm7211-rng200
+ - brcm,bcm7278-rng200
+ - brcm,iproc-rng200
+ reg:
+ description: base address and size of control register block
+
+additionalProperties: false
+
+examples:
+ - |
+ rng@18032000 {
+ compatible = "brcm,iproc-rng200";
+ reg = <0x18032000 0x28>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 10/15] dt-bindings: rng: Convert iProc RNG200 to YAML
2021-12-08 0:37 ` [PATCH v3 10/15] dt-bindings: rng: Convert iProc RNG200 " Florian Fainelli
@ 2021-12-14 18:17 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:17 UTC (permalink / raw)
To: Florian Fainelli
Cc: Thierry Reding, linux-rtc, linux-pm, Ray Jui, devicetree,
linux-usb, Scott Branden, Ulf Hansson, linux-crypto, linux-pwm,
Herbert Xu, Marc Zyngier, Rob Herring, Linus Walleij,
Alexandre Belloni, Gregory Fong, Al Cooper, Thomas Gleixner,
Bartosz Golaszewski, Greg Kroah-Hartman, Daniel Lezcano,
bcm-kernel-feedback-list, linux-arm-kernel, Rafael J. Wysocki,
linux-gpio, Amit Kucheria, Alessandro Zummo, Damien Le Moal,
linux-mmc, Lee Jones, Uwe Kleine-König, Zhang Rui,
linux-ide, linux-kernel, Markus Mayer, Doug Berger,
Philipp Zabel
On Tue, 07 Dec 2021 16:37:21 -0800, Florian Fainelli wrote:
> Convert the Broadcom iProc RNG200 HWRNG Device Tree binding to YAML to
> help with validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/rng/brcm,iproc-rng200.txt | 16 ----------
> .../bindings/rng/brcm,iproc-rng200.yaml | 29 +++++++++++++++++++
> 2 files changed, 29 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
> create mode 100644 Documentation/devicetree/bindings/rng/brcm,iproc-rng200.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 11/15] dt-bindings: thermal: Convert Broadcom TMON to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (9 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 10/15] dt-bindings: rng: Convert iProc RNG200 " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 18:18 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 12/15] ARM: dts: NSP: Rename SATA unit name Florian Fainelli
` (3 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom AVS TMON Device Tree binding to YAML to help with
validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/thermal/brcm,avs-tmon.txt | 23 --------
.../bindings/thermal/brcm,avs-tmon.yaml | 57 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 58 insertions(+), 24 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
create mode 100644 Documentation/devicetree/bindings/thermal/brcm,avs-tmon.yaml
diff --git a/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt b/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
deleted file mode 100644
index 74a9ef09db8b..000000000000
--- a/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-* Broadcom STB thermal management
-
-Thermal management core, provided by the AVS TMON hardware block.
-
-Required properties:
-- compatible: must be one of:
- "brcm,avs-tmon-bcm7216"
- "brcm,avs-tmon-bcm7445"
- "brcm,avs-tmon"
-- reg: address range for the AVS TMON registers
-- interrupts: temperature monitor interrupt, for high/low threshold triggers,
- required except for "brcm,avs-tmon-bcm7216"
-- interrupt-names: should be "tmon"
-
-Example:
-
- thermal@f04d1500 {
- compatible = "brcm,avs-tmon-bcm7445", "brcm,avs-tmon";
- reg = <0xf04d1500 0x28>;
- interrupts = <0x6>;
- interrupt-names = "tmon";
- interrupt-parent = <&avs_host_l2_intc>;
- };
diff --git a/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.yaml b/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.yaml
new file mode 100644
index 000000000000..fb5c273b8bc2
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/brcm,avs-tmon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom STB thermal management
+
+description: Thermal management core, provided by the AVS TMON hardware block.
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+allOf:
+ - $ref: thermal-sensor.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - brcm,avs-tmon-bcm7216
+ - brcm,avs-tmon-bcm7445
+ - const: brcm,avs-tmon
+
+ reg:
+ maxItems: 1
+ description: >
+ Address range for the AVS TMON registers
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-names:
+ items:
+ - const: tmon
+
+ "#thermal-sensor-cells":
+ const: 0
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - "#thermal-sensor-cells"
+
+examples:
+ - |
+ thermal@f04d1500 {
+ compatible = "brcm,avs-tmon-bcm7445", "brcm,avs-tmon";
+ reg = <0xf04d1500 0x28>;
+ interrupts = <0x6>;
+ interrupt-names = "tmon";
+ interrupt-parent = <&avs_host_l2_intc>;
+ #thermal-sensor-cells = <0>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 9ac67c885159..2109b6fe8ea3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3936,7 +3936,7 @@ M: Markus Mayer <mmayer@broadcom.com>
M: bcm-kernel-feedback-list@broadcom.com
L: linux-pm@vger.kernel.org
S: Maintained
-F: Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
+F: Documentation/devicetree/bindings/thermal/brcm,avs-tmon.yaml
F: drivers/thermal/broadcom/brcmstb*
BROADCOM STB DPFE DRIVER
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 11/15] dt-bindings: thermal: Convert Broadcom TMON to YAML
2021-12-08 0:37 ` [PATCH v3 11/15] dt-bindings: thermal: Convert Broadcom TMON " Florian Fainelli
@ 2021-12-14 18:18 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:18 UTC (permalink / raw)
To: Florian Fainelli
Cc: Lee Jones, Doug Berger, linux-rtc, Alexandre Belloni, devicetree,
Zhang Rui, Damien Le Moal, linux-arm-kernel,
Uwe Kleine-König, Scott Branden, Thomas Gleixner,
Rob Herring, Herbert Xu, linux-gpio, linux-usb,
Rafael J. Wysocki, bcm-kernel-feedback-list, Thierry Reding,
Linus Walleij, linux-crypto, Amit Kucheria, Markus Mayer,
Alessandro Zummo, Ray Jui, Marc Zyngier, Greg Kroah-Hartman,
linux-mmc, Daniel Lezcano, linux-pm, Philipp Zabel, Gregory Fong,
linux-kernel, Al Cooper, linux-ide, Bartosz Golaszewski,
Ulf Hansson, linux-pwm
On Tue, 07 Dec 2021 16:37:22 -0800, Florian Fainelli wrote:
> Convert the Broadcom AVS TMON Device Tree binding to YAML to help with
> validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/thermal/brcm,avs-tmon.txt | 23 --------
> .../bindings/thermal/brcm,avs-tmon.yaml | 57 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 58 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
> create mode 100644 Documentation/devicetree/bindings/thermal/brcm,avs-tmon.yaml
>
Applied, thanks!
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 12/15] ARM: dts: NSP: Rename SATA unit name
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (10 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 11/15] dt-bindings: thermal: Convert Broadcom TMON " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-08 1:23 ` Damien Le Moal
2021-12-08 0:37 ` [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML Florian Fainelli
` (2 subsequent siblings)
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Rename the SATA controller unit name from ahci to sata in preparation
for adding the Broadcom SATA3 controller YAML binding which will bring
validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index 1c08daa18858..ded5a59e0679 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -534,7 +534,7 @@ sata_phy1: sata-phy@1 {
};
};
- sata: ahci@41000 {
+ sata: sata@41000 {
compatible = "brcm,bcm-nsp-ahci";
reg-names = "ahci", "top-ctrl";
reg = <0x41000 0x1000>, <0x40020 0x1c>;
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 12/15] ARM: dts: NSP: Rename SATA unit name
2021-12-08 0:37 ` [PATCH v3 12/15] ARM: dts: NSP: Rename SATA unit name Florian Fainelli
@ 2021-12-08 1:23 ` Damien Le Moal
0 siblings, 0 replies; 38+ messages in thread
From: Damien Le Moal @ 2021-12-08 1:23 UTC (permalink / raw)
To: Florian Fainelli, devicetree
Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On 2021/12/08 9:37, Florian Fainelli wrote:
> Rename the SATA controller unit name from ahci to sata in preparation
> for adding the Broadcom SATA3 controller YAML binding which will bring
> validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
> index 1c08daa18858..ded5a59e0679 100644
> --- a/arch/arm/boot/dts/bcm-nsp.dtsi
> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi
> @@ -534,7 +534,7 @@ sata_phy1: sata-phy@1 {
> };
> };
>
> - sata: ahci@41000 {
> + sata: sata@41000 {
> compatible = "brcm,bcm-nsp-ahci";
> reg-names = "ahci", "top-ctrl";
> reg = <0x41000 0x1000>, <0x40020 0x1c>;
>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (11 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 12/15] ARM: dts: NSP: Rename SATA unit name Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-08 13:44 ` Rob Herring
2021-12-14 19:10 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter " Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 15/15] dt-bindings: usb: Convert BDC " Florian Fainelli
14 siblings, 2 replies; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
to help with validation.
Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../bindings/ata/brcm,sata-brcm.txt | 45 ---------
.../bindings/ata/brcm,sata-brcm.yaml | 98 +++++++++++++++++++
2 files changed, 98 insertions(+), 45 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
deleted file mode 100644
index b9ae4ce4a0a0..000000000000
--- a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
+++ /dev/null
@@ -1,45 +0,0 @@
-* Broadcom SATA3 AHCI Controller
-
-SATA nodes are defined to describe on-chip Serial ATA controllers.
-Each SATA controller should have its own node.
-
-Required properties:
-- compatible : should be one or more of
- "brcm,bcm7216-ahci"
- "brcm,bcm7425-ahci"
- "brcm,bcm7445-ahci"
- "brcm,bcm-nsp-ahci"
- "brcm,sata3-ahci"
- "brcm,bcm63138-ahci"
-- reg : register mappings for AHCI and SATA_TOP_CTRL
-- reg-names : "ahci" and "top-ctrl"
-- interrupts : interrupt mapping for SATA IRQ
-
-Optional properties:
-
-- reset: for "brcm,bcm7216-ahci" must be a valid reset phandle
- pointing to the RESCAL reset controller provider node.
-- reset-names: for "brcm,bcm7216-ahci", must be "rescal".
-
-Also see ahci-platform.txt.
-
-Example:
-
- sata@f045a000 {
- compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci";
- reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>;
- reg-names = "ahci", "top-ctrl";
- interrupts = <0 30 0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- sata0: sata-port@0 {
- reg = <0>;
- phys = <&sata_phy 0>;
- };
-
- sata1: sata-port@1 {
- reg = <1>;
- phys = <&sata_phy 1>;
- };
- };
diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
new file mode 100644
index 000000000000..3e24f45c65af
--- /dev/null
+++ b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
@@ -0,0 +1,98 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ata/brcm,sata-brcm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom SATA3 AHCI Controller
+
+description:
+ SATA nodes are defined to describe on-chip Serial ATA controllers.
+ Each SATA controller should have its own node.
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+allOf:
+ - $ref: sata-common.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - brcm,bcm7216-ahci
+ - const: brcm,sata3-ahci
+ - items:
+ - enum:
+ - brcm,bcm7445-ahci
+ - const: brcm,sata3-ahci
+ - items:
+ - enum:
+ - brcm,bcm7425-ahci
+ - const: brcm,sata3-ahci
+ - items:
+ - const: brcm,bcm-nsp-ahci
+ - items:
+ - enum:
+ - brcm,bcm63138-ahci
+ - const: brcm,sata3-ahci
+
+ reg:
+ minItems: 2
+ maxItems: 2
+
+ reg-names:
+ items:
+ - const: ahci
+ - const: top-ctrl
+
+ interrupts: true
+
+ dma-coherent: true
+
+if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - brcm,bcm7216-ahci
+ - brcm,bcm63138-ahci
+then:
+ properties:
+ resets:
+ maxItems: 1
+ reset-names:
+ enum:
+ - rescal
+ - ahci
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - "#address-cells"
+ - "#size-cells"
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ sata@f045a000 {
+ compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci";
+ reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>;
+ reg-names = "ahci", "top-ctrl";
+ interrupts = <0 30 0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sata0: sata-port@0 {
+ reg = <0>;
+ phys = <&sata_phy 0>;
+ };
+
+ sata1: sata-port@1 {
+ reg = <1>;
+ phys = <&sata_phy 1>;
+ };
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML
2021-12-08 0:37 ` [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML Florian Fainelli
@ 2021-12-08 13:44 ` Rob Herring
2021-12-08 17:33 ` Florian Fainelli
2021-12-14 19:10 ` Rob Herring
1 sibling, 1 reply; 38+ messages in thread
From: Rob Herring @ 2021-12-08 13:44 UTC (permalink / raw)
To: Florian Fainelli
Cc: Alessandro Zummo, linux-pwm, linux-mmc, Markus Mayer,
Ulf Hansson, Ray Jui, Amit Kucheria, bcm-kernel-feedback-list,
Greg Kroah-Hartman, linux-pm, Doug Berger, Uwe Kleine-König,
Rob Herring, Lee Jones, Bartosz Golaszewski, linux-usb,
Damien Le Moal, Linus Walleij, linux-ide, Thomas Gleixner,
Scott Branden, Thierry Reding, Al Cooper, Daniel Lezcano,
linux-gpio, linux-arm-kernel, Alexandre Belloni,
Rafael J. Wysocki, Gregory Fong, linux-rtc, Herbert Xu,
Marc Zyngier, linux-kernel, linux-crypto, Zhang Rui,
Philipp Zabel, devicetree
On Tue, 07 Dec 2021 16:37:24 -0800, Florian Fainelli wrote:
> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
> to help with validation.
>
> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/ata/brcm,sata-brcm.txt | 45 ---------
> .../bindings/ata/brcm,sata-brcm.yaml | 98 +++++++++++++++++++
> 2 files changed, 98 insertions(+), 45 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1565011
ahci@41000: $nodename:0: 'ahci@41000' does not match '^sata(@.*)?$'
arch/arm/boot/dts/bcm958522er.dt.yaml
arch/arm/boot/dts/bcm958525er.dt.yaml
arch/arm/boot/dts/bcm958525xmc.dt.yaml
arch/arm/boot/dts/bcm958622hr.dt.yaml
arch/arm/boot/dts/bcm958623hr.dt.yaml
arch/arm/boot/dts/bcm958625hr.dt.yaml
arch/arm/boot/dts/bcm958625k.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml
arch/arm/boot/dts/bcm988312hr.dt.yaml
ahci@41000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'sata-port@0', 'sata-port@1' were unexpected)
arch/arm/boot/dts/bcm958522er.dt.yaml
arch/arm/boot/dts/bcm958525er.dt.yaml
arch/arm/boot/dts/bcm958525xmc.dt.yaml
arch/arm/boot/dts/bcm958622hr.dt.yaml
arch/arm/boot/dts/bcm958623hr.dt.yaml
arch/arm/boot/dts/bcm958625hr.dt.yaml
arch/arm/boot/dts/bcm958625k.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml
arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml
arch/arm/boot/dts/bcm988312hr.dt.yaml
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML
2021-12-08 13:44 ` Rob Herring
@ 2021-12-08 17:33 ` Florian Fainelli
2021-12-14 18:28 ` Rob Herring
0 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 17:33 UTC (permalink / raw)
To: Rob Herring, Florian Fainelli
Cc: Alessandro Zummo, linux-pwm, linux-mmc, Markus Mayer,
Ulf Hansson, Ray Jui, Amit Kucheria, bcm-kernel-feedback-list,
Greg Kroah-Hartman, linux-pm, Doug Berger, Uwe Kleine-König,
Rob Herring, Lee Jones, Bartosz Golaszewski, linux-usb,
Damien Le Moal, Linus Walleij, linux-ide, Thomas Gleixner,
Scott Branden, Thierry Reding, Al Cooper, Daniel Lezcano,
linux-gpio, linux-arm-kernel, Alexandre Belloni,
Rafael J. Wysocki, Gregory Fong, linux-rtc, Herbert Xu,
Marc Zyngier, linux-kernel, linux-crypto, Zhang Rui,
Philipp Zabel, devicetree
On 12/8/21 5:44 AM, Rob Herring wrote:
> On Tue, 07 Dec 2021 16:37:24 -0800, Florian Fainelli wrote:
>> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
>> to help with validation.
>>
>> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> .../bindings/ata/brcm,sata-brcm.txt | 45 ---------
>> .../bindings/ata/brcm,sata-brcm.yaml | 98 +++++++++++++++++++
>> 2 files changed, 98 insertions(+), 45 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
>> create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1565011
Likewise, those indicate that the preceding patch which renames the sata
controller unit name has not been applied.
--
Florian
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML
2021-12-08 17:33 ` Florian Fainelli
@ 2021-12-14 18:28 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 18:28 UTC (permalink / raw)
To: Florian Fainelli
Cc: Alessandro Zummo, linux-pwm, linux-mmc, Markus Mayer,
Ulf Hansson, Ray Jui, Amit Kucheria, bcm-kernel-feedback-list,
Greg Kroah-Hartman, linux-pm, Doug Berger, Uwe Kleine-König,
Lee Jones, Bartosz Golaszewski, linux-usb, Damien Le Moal,
Linus Walleij, linux-ide, Thomas Gleixner, Scott Branden,
Thierry Reding, Al Cooper, Daniel Lezcano, linux-gpio,
linux-arm-kernel, Alexandre Belloni, Rafael J. Wysocki,
Gregory Fong, linux-rtc, Herbert Xu, Marc Zyngier, linux-kernel,
linux-crypto, Zhang Rui, Philipp Zabel, devicetree
On Wed, Dec 08, 2021 at 09:33:38AM -0800, Florian Fainelli wrote:
> On 12/8/21 5:44 AM, Rob Herring wrote:
> > On Tue, 07 Dec 2021 16:37:24 -0800, Florian Fainelli wrote:
> >> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
> >> to help with validation.
> >>
> >> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> .../bindings/ata/brcm,sata-brcm.txt | 45 ---------
> >> .../bindings/ata/brcm,sata-brcm.yaml | 98 +++++++++++++++++++
> >> 2 files changed, 98 insertions(+), 45 deletions(-)
> >> delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> >> create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> >>
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1565011
>
> Likewise, those indicate that the preceding patch which renames the sata
> controller unit name has not been applied.
I looked at that, but it was the unevaluated properties I was worried
about. However, the example has the same thing, but no errors. I think
running with DT_SCHEMA_FILES means sata-common.yaml is not included.
I'll have to look into that.
Rob
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML
2021-12-08 0:37 ` [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML Florian Fainelli
2021-12-08 13:44 ` Rob Herring
@ 2021-12-14 19:10 ` Rob Herring
1 sibling, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 19:10 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Damien Le Moal, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Tue, Dec 07, 2021 at 04:37:24PM -0800, Florian Fainelli wrote:
> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
> to help with validation.
>
> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/ata/brcm,sata-brcm.txt | 45 ---------
> .../bindings/ata/brcm,sata-brcm.yaml | 98 +++++++++++++++++++
> 2 files changed, 98 insertions(+), 45 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
>
> diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> deleted file mode 100644
> index b9ae4ce4a0a0..000000000000
> --- a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -* Broadcom SATA3 AHCI Controller
> -
> -SATA nodes are defined to describe on-chip Serial ATA controllers.
> -Each SATA controller should have its own node.
> -
> -Required properties:
> -- compatible : should be one or more of
> - "brcm,bcm7216-ahci"
> - "brcm,bcm7425-ahci"
> - "brcm,bcm7445-ahci"
> - "brcm,bcm-nsp-ahci"
> - "brcm,sata3-ahci"
> - "brcm,bcm63138-ahci"
> -- reg : register mappings for AHCI and SATA_TOP_CTRL
> -- reg-names : "ahci" and "top-ctrl"
> -- interrupts : interrupt mapping for SATA IRQ
> -
> -Optional properties:
> -
> -- reset: for "brcm,bcm7216-ahci" must be a valid reset phandle
> - pointing to the RESCAL reset controller provider node.
> -- reset-names: for "brcm,bcm7216-ahci", must be "rescal".
> -
> -Also see ahci-platform.txt.
> -
> -Example:
> -
> - sata@f045a000 {
> - compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci";
> - reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>;
> - reg-names = "ahci", "top-ctrl";
> - interrupts = <0 30 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - sata0: sata-port@0 {
> - reg = <0>;
> - phys = <&sata_phy 0>;
> - };
> -
> - sata1: sata-port@1 {
> - reg = <1>;
> - phys = <&sata_phy 1>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> new file mode 100644
> index 000000000000..3e24f45c65af
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/brcm,sata-brcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom SATA3 AHCI Controller
> +
> +description:
> + SATA nodes are defined to describe on-chip Serial ATA controllers.
> + Each SATA controller should have its own node.
> +
> +maintainers:
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +allOf:
> + - $ref: sata-common.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm7216-ahci
> + - const: brcm,sata3-ahci
> + - items:
> + - enum:
> + - brcm,bcm7445-ahci
> + - const: brcm,sata3-ahci
> + - items:
> + - enum:
> + - brcm,bcm7425-ahci
> + - const: brcm,sata3-ahci
> + - items:
> + - const: brcm,bcm-nsp-ahci
> + - items:
> + - enum:
> + - brcm,bcm63138-ahci
> + - const: brcm,sata3-ahci
Is there some reason this is not grouped into 2 oneOf entries? If not, I
can fixup.
> +
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: ahci
> + - const: top-ctrl
> +
> + interrupts: true
maxItems: 1 ?
> +
> + dma-coherent: true
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - brcm,bcm7216-ahci
> + - brcm,bcm63138-ahci
> +then:
> + properties:
> + resets:
> + maxItems: 1
> + reset-names:
> + enum:
> + - rescal
> + - ahci
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#address-cells"
> + - "#size-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + sata@f045a000 {
> + compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci";
> + reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>;
> + reg-names = "ahci", "top-ctrl";
> + interrupts = <0 30 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sata0: sata-port@0 {
> + reg = <0>;
> + phys = <&sata_phy 0>;
> + };
> +
> + sata1: sata-port@1 {
> + reg = <1>;
> + phys = <&sata_phy 1>;
> + };
> + };
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (12 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 19:14 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 15/15] dt-bindings: usb: Convert BDC " Florian Fainelli
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom STB GISB bus arbiter to YAML to help with
validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../devicetree/bindings/bus/brcm,gisb-arb.txt | 34 ----------
.../bindings/bus/brcm,gisb-arb.yaml | 66 +++++++++++++++++++
2 files changed, 66 insertions(+), 34 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
create mode 100644 Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
deleted file mode 100644
index 10f6d0a8159d..000000000000
--- a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-Broadcom GISB bus Arbiter controller
-
-Required properties:
-
-- compatible:
- "brcm,bcm7278-gisb-arb" for V7 28nm chips
- "brcm,gisb-arb" or "brcm,bcm7445-gisb-arb" for other 28nm chips
- "brcm,bcm7435-gisb-arb" for newer 40nm chips
- "brcm,bcm7400-gisb-arb" for older 40nm chips and all 65nm chips
- "brcm,bcm7038-gisb-arb" for 130nm chips
-- reg: specifies the base physical address and size of the registers
-- interrupts: specifies the two interrupts (timeout and TEA) to be used from
- the parent interrupt controller. A third optional interrupt may be specified
- for breakpoints.
-
-Optional properties:
-
-- brcm,gisb-arb-master-mask: 32-bits wide bitmask used to specify which GISB
- masters are valid at the system level
-- brcm,gisb-arb-master-names: string list of the litteral name of the GISB
- masters. Should match the number of bits set in brcm,gisb-master-mask and
- the order in which they appear
-
-Example:
-
-gisb-arb@f0400000 {
- compatible = "brcm,gisb-arb";
- reg = <0xf0400000 0x800>;
- interrupts = <0>, <2>;
- interrupt-parent = <&sun_l2_intc>;
-
- brcm,gisb-arb-master-mask = <0x7>;
- brcm,gisb-arb-master-names = "bsp_0", "scpu_0", "cpu_0";
-};
diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
new file mode 100644
index 000000000000..483b019275cd
--- /dev/null
+++ b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/brcm,gisb-arb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom GISB bus Arbiter controller
+
+maintainers:
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - brcm,bcm7445-gisb-arb
+ - const: brcm,gisb-arb
+ - items:
+ - const: brcm,bcm7278-gisb-arb
+ - items:
+ - const: brcm,bcm7435-gisb-arb
+ - items:
+ - const: brcm,bcm7400-gisb-arb
+ - items:
+ - const: brcm,bcm7038-gisb-arb
+ - items:
+ - const: brcm,gisb-arb
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ minItems: 2
+ maxItems: 3
+
+ brcm,gisb-arb-master-mask:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: >
+ 32-bits wide bitmask used to specify which GISB masters are valid at the
+ system level
+
+ brcm,gisb-arb-master-names:
+ $ref: /schemas/types.yaml#/definitions/string-array
+ description: >
+ String list of the litteral name of the GISB masters. Should match the
+ number of bits set in brcm,gisb-master-mask and the order in which they
+ appear
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ gisb-arb@f0400000 {
+ compatible = "brcm,gisb-arb";
+ reg = <0xf0400000 0x800>;
+ interrupts = <0>, <2>;
+ interrupt-parent = <&sun_l2_intc>;
+ brcm,gisb-arb-master-mask = <0x7>;
+ brcm,gisb-arb-master-names = "bsp_0", "scpu_0", "cpu_0";
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter to YAML
2021-12-08 0:37 ` [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter " Florian Fainelli
@ 2021-12-14 19:14 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 19:14 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Damien Le Moal, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Tue, Dec 07, 2021 at 04:37:25PM -0800, Florian Fainelli wrote:
> Convert the Broadcom STB GISB bus arbiter to YAML to help with
> validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../devicetree/bindings/bus/brcm,gisb-arb.txt | 34 ----------
> .../bindings/bus/brcm,gisb-arb.yaml | 66 +++++++++++++++++++
> 2 files changed, 66 insertions(+), 34 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
> create mode 100644 Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
>
> diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
> deleted file mode 100644
> index 10f6d0a8159d..000000000000
> --- a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Broadcom GISB bus Arbiter controller
> -
> -Required properties:
> -
> -- compatible:
> - "brcm,bcm7278-gisb-arb" for V7 28nm chips
> - "brcm,gisb-arb" or "brcm,bcm7445-gisb-arb" for other 28nm chips
> - "brcm,bcm7435-gisb-arb" for newer 40nm chips
> - "brcm,bcm7400-gisb-arb" for older 40nm chips and all 65nm chips
> - "brcm,bcm7038-gisb-arb" for 130nm chips
> -- reg: specifies the base physical address and size of the registers
> -- interrupts: specifies the two interrupts (timeout and TEA) to be used from
> - the parent interrupt controller. A third optional interrupt may be specified
> - for breakpoints.
> -
> -Optional properties:
> -
> -- brcm,gisb-arb-master-mask: 32-bits wide bitmask used to specify which GISB
> - masters are valid at the system level
> -- brcm,gisb-arb-master-names: string list of the litteral name of the GISB
> - masters. Should match the number of bits set in brcm,gisb-master-mask and
> - the order in which they appear
> -
> -Example:
> -
> -gisb-arb@f0400000 {
> - compatible = "brcm,gisb-arb";
> - reg = <0xf0400000 0x800>;
> - interrupts = <0>, <2>;
> - interrupt-parent = <&sun_l2_intc>;
> -
> - brcm,gisb-arb-master-mask = <0x7>;
> - brcm,gisb-arb-master-names = "bsp_0", "scpu_0", "cpu_0";
> -};
> diff --git a/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
> new file mode 100644
> index 000000000000..483b019275cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/brcm,gisb-arb.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bus/brcm,gisb-arb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom GISB bus Arbiter controller
> +
> +maintainers:
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm7445-gisb-arb
> + - const: brcm,gisb-arb
> + - items:
> + - const: brcm,bcm7278-gisb-arb
> + - items:
> + - const: brcm,bcm7435-gisb-arb
> + - items:
> + - const: brcm,bcm7400-gisb-arb
> + - items:
> + - const: brcm,bcm7038-gisb-arb
> + - items:
> + - const: brcm,gisb-arb
All these can be 1 enum.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 2
> + maxItems: 3
We lost what is each interrupt. Do something like this:
minItems: 2
items:
- description: ...
- description: ...
- description: ...
> +
> + brcm,gisb-arb-master-mask:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: >
> + 32-bits wide bitmask used to specify which GISB masters are valid at the
> + system level
> +
> + brcm,gisb-arb-master-names:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description: >
> + String list of the litteral name of the GISB masters. Should match the
> + number of bits set in brcm,gisb-master-mask and the order in which they
LSB to MSB or ???
> + appear
period ^
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gisb-arb@f0400000 {
> + compatible = "brcm,gisb-arb";
> + reg = <0xf0400000 0x800>;
> + interrupts = <0>, <2>;
> + interrupt-parent = <&sun_l2_intc>;
> + brcm,gisb-arb-master-mask = <0x7>;
> + brcm,gisb-arb-master-names = "bsp_0", "scpu_0", "cpu_0";
> + };
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH v3 15/15] dt-bindings: usb: Convert BDC to YAML
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
` (13 preceding siblings ...)
2021-12-08 0:37 ` [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter " Florian Fainelli
@ 2021-12-08 0:37 ` Florian Fainelli
2021-12-14 19:16 ` Rob Herring
14 siblings, 1 reply; 38+ messages in thread
From: Florian Fainelli @ 2021-12-08 0:37 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Damien Le Moal, Rob Herring, Linus Walleij,
Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
Convert the Broadcom BDC device controller Device Tree binding to YAML
to help with validation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
.../devicetree/bindings/usb/brcm,bdc.txt | 29 ------------
.../devicetree/bindings/usb/brcm,bdc.yaml | 46 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 47 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/usb/brcm,bdc.txt
create mode 100644 Documentation/devicetree/bindings/usb/brcm,bdc.yaml
diff --git a/Documentation/devicetree/bindings/usb/brcm,bdc.txt b/Documentation/devicetree/bindings/usb/brcm,bdc.txt
deleted file mode 100644
index c9f52b97cef1..000000000000
--- a/Documentation/devicetree/bindings/usb/brcm,bdc.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-Broadcom USB Device Controller (BDC)
-====================================
-
-Required properties:
-
-- compatible: must be one of:
- "brcm,bdc-udc-v2"
- "brcm,bdc"
-- reg: the base register address and length
-- interrupts: the interrupt line for this controller
-
-Optional properties:
-
-On Broadcom STB platforms, these properties are required:
-
-- phys: phandle to one or two USB PHY blocks
- NOTE: Some SoC's have a single phy and some have
- USB 2.0 and USB 3.0 phys
-- clocks: phandle to the functional clock of this block
-
-Example:
-
- bdc@f0b02000 {
- compatible = "brcm,bdc-udc-v2";
- reg = <0xf0b02000 0xfc4>;
- interrupts = <0x0 0x60 0x0>;
- phys = <&usbphy_0 0x0>;
- clocks = <&sw_usbd>;
- };
diff --git a/Documentation/devicetree/bindings/usb/brcm,bdc.yaml b/Documentation/devicetree/bindings/usb/brcm,bdc.yaml
new file mode 100644
index 000000000000..48831b62ab31
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/brcm,bdc.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/brcm,bdc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom USB Device Controller (BDC)
+
+maintainers:
+ - Al Cooper <alcooperx@gmail.com>
+ - Florian Fainelli <f.fainelli@gmail.com>
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - brcm,bdc-udc-v2
+ - brcm,bdc
+
+ reg:
+ maxItems: 1
+
+ interrupts: true
+
+ phys:
+ $ref: "/schemas/types.yaml#/definitions/phandle-array"
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ bdc@f0b02000 {
+ compatible = "brcm,bdc-udc-v2";
+ reg = <0xf0b02000 0xfc4>;
+ interrupts = <0x0 0x60 0x0>;
+ phys = <&usbphy_0 0x0>;
+ clocks = <&sw_usbd>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 2109b6fe8ea3..b18c7fa42a4f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3679,7 +3679,7 @@ M: Al Cooper <alcooperx@gmail.com>
L: linux-usb@vger.kernel.org
L: bcm-kernel-feedback-list@broadcom.com
S: Maintained
-F: Documentation/devicetree/bindings/usb/brcm,bdc.txt
+F: Documentation/devicetree/bindings/usb/brcm,bdc.yaml
F: drivers/usb/gadget/udc/bdc/
BROADCOM BMIPS CPUFREQ DRIVER
--
2.25.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH v3 15/15] dt-bindings: usb: Convert BDC to YAML
2021-12-08 0:37 ` [PATCH v3 15/15] dt-bindings: usb: Convert BDC " Florian Fainelli
@ 2021-12-14 19:16 ` Rob Herring
0 siblings, 0 replies; 38+ messages in thread
From: Rob Herring @ 2021-12-14 19:16 UTC (permalink / raw)
To: Florian Fainelli
Cc: devicetree, Damien Le Moal, Linus Walleij, Bartosz Golaszewski,
maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, Gregory Fong,
Thomas Gleixner, Marc Zyngier, Ulf Hansson, Thierry Reding,
Uwe Kleine-König, Lee Jones, Philipp Zabel, Herbert Xu,
Ray Jui, Scott Branden, Alessandro Zummo, Alexandre Belloni,
Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Markus Mayer, Greg Kroah-Hartman, Al Cooper, Doug Berger,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list, open list:GPIO SUBSYSTEM,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:PWM SUBSYSTEM,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:THERMAL,
open list:USB SUBSYSTEM
On Tue, Dec 07, 2021 at 04:37:26PM -0800, Florian Fainelli wrote:
> Convert the Broadcom BDC device controller Device Tree binding to YAML
> to help with validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../devicetree/bindings/usb/brcm,bdc.txt | 29 ------------
> .../devicetree/bindings/usb/brcm,bdc.yaml | 46 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 47 insertions(+), 30 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/usb/brcm,bdc.txt
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,bdc.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/brcm,bdc.txt b/Documentation/devicetree/bindings/usb/brcm,bdc.txt
> deleted file mode 100644
> index c9f52b97cef1..000000000000
> --- a/Documentation/devicetree/bindings/usb/brcm,bdc.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -Broadcom USB Device Controller (BDC)
> -====================================
> -
> -Required properties:
> -
> -- compatible: must be one of:
> - "brcm,bdc-udc-v2"
> - "brcm,bdc"
> -- reg: the base register address and length
> -- interrupts: the interrupt line for this controller
> -
> -Optional properties:
> -
> -On Broadcom STB platforms, these properties are required:
> -
> -- phys: phandle to one or two USB PHY blocks
> - NOTE: Some SoC's have a single phy and some have
> - USB 2.0 and USB 3.0 phys
> -- clocks: phandle to the functional clock of this block
> -
> -Example:
> -
> - bdc@f0b02000 {
> - compatible = "brcm,bdc-udc-v2";
> - reg = <0xf0b02000 0xfc4>;
> - interrupts = <0x0 0x60 0x0>;
> - phys = <&usbphy_0 0x0>;
> - clocks = <&sw_usbd>;
> - };
> diff --git a/Documentation/devicetree/bindings/usb/brcm,bdc.yaml b/Documentation/devicetree/bindings/usb/brcm,bdc.yaml
> new file mode 100644
> index 000000000000..48831b62ab31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/brcm,bdc.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/brcm,bdc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom USB Device Controller (BDC)
> +
> +maintainers:
> + - Al Cooper <alcooperx@gmail.com>
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - brcm,bdc-udc-v2
> + - brcm,bdc
> +
> + reg:
> + maxItems: 1
> +
> + interrupts: true
> +
> + phys:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
Already has a type. And we've lost how many and what each one is.
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + bdc@f0b02000 {
usb@...
> + compatible = "brcm,bdc-udc-v2";
> + reg = <0xf0b02000 0xfc4>;
> + interrupts = <0x0 0x60 0x0>;
> + phys = <&usbphy_0 0x0>;
> + clocks = <&sw_usbd>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2109b6fe8ea3..b18c7fa42a4f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3679,7 +3679,7 @@ M: Al Cooper <alcooperx@gmail.com>
> L: linux-usb@vger.kernel.org
> L: bcm-kernel-feedback-list@broadcom.com
> S: Maintained
> -F: Documentation/devicetree/bindings/usb/brcm,bdc.txt
> +F: Documentation/devicetree/bindings/usb/brcm,bdc.yaml
> F: drivers/usb/gadget/udc/bdc/
>
> BROADCOM BMIPS CPUFREQ DRIVER
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 38+ messages in thread