* [PATCH v2] net: ena: Do not waste napi skb cache
@ 2022-01-29 8:53 Hyeonggon Yoo
2022-02-01 5:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 6+ messages in thread
From: Hyeonggon Yoo @ 2022-01-29 8:53 UTC (permalink / raw)
To: netdev
Cc: jwiedmann.dev, Shay Agroskin, Arthur Kiyanovski, David Arinzon,
Noam Dagan, Saeed Bishara, David S . Miller, Daniel Borkmann,
Sameeh Jubran, Wei Yongjun, Lorenzo Bianconi, linux-kernel,
Jakub Kicinski, Hyeonggon Yoo
By profiling, discovered that ena device driver allocates skb by
build_skb() and frees by napi_skb_cache_put(). Because the driver
does not use napi skb cache in allocation path, napi skb cache is
periodically filled and flushed. This is waste of napi skb cache.
As ena_alloc_skb() is called only in napi, Use napi_build_skb()
and napi_alloc_skb() when allocating skb.
This patch was tested on aws a1.metal instance.
[ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
netdev_alloc_skb_ip_align() to keep things consistent. ]
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Acked-by: Shay Agroskin <shayagr@amazon.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 53080fd143dc..07444aead3fd 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1400,10 +1400,9 @@ static struct sk_buff *ena_alloc_skb(struct ena_ring *rx_ring, void *first_frag)
struct sk_buff *skb;
if (!first_frag)
- skb = netdev_alloc_skb_ip_align(rx_ring->netdev,
- rx_ring->rx_copybreak);
+ skb = napi_alloc_skb(rx_ring->napi, rx_ring->rx_copybreak);
else
- skb = build_skb(first_frag, ENA_PAGE_SIZE);
+ skb = napi_build_skb(first_frag, ENA_PAGE_SIZE);
if (unlikely(!skb)) {
ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail, 1,
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] net: ena: Do not waste napi skb cache
2022-01-29 8:53 [PATCH v2] net: ena: Do not waste napi skb cache Hyeonggon Yoo
@ 2022-02-01 5:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-01 5:50 UTC (permalink / raw)
To: Hyeonggon Yoo
Cc: netdev, jwiedmann.dev, shayagr, akiyano, darinzon, ndagan,
saeedb, davem, daniel, sameehj, weiyongjun1, lorenzo,
linux-kernel, kuba
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 29 Jan 2022 08:53:36 +0000 you wrote:
> By profiling, discovered that ena device driver allocates skb by
> build_skb() and frees by napi_skb_cache_put(). Because the driver
> does not use napi skb cache in allocation path, napi skb cache is
> periodically filled and flushed. This is waste of napi skb cache.
>
> As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> and napi_alloc_skb() when allocating skb.
>
> [...]
Here is the summary with links:
- [v2] net: ena: Do not waste napi skb cache
https://git.kernel.org/netdev/net-next/c/7354a426e063
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] net: ena: Do not waste napi skb cache
@ 2022-01-23 11:56 Hyeonggon Yoo
2022-01-26 13:16 ` [PATCH v2] " Hyeonggon Yoo
0 siblings, 1 reply; 6+ messages in thread
From: Hyeonggon Yoo @ 2022-01-23 11:56 UTC (permalink / raw)
To: netdev
Cc: Shay Agroskin, Arthur Kiyanovski, David Arinzon, Noam Dagan,
Saeed Bishara, David S . Miller, Jakub Kicinski, Daniel Borkmann,
Sameeh Jubran, Wei Yongjun, Lorenzo Bianconi, linux-kernel,
Hyeonggon Yoo
By profiling, discovered that ena device driver allocates skb by
build_skb() and frees by napi_skb_cache_put(). Because the driver
does not use napi skb cache in allocation path, napi skb cache is
periodically filled and flushed. This is waste of napi skb cache.
As ena_alloc_skb() is called only in napi, Use napi_build_skb()
instead of build_skb() to when allocating skb.
This patch was tested on aws a1.metal instance.
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index c72f0c7ff4aa..2c67fb1703c5 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1407,7 +1407,7 @@ static struct sk_buff *ena_alloc_skb(struct ena_ring *rx_ring, void *first_frag)
skb = netdev_alloc_skb_ip_align(rx_ring->netdev,
rx_ring->rx_copybreak);
else
- skb = build_skb(first_frag, ENA_PAGE_SIZE);
+ skb = napi_build_skb(first_frag, ENA_PAGE_SIZE);
if (unlikely(!skb)) {
ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail, 1,
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] net: ena: Do not waste napi skb cache
2022-01-23 11:56 [PATCH] " Hyeonggon Yoo
@ 2022-01-26 13:16 ` Hyeonggon Yoo
2022-01-26 15:16 ` Shay Agroskin
2022-01-26 15:52 ` Jakub Kicinski
0 siblings, 2 replies; 6+ messages in thread
From: Hyeonggon Yoo @ 2022-01-26 13:16 UTC (permalink / raw)
To: jwiedmann.dev
Cc: Shay Agroskin, Arthur Kiyanovski, David Arinzon, Noam Dagan,
Saeed Bishara, David S . Miller, Jakub Kicinski, Daniel Borkmann,
Sameeh Jubran, Wei Yongjun, Lorenzo Bianconi, linux-kernel
By profiling, discovered that ena device driver allocates skb by
build_skb() and frees by napi_skb_cache_put(). Because the driver
does not use napi skb cache in allocation path, napi skb cache is
periodically filled and flushed. This is waste of napi skb cache.
As ena_alloc_skb() is called only in napi, Use napi_build_skb()
and napi_alloc_skb() when allocating skb.
This patch was tested on aws a1.metal instance.
[ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
netdev_alloc_skb_ip_align() to keep things consistent. ]
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 53080fd143dc..07444aead3fd 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1400,10 +1400,9 @@ static struct sk_buff *ena_alloc_skb(struct ena_ring *rx_ring, void *first_frag)
struct sk_buff *skb;
if (!first_frag)
- skb = netdev_alloc_skb_ip_align(rx_ring->netdev,
- rx_ring->rx_copybreak);
+ skb = napi_alloc_skb(rx_ring->napi, rx_ring->rx_copybreak);
else
- skb = build_skb(first_frag, ENA_PAGE_SIZE);
+ skb = napi_build_skb(first_frag, ENA_PAGE_SIZE);
if (unlikely(!skb)) {
ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail, 1,
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] net: ena: Do not waste napi skb cache
2022-01-26 13:16 ` [PATCH v2] " Hyeonggon Yoo
@ 2022-01-26 15:16 ` Shay Agroskin
2022-01-26 15:52 ` Jakub Kicinski
1 sibling, 0 replies; 6+ messages in thread
From: Shay Agroskin @ 2022-01-26 15:16 UTC (permalink / raw)
To: Hyeonggon Yoo
Cc: jwiedmann.dev, Arthur Kiyanovski, David Arinzon, Noam Dagan,
Saeed Bishara, David S . Miller, Jakub Kicinski, Daniel Borkmann,
Sameeh Jubran, Wei Yongjun, Lorenzo Bianconi, linux-kernel
Hyeonggon Yoo <42.hyeyoo@gmail.com> writes:
> CAUTION: This email originated from outside of the
> organization. Do not click links or open attachments unless you
> can confirm the sender and know the content is safe.
>
>
>
> By profiling, discovered that ena device driver allocates skb by
> build_skb() and frees by napi_skb_cache_put(). Because the
> driver
> does not use napi skb cache in allocation path, napi skb cache
> is
> periodically filled and flushed. This is waste of napi skb
> cache.
>
> As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> and napi_alloc_skb() when allocating skb.
>
> This patch was tested on aws a1.metal instance.
>
> [ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
> netdev_alloc_skb_ip_align() to keep things consistent. ]
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Thank you for this work
Acked-by: Shay Agroskin <shayagr@amazon.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net: ena: Do not waste napi skb cache
2022-01-26 13:16 ` [PATCH v2] " Hyeonggon Yoo
2022-01-26 15:16 ` Shay Agroskin
@ 2022-01-26 15:52 ` Jakub Kicinski
2022-01-29 8:55 ` Hyeonggon Yoo
1 sibling, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2022-01-26 15:52 UTC (permalink / raw)
To: Hyeonggon Yoo
Cc: jwiedmann.dev, Shay Agroskin, Arthur Kiyanovski, David Arinzon,
Noam Dagan, Saeed Bishara, David S . Miller, Daniel Borkmann,
Sameeh Jubran, Wei Yongjun, Lorenzo Bianconi, linux-kernel
On Wed, 26 Jan 2022 13:16:41 +0000 Hyeonggon Yoo wrote:
> By profiling, discovered that ena device driver allocates skb by
> build_skb() and frees by napi_skb_cache_put(). Because the driver
> does not use napi skb cache in allocation path, napi skb cache is
> periodically filled and flushed. This is waste of napi skb cache.
>
> As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> and napi_alloc_skb() when allocating skb.
>
> This patch was tested on aws a1.metal instance.
>
> [ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
> netdev_alloc_skb_ip_align() to keep things consistent. ]
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
It seems you missed CCing netdev@, you'll need to repost.
You can keep the ack from Shay.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net: ena: Do not waste napi skb cache
2022-01-26 15:52 ` Jakub Kicinski
@ 2022-01-29 8:55 ` Hyeonggon Yoo
0 siblings, 0 replies; 6+ messages in thread
From: Hyeonggon Yoo @ 2022-01-29 8:55 UTC (permalink / raw)
To: Jakub Kicinski
Cc: jwiedmann.dev, Shay Agroskin, Arthur Kiyanovski, David Arinzon,
Noam Dagan, Saeed Bishara, David S . Miller, Daniel Borkmann,
Sameeh Jubran, Wei Yongjun, Lorenzo Bianconi, linux-kernel
On Wed, Jan 26, 2022 at 07:52:20AM -0800, Jakub Kicinski wrote:
> On Wed, 26 Jan 2022 13:16:41 +0000 Hyeonggon Yoo wrote:
> > By profiling, discovered that ena device driver allocates skb by
> > build_skb() and frees by napi_skb_cache_put(). Because the driver
> > does not use napi skb cache in allocation path, napi skb cache is
> > periodically filled and flushed. This is waste of napi skb cache.
> >
> > As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> > and napi_alloc_skb() when allocating skb.
> >
> > This patch was tested on aws a1.metal instance.
> >
> > [ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
> > netdev_alloc_skb_ip_align() to keep things consistent. ]
> >
> > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
>
> It seems you missed CCing netdev@, you'll need to repost.
> You can keep the ack from Shay.
Oh my mistake. I did it. Thanks!
Hyeonggon
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-01 5:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 8:53 [PATCH v2] net: ena: Do not waste napi skb cache Hyeonggon Yoo
2022-02-01 5:50 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-01-23 11:56 [PATCH] " Hyeonggon Yoo
2022-01-26 13:16 ` [PATCH v2] " Hyeonggon Yoo
2022-01-26 15:16 ` Shay Agroskin
2022-01-26 15:52 ` Jakub Kicinski
2022-01-29 8:55 ` Hyeonggon Yoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).