From: Shay Agroskin <shayagr@amazon.com>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: <jwiedmann.dev@gmail.com>, Arthur Kiyanovski <akiyano@amazon.com>,
"David Arinzon" <darinzon@amazon.com>,
Noam Dagan <ndagan@amazon.com>,
"Saeed Bishara" <saeedb@amazon.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"Sameeh Jubran" <sameehj@amazon.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: ena: Do not waste napi skb cache
Date: Wed, 26 Jan 2022 17:16:35 +0200 [thread overview]
Message-ID: <pj41zlilu61q85.fsf@u570694869fb251.ant.amazon.com> (raw)
In-Reply-To: <YfFJuQQBLJRxIJR+@ip-172-31-19-208.ap-northeast-1.compute.internal>
Hyeonggon Yoo <42.hyeyoo@gmail.com> writes:
> CAUTION: This email originated from outside of the
> organization. Do not click links or open attachments unless you
> can confirm the sender and know the content is safe.
>
>
>
> By profiling, discovered that ena device driver allocates skb by
> build_skb() and frees by napi_skb_cache_put(). Because the
> driver
> does not use napi skb cache in allocation path, napi skb cache
> is
> periodically filled and flushed. This is waste of napi skb
> cache.
>
> As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> and napi_alloc_skb() when allocating skb.
>
> This patch was tested on aws a1.metal instance.
>
> [ jwiedmann.dev@gmail.com: Use napi_alloc_skb() instead of
> netdev_alloc_skb_ip_align() to keep things consistent. ]
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Thank you for this work
Acked-by: Shay Agroskin <shayagr@amazon.com>
next prev parent reply other threads:[~2022-01-26 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 11:56 [PATCH] net: ena: Do not waste napi skb cache Hyeonggon Yoo
2022-01-24 8:57 ` Julian Wiedmann
2022-01-24 9:29 ` Julian Wiedmann
2022-01-24 20:50 ` Shay Agroskin
2022-01-25 9:34 ` Hyeonggon Yoo
2022-01-25 13:50 ` Julian Wiedmann
2022-01-29 8:56 ` Hyeonggon Yoo
2022-01-25 13:45 ` Julian Wiedmann
2022-01-26 13:16 ` [PATCH v2] " Hyeonggon Yoo
2022-01-26 15:16 ` Shay Agroskin [this message]
2022-01-26 15:52 ` Jakub Kicinski
2022-01-29 8:55 ` Hyeonggon Yoo
2022-01-29 8:53 Hyeonggon Yoo
2022-02-01 5:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pj41zlilu61q85.fsf@u570694869fb251.ant.amazon.com \
--to=shayagr@amazon.com \
--cc=42.hyeyoo@gmail.com \
--cc=akiyano@amazon.com \
--cc=daniel@iogearbox.net \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=jwiedmann.dev@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=ndagan@amazon.com \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).