* [v2,1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format
2022-02-16 9:32 [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
@ 2022-02-16 9:32 ` xinlei.lee
2022-02-16 10:22 ` Krzysztof Kozlowski
` (2 more replies)
2022-02-16 9:32 ` [v2,2/4] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
` (4 subsequent siblings)
5 siblings, 3 replies; 18+ messages in thread
From: xinlei.lee @ 2022-02-16 9:32 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format as suggested by maintainer
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
---
.../bindings/pwm/mediatek,pwm-disp.yaml | 71 +++++++++++++++++++
.../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 ------------
2 files changed, 71 insertions(+), 44 deletions(-)
create mode 100755 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
new file mode 100755
index 000000000000..edf2a2e9ea72
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek PWM Controller Device Tree Bindings
+
+maintainers:
+ - Jitao Shi <jitao.shi@mediatek.com>
+ - Xinlei Lee <xinlei.lee@mediatek.com>
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt2701-disp-pwm
+ - mediatek,mt6595-disp-pwm
+ - mediatek,mt8173-disp-pwm
+ - mediatek,mt8183-disp-pwm
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ "#pwm-cells":
+ description:
+ Number of cells in a PWM specifier.
+
+ clocks:
+ items:
+ - description: Main Clock
+ - description: Mm Clock
+
+ clock-names:
+ items:
+ - const: main
+ - const: mm
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - power-domains
+ - "#pwm-cells"
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/mt8183-clk.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/power/mt8183-power.h>
+
+ pwm: pwm@1100e000 {
+ compatible = "mediatek,mt8183-disp-pwm";
+ reg = <0x1100e000 0x1000>;
+ interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
+ power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
+ #pwm-cells = <2>;
+ clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
+ <&infracfg CLK_INFRA_DISP_PWM>;
+ clock-names = "main", "mm";
+ };
diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
deleted file mode 100644
index 902b271891ae..000000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
+++ /dev/null
@@ -1,44 +0,0 @@
-MediaTek display PWM controller
-
-Required properties:
- - compatible: should be "mediatek,<name>-disp-pwm":
- - "mediatek,mt2701-disp-pwm": found on mt2701 SoC.
- - "mediatek,mt6595-disp-pwm": found on mt6595 SoC.
- - "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm": found on mt8167 SoC.
- - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
- - reg: physical base address and length of the controller's registers.
- - #pwm-cells: must be 2. See pwm.yaml in this directory for a description of
- the cell format.
- - clocks: phandle and clock specifier of the PWM reference clock.
- - clock-names: must contain the following:
- - "main": clock used to generate PWM signals.
- - "mm": sync signals from the modules of mmsys.
- - pinctrl-names: Must contain a "default" entry.
- - pinctrl-0: One property must exist for each entry in pinctrl-names.
- See pinctrl/pinctrl-bindings.txt for details of the property values.
-
-Example:
- pwm0: pwm@1401e000 {
- compatible = "mediatek,mt8173-disp-pwm",
- "mediatek,mt6595-disp-pwm";
- reg = <0 0x1401e000 0 0x1000>;
- #pwm-cells = <2>;
- clocks = <&mmsys CLK_MM_DISP_PWM026M>,
- <&mmsys CLK_MM_DISP_PWM0MM>;
- clock-names = "main", "mm";
- pinctrl-names = "default";
- pinctrl-0 = <&disp_pwm0_pins>;
- };
-
- backlight_lcd: backlight_lcd {
- compatible = "pwm-backlight";
- pwms = <&pwm0 0 1000000>;
- brightness-levels = <
- 0 16 32 48 64 80 96 112
- 128 144 160 176 192 208 224 240
- 255
- >;
- default-brightness-level = <9>;
- power-supply = <&mt6397_vio18_reg>;
- enable-gpios = <&pio 95 GPIO_ACTIVE_HIGH>;
- };
--
2.18.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [v2,1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format
2022-02-16 9:32 ` [v2,1/4] dt-bindings: pwm: " xinlei.lee
@ 2022-02-16 10:22 ` Krzysztof Kozlowski
2022-02-16 22:51 ` Rob Herring
2022-02-25 6:24 ` [v2, 1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format Chen-Yu Tsai
2 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-16 10:22 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On 16/02/2022 10:32, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format as suggested by maintainer
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> .../bindings/pwm/mediatek,pwm-disp.yaml | 71 +++++++++++++++++++
> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 ------------
> 2 files changed, 71 insertions(+), 44 deletions(-)
> create mode 100755 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> new file mode 100755
> index 000000000000..edf2a2e9ea72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek PWM Controller Device Tree Bindings
This is a Display PWM, not a generic PWM.
> +
> +maintainers:
> + - Jitao Shi <jitao.shi@mediatek.com>
> + - Xinlei Lee <xinlei.lee@mediatek.com>
> +
My comment about pwm schema was ignored.
Please include pwm.yaml.
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt2701-disp-pwm
> + - mediatek,mt6595-disp-pwm
> + - mediatek,mt8173-disp-pwm
> + - mediatek,mt8183-disp-pwm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + "#pwm-cells":
> + description:
> + Number of cells in a PWM specifier.
Need a const. Description can be skipped, it's obvious.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [v2,1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format
2022-02-16 9:32 ` [v2,1/4] dt-bindings: pwm: " xinlei.lee
2022-02-16 10:22 ` Krzysztof Kozlowski
@ 2022-02-16 22:51 ` Rob Herring
[not found] ` <0f8c014c077d0fc75c8552e457482d9daf68d73b.camel@mediatek.com>
2022-02-25 6:24 ` [v2, 1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format Chen-Yu Tsai
2 siblings, 1 reply; 18+ messages in thread
From: Rob Herring @ 2022-02-16 22:51 UTC (permalink / raw)
To: xinlei.lee
Cc: linux-arm-kernel, thierry.reding, lee.jones, linux-pwm,
linux-mediatek, matthias.bgg, robh+dt, jitao.shi,
Project_Global_Chrome_Upstream_Group, linux-kernel,
allen-kh.cheng, u.kleine-koenig, devicetree, Xinlei Lee
On Wed, 16 Feb 2022 17:32:48 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format as suggested by maintainer
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> .../bindings/pwm/mediatek,pwm-disp.yaml | 71 +++++++++++++++++++
> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 ------------
> 2 files changed, 71 insertions(+), 44 deletions(-)
> create mode 100755 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1593550
pwm@1400a000: compatible:0: 'mediatek,mt7623-disp-pwm' is not one of ['mediatek,mt2701-disp-pwm', 'mediatek,mt6595-disp-pwm', 'mediatek,mt8173-disp-pwm', 'mediatek,mt8183-disp-pwm']
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
pwm@1400a000: compatible: ['mediatek,mt7623-disp-pwm', 'mediatek,mt2701-disp-pwm'] is too long
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
pwm@1400a000: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/mt2701-evb.dt.yaml
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
pwm@1400a000: 'power-domains' is a required property
arch/arm/boot/dts/mt2701-evb.dt.yaml
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dt.yaml
arch/arm/boot/dts/mt7623n-rfb-emmc.dt.yaml
pwm@1401e000: compatible: ['mediatek,mt8173-disp-pwm', 'mediatek,mt6595-disp-pwm'] is too long
arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
pwm@1401e000: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
pwm@1401e000: 'power-domains' is a required property
arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
pwm@1401f000: compatible: ['mediatek,mt8173-disp-pwm', 'mediatek,mt6595-disp-pwm'] is too long
arch/arm64/boot/dts/mediatek/mt8173-elm.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dt.yaml
arch/arm64/boot/dts/mediatek/mt8173-evb.dt.yaml
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [v2, 1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format
2022-02-16 9:32 ` [v2,1/4] dt-bindings: pwm: " xinlei.lee
2022-02-16 10:22 ` Krzysztof Kozlowski
2022-02-16 22:51 ` Rob Herring
@ 2022-02-25 6:24 ` Chen-Yu Tsai
[not found] ` <918bfe38f716c2e1ca411ae42a5a9ab0bf810692.camel@mediatek.com>
2 siblings, 1 reply; 18+ messages in thread
From: Chen-Yu Tsai @ 2022-02-25 6:24 UTC (permalink / raw)
To: xinlei.lee
Cc: thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi, allen-kh.cheng, linux-pwm, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On Wed, Feb 16, 2022 at 5:43 PM <xinlei.lee@mediatek.com> wrote:
>
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format as suggested by maintainer
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> .../bindings/pwm/mediatek,pwm-disp.yaml | 71 +++++++++++++++++++
> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 ------------
> 2 files changed, 71 insertions(+), 44 deletions(-)
> create mode 100755 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> new file mode 100755
> index 000000000000..edf2a2e9ea72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek PWM Controller Device Tree Bindings
> +
> +maintainers:
> + - Jitao Shi <jitao.shi@mediatek.com>
> + - Xinlei Lee <xinlei.lee@mediatek.com>
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt2701-disp-pwm
> + - mediatek,mt6595-disp-pwm
> + - mediatek,mt8173-disp-pwm
> + - mediatek,mt8183-disp-pwm
mt8183 was not in the original text file binding. Please split this out.
Also, the combination "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm"
is missing.
ChenYu
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + "#pwm-cells":
> + description:
> + Number of cells in a PWM specifier.
> +
> + clocks:
> + items:
> + - description: Main Clock
> + - description: Mm Clock
> +
> + clock-names:
> + items:
> + - const: main
> + - const: mm
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - power-domains
> + - "#pwm-cells"
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/mt8183-clk.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/power/mt8183-power.h>
> +
> + pwm: pwm@1100e000 {
> + compatible = "mediatek,mt8183-disp-pwm";
> + reg = <0x1100e000 0x1000>;
> + interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> + #pwm-cells = <2>;
> + clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
> + <&infracfg CLK_INFRA_DISP_PWM>;
> + clock-names = "main", "mm";
> + };
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> deleted file mode 100644
> index 902b271891ae..000000000000
> --- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -MediaTek display PWM controller
> -
> -Required properties:
> - - compatible: should be "mediatek,<name>-disp-pwm":
> - - "mediatek,mt2701-disp-pwm": found on mt2701 SoC.
> - - "mediatek,mt6595-disp-pwm": found on mt6595 SoC.
> - - "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm": found on mt8167 SoC.
> - - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
> - - reg: physical base address and length of the controller's registers.
> - - #pwm-cells: must be 2. See pwm.yaml in this directory for a description of
> - the cell format.
> - - clocks: phandle and clock specifier of the PWM reference clock.
> - - clock-names: must contain the following:
> - - "main": clock used to generate PWM signals.
> - - "mm": sync signals from the modules of mmsys.
> - - pinctrl-names: Must contain a "default" entry.
> - - pinctrl-0: One property must exist for each entry in pinctrl-names.
> - See pinctrl/pinctrl-bindings.txt for details of the property values.
> -
> -Example:
> - pwm0: pwm@1401e000 {
> - compatible = "mediatek,mt8173-disp-pwm",
> - "mediatek,mt6595-disp-pwm";
> - reg = <0 0x1401e000 0 0x1000>;
> - #pwm-cells = <2>;
> - clocks = <&mmsys CLK_MM_DISP_PWM026M>,
> - <&mmsys CLK_MM_DISP_PWM0MM>;
> - clock-names = "main", "mm";
> - pinctrl-names = "default";
> - pinctrl-0 = <&disp_pwm0_pins>;
> - };
> -
> - backlight_lcd: backlight_lcd {
> - compatible = "pwm-backlight";
> - pwms = <&pwm0 0 1000000>;
> - brightness-levels = <
> - 0 16 32 48 64 80 96 112
> - 128 144 160 176 192 208 224 240
> - 255
> - >;
> - default-brightness-level = <9>;
> - power-supply = <&mt6397_vio18_reg>;
> - enable-gpios = <&pio 95 GPIO_ACTIVE_HIGH>;
> - };
> --
> 2.18.0
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 18+ messages in thread
* [v2,2/4] dt-bindings: pwm: Add compatible for MediaTek MT8192
2022-02-16 9:32 [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
2022-02-16 9:32 ` [v2,1/4] dt-bindings: pwm: " xinlei.lee
@ 2022-02-16 9:32 ` xinlei.lee
2022-02-16 10:24 ` Krzysztof Kozlowski
2022-02-16 9:32 ` [v2,3/4] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
` (3 subsequent siblings)
5 siblings, 1 reply; 18+ messages in thread
From: xinlei.lee @ 2022-02-16 9:32 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
Add dt-binding documentation of pwm for MediaTek MT8192 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index edf2a2e9ea72..825cad513309 100755
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -17,6 +17,7 @@ properties:
- mediatek,mt6595-disp-pwm
- mediatek,mt8173-disp-pwm
- mediatek,mt8183-disp-pwm
+ - mediatek,mt8192-disp-pwm
reg:
maxItems: 1
--
2.18.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [v2,2/4] dt-bindings: pwm: Add compatible for MediaTek MT8192
2022-02-16 9:32 ` [v2,2/4] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
@ 2022-02-16 10:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-16 10:24 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On 16/02/2022 10:32, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Add dt-binding documentation of pwm for MediaTek MT8192 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* [v2,3/4] dt-bindings: pwm: Add compatible for MediaTek MT8195
2022-02-16 9:32 [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
2022-02-16 9:32 ` [v2,1/4] dt-bindings: pwm: " xinlei.lee
2022-02-16 9:32 ` [v2,2/4] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
@ 2022-02-16 9:32 ` xinlei.lee
2022-02-16 10:24 ` Krzysztof Kozlowski
2022-02-16 9:32 ` [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
` (2 subsequent siblings)
5 siblings, 1 reply; 18+ messages in thread
From: xinlei.lee @ 2022-02-16 9:32 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
Add dt-binding documentation of pwm for MediaTek MT8195 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 825cad513309..768ab04d3764 100755
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -18,6 +18,7 @@ properties:
- mediatek,mt8173-disp-pwm
- mediatek,mt8183-disp-pwm
- mediatek,mt8192-disp-pwm
+ - mediatek,mt8195-disp-pwm
reg:
maxItems: 1
--
2.18.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [v2,3/4] dt-bindings: pwm: Add compatible for MediaTek MT8195
2022-02-16 9:32 ` [v2,3/4] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
@ 2022-02-16 10:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-16 10:24 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On 16/02/2022 10:32, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Add dt-binding documentation of pwm for MediaTek MT8195 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-02-16 9:32 [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
` (2 preceding siblings ...)
2022-02-16 9:32 ` [v2,3/4] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
@ 2022-02-16 9:32 ` xinlei.lee
2022-02-16 10:25 ` Krzysztof Kozlowski
2022-02-24 21:19 ` Rob Herring
2022-02-16 9:47 ` [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format Macpaul Lin
2022-02-16 10:24 ` Krzysztof Kozlowski
5 siblings, 2 replies; 18+ messages in thread
From: xinlei.lee @ 2022-02-16 9:32 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 768ab04d3764..1f45b1b8c3d4 100755
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -17,6 +17,7 @@ properties:
- mediatek,mt6595-disp-pwm
- mediatek,mt8173-disp-pwm
- mediatek,mt8183-disp-pwm
+ - mediatek,mt8186-disp-pwm
- mediatek,mt8192-disp-pwm
- mediatek,mt8195-disp-pwm
--
2.18.0
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-02-16 9:32 ` [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
@ 2022-02-16 10:25 ` Krzysztof Kozlowski
2022-02-24 21:19 ` Rob Herring
1 sibling, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-16 10:25 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On 16/02/2022 10:32, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186
2022-02-16 9:32 ` [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
2022-02-16 10:25 ` Krzysztof Kozlowski
@ 2022-02-24 21:19 ` Rob Herring
[not found] ` <acc635f9e6d4f6f278ac334b13e96ce30c8c8b1d.camel@mediatek.com>
1 sibling, 1 reply; 18+ messages in thread
From: Rob Herring @ 2022-02-24 21:19 UTC (permalink / raw)
To: xinlei.lee
Cc: thierry.reding, u.kleine-koenig, lee.jones, matthias.bgg,
jitao.shi, allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On Wed, Feb 16, 2022 at 05:32:51PM +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Add dt-binding documentation of pwm for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> index 768ab04d3764..1f45b1b8c3d4 100755
> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -17,6 +17,7 @@ properties:
> - mediatek,mt6595-disp-pwm
> - mediatek,mt8173-disp-pwm
> - mediatek,mt8183-disp-pwm
> + - mediatek,mt8186-disp-pwm
> - mediatek,mt8192-disp-pwm
> - mediatek,mt8195-disp-pwm
It seems unlikely that every SoC has a different version of h/w for
something as simple as a PWM. There's not an appropriate fallback? The
first version from an SoC that has all the features and would work with
existing driver unchanged?
Rob
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format
2022-02-16 9:32 [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
` (3 preceding siblings ...)
2022-02-16 9:32 ` [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
@ 2022-02-16 9:47 ` Macpaul Lin
2022-02-16 10:19 ` Krzysztof Kozlowski
2022-02-16 10:24 ` Krzysztof Kozlowski
5 siblings, 1 reply; 18+ messages in thread
From: Macpaul Lin @ 2022-02-16 9:47 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On 2/16/22 5:32 PM, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Changes since v1:
> 1. Fixed formatting issues mentioned in the v1.
> 2. Delete pwm-mtk-disp.txt.
> 3. Add mtk_pwm dt_maintainers.
> 4. Add "#pwm-cells" & power-domains properties.
> 5. Make dt_checking successful.
>
> Xinlei Lee (4):
> dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml
> format
> dt-bindings: pwm: Add compatible for MediaTek MT8192
> dt-bindings: pwm: Add compatible for MediaTek MT8195
> dt-bindings: pwm: Add compatible for MediaTek MT8186
>
> .../bindings/pwm/mediatek,pwm-disp.yaml | 74 +++++++++++++++++++
> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 -----------
> 2 files changed, 74 insertions(+), 44 deletions(-)
> create mode 100755 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>
Why did you drop [PATCH] tag in the subject of your patch series?
Please keep it for distinguishing it from RFC/RESEND and other
meaningful tags next time.
Thanks
Macpaul Lin
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format
2022-02-16 9:47 ` [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format Macpaul Lin
@ 2022-02-16 10:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-16 10:19 UTC (permalink / raw)
To: Macpaul Lin, xinlei.lee, thierry.reding, u.kleine-koenig,
lee.jones, robh+dt, matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On 16/02/2022 10:47, Macpaul Lin wrote:
>
>
> On 2/16/22 5:32 PM, xinlei.lee@mediatek.com wrote:
>> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>>
>> Changes since v1:
>> 1. Fixed formatting issues mentioned in the v1.
>> 2. Delete pwm-mtk-disp.txt.
>> 3. Add mtk_pwm dt_maintainers.
>> 4. Add "#pwm-cells" & power-domains properties.
>> 5. Make dt_checking successful.
>>
>> Xinlei Lee (4):
>> dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml
>> format
>> dt-bindings: pwm: Add compatible for MediaTek MT8192
>> dt-bindings: pwm: Add compatible for MediaTek MT8195
>> dt-bindings: pwm: Add compatible for MediaTek MT8186
>>
>> .../bindings/pwm/mediatek,pwm-disp.yaml | 74 +++++++++++++++++++
>> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 -----------
>> 2 files changed, 74 insertions(+), 44 deletions(-)
>> create mode 100755 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
>> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>>
>
> Why did you drop [PATCH] tag in the subject of your patch series?
> Please keep it for distinguishing it from RFC/RESEND and other
> meaningful tags next time.
I also asked for this in v1 patchset, so it's a pity my suggestion was
not listened to.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format
2022-02-16 9:32 [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
` (4 preceding siblings ...)
2022-02-16 9:47 ` [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format Macpaul Lin
@ 2022-02-16 10:24 ` Krzysztof Kozlowski
5 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-16 10:24 UTC (permalink / raw)
To: xinlei.lee, thierry.reding, u.kleine-koenig, lee.jones, robh+dt,
matthias.bgg, jitao.shi
Cc: allen-kh.cheng, linux-pwm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, Xinlei Lee
On 16/02/2022 10:32, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Changes since v1:
> 1. Fixed formatting issues mentioned in the v1.
> 2. Delete pwm-mtk-disp.txt.
> 3. Add mtk_pwm dt_maintainers.
> 4. Add "#pwm-cells" & power-domains properties.
> 5. Make dt_checking successful.
Any reason in changing your email address in all patches? Maybe some
mail client misconfiguration?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 18+ messages in thread