Re: [PATCH v5 02/15] dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation

[Ansuel Smith <ansuelsmth@gmail.com>]

On Thu, Feb 24, 2022 at 12:46:01PM -0600, Rob Herring wrote:
> On Thu, Feb 24, 2022 at 05:48:18PM +0100, Ansuel Smith wrote:
> > Simplify qcon,gcc-apq8064 Documentation by using qcom,gcc.yaml as a
> > template and remove the compatible from qcom,gcc.yaml
> > 
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> >  .../bindings/clock/qcom,gcc-apq8064.yaml      | 29 +++++--------------
> >  .../bindings/clock/qcom,gcc-other.yaml        |  3 --
> >  2 files changed, 7 insertions(+), 25 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > index 8e2eac6cbfb9..97936411b6b4 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > @@ -6,6 +6,9 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  
> >  title: Qualcomm Global Clock & Reset Controller Binding for APQ8064
> >  
> > +allOf:
> > +  - $ref: qcom,gcc.yaml#
> > +
> >  maintainers:
> >    - Stephen Boyd <sboyd@kernel.org>
> >    - Taniya Das <tdas@codeaurora.org>
> > @@ -17,22 +20,12 @@ description: |
> >    See also:
> >    - dt-bindings/clock/qcom,gcc-msm8960.h
> >    - dt-bindings/reset/qcom,gcc-msm8960.h
> > +  - dt-bindings/clock/qcom,gcc-apq8084.h
> > +  - dt-bindings/reset/qcom,gcc-apq8084.h
> >  
> >  properties:
> >    compatible:
> > -    const: qcom,gcc-apq8064
> 
> I assume you didn't mean to remove this?
>

Think you got confused by the patch?

> > -
> > -  '#clock-cells':
> > -    const: 1
> > -
> > -  '#reset-cells':
> > -    const: 1
> > -
> > -  '#power-domain-cells':
> > -    const: 1
> > -
> > -  reg:
> > -    maxItems: 1
> > +    const: qcom,gcc-apq8084

The compatible is here. Or I'm missing something?

> >  
> >    nvmem-cells:
> >      minItems: 1
> > @@ -53,21 +46,13 @@ properties:
> >    '#thermal-sensor-cells':
> >      const: 1
> >  
> > -  protected-clocks:
> > -    description:
> > -      Protected clock specifier list as per common clock binding.
> > -
> >  required:
> >    - compatible
> > -  - reg
> > -  - '#clock-cells'
> > -  - '#reset-cells'
> > -  - '#power-domain-cells'
> >    - nvmem-cells
> >    - nvmem-cell-names
> >    - '#thermal-sensor-cells'
> >  
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >  
> >  examples:
> >    - |
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
> > index 4e5903bcd70d..47e1c5332d76 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
> > @@ -15,8 +15,6 @@ description:
> >    power domains.
> >  
> >    See also:
> > -  - dt-bindings/clock/qcom,gcc-apq8084.h
> > -  - dt-bindings/reset/qcom,gcc-apq8084.h
> >    - dt-bindings/clock/qcom,gcc-ipq4019.h
> >    - dt-bindings/clock/qcom,gcc-ipq6018.h
> >    - dt-bindings/reset/qcom,gcc-ipq6018.h
> > @@ -40,7 +38,6 @@ allOf:
> >  properties:
> >    compatible:
> >      enum:
> > -      - qcom,gcc-apq8084
> >        - qcom,gcc-ipq4019
> >        - qcom,gcc-ipq6018
> >        - qcom,gcc-ipq8064
> > -- 
> > 2.34.1
> > 
> > 

-- 
	Ansuel