[PATCH 1/2] ASoC: wm8940: add devicetree support

[PATCH 1/2] ASoC: wm8940: add devicetree support

[Lukasz Majewski]

This adds devicetree support to the wm8940 codec driver.
With a DT-based kernel, there is no board-specific setting
to select the driver so allow it to be manually chosen.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 sound/soc/codecs/Kconfig  | 2 +-
 sound/soc/codecs/wm8940.c | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index f46a22660103..5120b15139bc 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1811,7 +1811,7 @@ config SND_SOC_WM8904
 	depends on I2C
 
 config SND_SOC_WM8940
-	tristate
+	tristate "Wolfson Microelectronics WM8940 codec"
 	depends on I2C
 
 config SND_SOC_WM8955
diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c
index 440d048ef0c0..8615a55f84dd 100644
--- a/sound/soc/codecs/wm8940.c
+++ b/sound/soc/codecs/wm8940.c
@@ -779,9 +779,16 @@ static const struct i2c_device_id wm8940_i2c_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, wm8940_i2c_id);
 
+static const struct of_device_id wm8940_of_match[] = {
+	{ .compatible = "wlf,wm8940", },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, wm8940_of_match);
+
 static struct i2c_driver wm8940_i2c_driver = {
 	.driver = {
 		.name = "wm8940",
+		.of_match_table = wm8940_of_match,
 	},
 	.probe =    wm8940_i2c_probe,
 	.id_table = wm8940_i2c_id,
-- 
2.35.1

Re: [PATCH 1/2] ASoC: wm8940: add devicetree support

[Charles Keepax]

On Mon, May 09, 2022 at 02:10:55PM +0200, Lukasz Majewski wrote:
> This adds devicetree support to the wm8940 codec driver.
> With a DT-based kernel, there is no board-specific setting
> to select the driver so allow it to be manually chosen.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: [PATCH 1/2] ASoC: wm8940: add devicetree support

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

On Mon, May 09, 2022 at 02:10:55PM +0200, Lukasz Majewski wrote:

> This adds devicetree support to the wm8940 codec driver.
> With a DT-based kernel, there is no board-specific setting
> to select the driver so allow it to be manually chosen.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  sound/soc/codecs/Kconfig  | 2 +-
>  sound/soc/codecs/wm8940.c | 7 +++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)

You need to provide a binding document for any new bindings you add in
code.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] ASoC: wm8940: add devicetree support

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi Mark,

> On Mon, May 09, 2022 at 02:10:55PM +0200, Lukasz Majewski wrote:
> 
> > This adds devicetree support to the wm8940 codec driver.
> > With a DT-based kernel, there is no board-specific setting
> > to select the driver so allow it to be manually chosen.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  sound/soc/codecs/Kconfig  | 2 +-
> >  sound/soc/codecs/wm8940.c | 7 +++++++
> >  2 files changed, 8 insertions(+), 1 deletion(-)  
> 
> You need to provide a binding document for any new bindings you add in
> code.

The second patch in this series adds proper *.yaml file to Linux source
tree.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] ASoC: wm8940: add devicetree support

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

On Tue, May 10, 2022 at 09:24:38AM +0200, Lukasz Majewski wrote:
> > On Mon, May 09, 2022 at 02:10:55PM +0200, Lukasz Majewski wrote:

> > > This adds devicetree support to the wm8940 codec driver.
> > > With a DT-based kernel, there is no board-specific setting
> > > to select the driver so allow it to be manually chosen.

> > You need to provide a binding document for any new bindings you add in
> > code.

> The second patch in this series adds proper *.yaml file to Linux source
> tree.

You didn't send the patches as a series, you sent two separate threads
so they got totally separated in my inbox.  I did eventually connect
them.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] ASoC: wm8940: add devicetree support

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

Hi Mark,

> On Tue, May 10, 2022 at 09:24:38AM +0200, Lukasz Majewski wrote:
> > > On Mon, May 09, 2022 at 02:10:55PM +0200, Lukasz Majewski wrote:  
> 
> > > > This adds devicetree support to the wm8940 codec driver.
> > > > With a DT-based kernel, there is no board-specific setting
> > > > to select the driver so allow it to be manually chosen.  
> 
> > > You need to provide a binding document for any new bindings you
> > > add in code.  
> 
> > The second patch in this series adds proper *.yaml file to Linux
> > source tree.  
> 
> You didn't send the patches as a series, you sent two separate threads
> so they got totally separated in my inbox.  I did eventually connect
> them.

Thanks :-)


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] ASoC: wm8940: add devicetree support

[Mark Brown]

On Mon, 9 May 2022 14:10:55 +0200, Lukasz Majewski wrote:
> This adds devicetree support to the wm8940 codec driver.
> With a DT-based kernel, there is no board-specific setting
> to select the driver so allow it to be manually chosen.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: wm8940: add devicetree support
      commit: 3a3610aaa9dce8ef1257bb42ac7f0fe2b5809a54

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark