From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Siddh Raman Pant <siddhpant.gh@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shuah Khan <skhan@linuxfoundation.org>,
alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: alsa: Better error messages
Date: Mon, 16 May 2022 12:44:16 +0100 [thread overview]
Message-ID: <YoI5EEPjOQPzB6se@sirena.org.uk> (raw)
In-Reply-To: <s5h35h9c3yn.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
On Mon, May 16, 2022 at 09:49:04AM +0200, Takashi Iwai wrote:
> On Fri, 13 May 2022 15:40:57 +0200,
> Siddh Raman Pant wrote:
> > This allows for potentially better machine-parsing due to an
> > expected / fixed format. Also because of eyecandy reasons.
> > Whenever possible, errors will start with the name of the
> > offending card/control, separated by the error with colons.
> > Whenever there is a description of an error given, the generated
> > error string from snd_strerror will be (mostly) enclosed in
> > parentheses at the end.
> > Clarity of error messages have been (hopefully) improved.
> But, honestly speaking, I'm not sure whether it worth.
> Although it's possibly a bit more consistent over all texts, I
> don't see significant improvement by this change.
> But I'm fine to apply it, so keep this pending and would like to
> hear from others.
Some of it is probably fine but there's a lot of different changes for a
lot of different styles in here, not all of which look great to me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-16 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 13:40 [PATCH] selftests: alsa: Better error messages Siddh Raman Pant
2022-05-16 7:49 ` Takashi Iwai
2022-05-16 11:44 ` Mark Brown [this message]
2022-05-16 15:02 ` Mark Brown
2022-05-16 18:50 ` Siddh Raman Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoI5EEPjOQPzB6se@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=perex@perex.cz \
--cc=siddhpant.gh@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).