From: Jarkko Sakkinen <jarkko@kernel.org>
To: Morten Linderud <morten@linderud.pw>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tpm/eventlog: Don't abort tpm_read_log on faulty ACPI address
Date: Wed, 15 Jun 2022 21:44:49 +0300 [thread overview]
Message-ID: <Yqooof3If/y9lBPC@iki.fi> (raw)
In-Reply-To: <20220610132912.toovhhqtqr3vdepq@terminus>
On Fri, Jun 10, 2022 at 03:29:12PM +0200, Morten Linderud wrote:
> On Thu, Jun 09, 2022 at 02:47:12PM +0300, Jarkko Sakkinen wrote:
> > On Thu, Jun 09, 2022 at 10:11:59AM +0200, Morten Linderud wrote:
> > > On Thu, Jun 09, 2022 at 07:46:46AM +0300, Jarkko Sakkinen wrote:
> > >
> > > > What you are using this for? Without any actual bug report, this
> > > > is an obvious NAK.
> > >
> > > I have hardware with faulty ACPI values which prevents me from getting a
> > > eventlog. I can surely make a bugreport if it helps the case, but that seems
> > > like an arbiterary hurdle when I have already spent the time tracking down the
> > > issue and proposed a fix.
> >
> > What is the hardware?
>
> I included it in the commit message with the listed ACPI table values.
>
>
> The following hardware was used to test this issue:
> Framework Laptop (Pre-production)
> BIOS: INSYDE Corp, Revision: 3.2
> TPM Device: NTC, Firmware Revision: 7.2
>
> Dump of the faulty ACPI TPM2 table:
> [000h 0000 4] Signature : "TPM2" [Trusted Platform Module hardware interface Table]
> [004h 0004 4] Table Length : 0000004C
> [008h 0008 1] Revision : 04
> [009h 0009 1] Checksum : 2B
> [00Ah 0010 6] Oem ID : "INSYDE"
> [010h 0016 8] Oem Table ID : "TGL-ULT"
> [018h 0024 4] Oem Revision : 00000002
> [01Ch 0028 4] Asl Compiler ID : "ACPI"
> [020h 0032 4] Asl Compiler Revision : 00040000
>
> [024h 0036 2] Platform Class : 0000
> [026h 0038 2] Reserved : 0000
> [028h 0040 8] Control Address : 0000000000000000
> [030h 0048 4] Start Method : 06 [Memory Mapped I/O]
>
> [034h 0052 12] Method Parameters : 00 00 00 00 00 00 00 00 00 00 00 00
> [040h 0064 4] Minimum Log Length : 00010000
> [044h 0068 8] Log Address : 000000004053D000
>
> --
> Morten Linderud
> PGP: 9C02FF419FECBE16
If this is not something you can buy off-the-shelf, it
unfortunately does not cut.
BR, Jarkko
next prev parent reply other threads:[~2022-06-15 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:31 [PATCH v2] tpm/eventlog: Don't abort tpm_read_log on faulty ACPI address Morten Linderud
2022-06-09 4:46 ` Jarkko Sakkinen
2022-06-09 8:11 ` Morten Linderud
2022-06-09 11:47 ` Jarkko Sakkinen
2022-06-10 13:29 ` Morten Linderud
2022-06-15 18:44 ` Jarkko Sakkinen [this message]
2022-10-01 21:52 ` Erkki Eilonen
2022-10-02 11:10 ` Morten Linderud
2022-10-04 22:23 ` Jarkko Sakkinen
2023-02-14 21:52 ` Erkki Eilonen
2023-02-17 22:27 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqooof3If/y9lBPC@iki.fi \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morten@linderud.pw \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).