From: Jarkko Sakkinen <jarkko@kernel.org>
To: Erkki Eilonen <erkki@bearmetal.eu>
Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, morten@linderud.pw,
peterhuewe@gmx.de
Subject: Re: [PATCH v2] tpm/eventlog: Don't abort tpm_read_log on faulty ACPI address
Date: Wed, 5 Oct 2022 01:23:35 +0300 [thread overview]
Message-ID: <YzyyZ6AFAgTRG5G5@kernel.org> (raw)
In-Reply-To: <20221001215223.783896-1-erkki@bearmetal.eu>
On Sun, Oct 02, 2022 at 12:52:24AM +0300, Erkki Eilonen wrote:
> > If this is not something you can buy off-the-shelf, it
> > unfortunately does not cut.
>
> For a N=2, we're having the same issue with a set of OTC machines.
>
> Device: QuantaGrid D53X-1U
> BIOS:
> Vendor: INSYDE Corp.
> Version: 3A16.Q402
> Release_Date: 11/10/2021
>
> ACPI TPM2 table:
> [000h 0000 4] Signature : "TPM2" [Trusted Platform Module hardware interface table]
> [004h 0004 4] Table Length : 0000004C
> [008h 0008 1] Revision : 04
> [009h 0009 1] Checksum : 8C
> [00Ah 0010 6] Oem ID : "INSYDE"
> [010h 0016 8] Oem Table ID : "WHITLEY "
> [018h 0024 4] Oem Revision : 00000002
> [01Ch 0028 4] Asl Compiler ID : "INTL"
> [020h 0032 4] Asl Compiler Revision : 00040000
>
> [024h 0036 2] Platform Class : 0001
> [026h 0038 2] Reserved : 0000
> [028h 0040 8] Control Address : 0000000000000000
> [030h 0048 4] Start Method : 06 [Memory Mapped I/O]
>
> [034h 0052 12] Method Parameters : 00 00 00 00 00 00 00 00 00 00 00 00
> [040h 0064 4] Minimum Log Length : 00010000
> [044h 0068 8] Log Address : 0000000043274000
>
> Fallback to the UEFI eventlog is what we did for a short term fix too. Will try to contact the vendor for a fixed ACPI table long term.
>
> Morten: Did you get in contact with the vendor about this? Looks like a class error across different devices.
>
> Cheers,
> Erkki
Does the bug fix work for you? If you can give tested-by for it, then that
ofc changes everything.
BR, Jarkko
next prev parent reply other threads:[~2022-10-04 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 12:31 [PATCH v2] tpm/eventlog: Don't abort tpm_read_log on faulty ACPI address Morten Linderud
2022-06-09 4:46 ` Jarkko Sakkinen
2022-06-09 8:11 ` Morten Linderud
2022-06-09 11:47 ` Jarkko Sakkinen
2022-06-10 13:29 ` Morten Linderud
2022-06-15 18:44 ` Jarkko Sakkinen
2022-10-01 21:52 ` Erkki Eilonen
2022-10-02 11:10 ` Morten Linderud
2022-10-04 22:23 ` Jarkko Sakkinen [this message]
2023-02-14 21:52 ` Erkki Eilonen
2023-02-17 22:27 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzyyZ6AFAgTRG5G5@kernel.org \
--to=jarkko@kernel.org \
--cc=erkki@bearmetal.eu \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morten@linderud.pw \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).