* [PATCH -next] drm: Remove unnecessary print function dev_err()
@ 2022-06-13 1:26 Yang Li
2022-06-24 15:00 ` Paul Kocialkowski
0 siblings, 1 reply; 6+ messages in thread
From: Yang Li @ 2022-06-13 1:26 UTC (permalink / raw)
To: airlied
Cc: daniel, paul.kocialkowski, dri-devel, linux-kernel, Yang Li, Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warning:
./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
index df1805cf0f95..437b3011ae1e 100644
--- a/drivers/gpu/drm/logicvc/logicvc_drm.c
+++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
@@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "Failed to get IRQ\n");
ret = -ENODEV;
goto error_reserved_mem;
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] drm: Remove unnecessary print function dev_err()
2022-06-13 1:26 [PATCH -next] drm: Remove unnecessary print function dev_err() Yang Li
@ 2022-06-24 15:00 ` Paul Kocialkowski
2022-06-24 15:26 ` Paul Kocialkowski
0 siblings, 1 reply; 6+ messages in thread
From: Paul Kocialkowski @ 2022-06-24 15:00 UTC (permalink / raw)
To: Yang Li; +Cc: airlied, daniel, dri-devel, linux-kernel, Abaci Robot
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
Hi Yang,
On Mon 13 Jun 22, 09:26, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thanks for the patch!
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Paul
> ---
> drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
> index df1805cf0f95..437b3011ae1e 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "Failed to get IRQ\n");
> ret = -ENODEV;
> goto error_reserved_mem;
> }
> --
> 2.20.1.7.g153144c
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] drm: Remove unnecessary print function dev_err()
2022-06-24 15:00 ` Paul Kocialkowski
@ 2022-06-24 15:26 ` Paul Kocialkowski
0 siblings, 0 replies; 6+ messages in thread
From: Paul Kocialkowski @ 2022-06-24 15:26 UTC (permalink / raw)
To: Yang Li; +Cc: airlied, daniel, dri-devel, linux-kernel, Abaci Robot
[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]
Hi,
On Fri 24 Jun 22, 17:00, Paul Kocialkowski wrote:
> Hi Yang,
>
> On Mon 13 Jun 22, 09:26, Yang Li wrote:
> > The print function dev_err() is redundant because platform_get_irq()
> > already prints an error.
> >
> > Eliminate the follow coccicheck warning:
> > ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
> > because platform_get_irq() already prints an error
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Thanks for the patch!
>
> Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Pushed to drm-misc-next, thanks!
Paul
> > ---
> > drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
> > index df1805cf0f95..437b3011ae1e 100644
> > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> > @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0) {
> > - dev_err(dev, "Failed to get IRQ\n");
> > ret = -ENODEV;
> > goto error_reserved_mem;
> > }
> > --
> > 2.20.1.7.g153144c
> >
>
> --
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -next] drm: Remove unnecessary print function dev_err()
@ 2022-06-24 0:50 Yang Li
2022-06-26 3:46 ` Orson Zhai
0 siblings, 1 reply; 6+ messages in thread
From: Yang Li @ 2022-06-24 0:50 UTC (permalink / raw)
To: airlied
Cc: daniel, orsonzhai, baolin.wang7, zhang.lyra, dri-devel,
linux-kernel, Yang Li
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warning:
./drivers/gpu/drm/sprd/sprd_dpu.c:808:2-9: line 808 is redundant because platform_get_irq() already prints an error
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/sprd/sprd_dpu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
index 3664089b6983..de4848dc0d22 100644
--- a/drivers/gpu/drm/sprd/sprd_dpu.c
+++ b/drivers/gpu/drm/sprd/sprd_dpu.c
@@ -804,10 +804,8 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu,
}
ctx->irq = platform_get_irq(pdev, 0);
- if (ctx->irq < 0) {
- dev_err(dev, "failed to get dpu irq\n");
+ if (ctx->irq < 0)
return ctx->irq;
- }
/* disable and clear interrupts before register dpu IRQ. */
writel(0x00, ctx->base + REG_DPU_INT_EN);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] drm: Remove unnecessary print function dev_err()
2022-06-24 0:50 Yang Li
@ 2022-06-26 3:46 ` Orson Zhai
0 siblings, 0 replies; 6+ messages in thread
From: Orson Zhai @ 2022-06-26 3:46 UTC (permalink / raw)
To: Yang Li
Cc: airlied, Daniel Vetter, Baolin Wang, Lyra Zhang, dri-devel,
Linux Kernel Mailing List
On Fri, Jun 24, 2022 at 8:50 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/sprd/sprd_dpu.c:808:2-9: line 808 is redundant because platform_get_irq() already prints an error
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Orson Zhai <orsonzhai@gmail.com>
> ---
> drivers/gpu/drm/sprd/sprd_dpu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
> index 3664089b6983..de4848dc0d22 100644
> --- a/drivers/gpu/drm/sprd/sprd_dpu.c
> +++ b/drivers/gpu/drm/sprd/sprd_dpu.c
> @@ -804,10 +804,8 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu,
> }
>
> ctx->irq = platform_get_irq(pdev, 0);
> - if (ctx->irq < 0) {
> - dev_err(dev, "failed to get dpu irq\n");
> + if (ctx->irq < 0)
> return ctx->irq;
> - }
>
> /* disable and clear interrupts before register dpu IRQ. */
> writel(0x00, ctx->base + REG_DPU_INT_EN);
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -next] drm: Remove unnecessary print function dev_err()
@ 2022-07-07 1:47 Yang Li
0 siblings, 0 replies; 6+ messages in thread
From: Yang Li @ 2022-07-07 1:47 UTC (permalink / raw)
To: tomba; +Cc: daniel, airlied, dri-devel, linux-kernel, Yang Li
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warning:
./drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:817:2-9: line 817 is redundant because platform_get_irq() already prints an error
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
index ac869acf80ea..61a27dd7392e 100644
--- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
+++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
@@ -813,10 +813,8 @@ static int omap_dmm_probe(struct platform_device *dev)
}
omap_dmm->irq = platform_get_irq(dev, 0);
- if (omap_dmm->irq < 0) {
- dev_err(&dev->dev, "failed to get IRQ resource\n");
+ if (omap_dmm->irq < 0)
goto fail;
- }
omap_dmm->dev = &dev->dev;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-07 1:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13 1:26 [PATCH -next] drm: Remove unnecessary print function dev_err() Yang Li
2022-06-24 15:00 ` Paul Kocialkowski
2022-06-24 15:26 ` Paul Kocialkowski
2022-06-24 0:50 Yang Li
2022-06-26 3:46 ` Orson Zhai
2022-07-07 1:47 Yang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).