From: Herbert Xu <herbert@gondor.apana.org.au>
To: Pankaj Gupta <pankaj.gupta@nxp.com>
Cc: jarkko@kernel.org, a.fatoum@pengutronix.de, Jason@zx2c4.com,
jejb@linux.ibm.com, zohar@linux.ibm.com, dhowells@redhat.com,
sumit.garg@linaro.org, david@sigma-star.at, michael@walle.cc,
john.ernberg@actia.se, jmorris@namei.org, serge@hallyn.com,
davem@davemloft.net, j.luebbe@pengutronix.de,
ebiggers@kernel.org, richard@nod.at, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, sahil.malhotra@nxp.com,
kshitiz.varshney@nxp.com, horia.geanta@nxp.com, V.Sethi@nxp.com
Subject: Re: [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added to the tfm
Date: Tue, 6 Sep 2022 14:43:18 +0800 [thread overview]
Message-ID: <YxbsBiCrIQT/0xz6@gondor.apana.org.au> (raw)
In-Reply-To: <20220906065157.10662-3-pankaj.gupta@nxp.com>
On Tue, Sep 06, 2022 at 12:21:51PM +0530, Pankaj Gupta wrote:
> Consumer of the kernel crypto api, after allocating
> the transformation, sets this flag based on the basis
> of the type of key consumer has. This helps:
>
> - This helps to influence the core processing logic
> for the encapsulated algorithm.
> - This flag is set by the consumer after allocating
> the tfm and before calling the function crypto_xxx_setkey().
>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> ---
> include/linux/crypto.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/crypto.h b/include/linux/crypto.h
> index 2324ab6f1846..b4fa83ca87bd 100644
> --- a/include/linux/crypto.h
> +++ b/include/linux/crypto.h
> @@ -639,6 +639,8 @@ struct crypto_tfm {
>
> u32 crt_flags;
>
> + unsigned int is_hbk;
> +
We already have plenty of drivers with hardware keys in the tree.
Plesae explain why the current support is inadequate and you need
to do this.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-09-06 6:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 6:51 [RFC PATCH HBK: 0/8] HW BOUND KEY as TRUSTED KEY Pankaj Gupta
2022-09-06 6:51 ` [RFC PATCH HBK: 1/8] keys-trusted: new cmd line option added Pankaj Gupta
2022-09-06 13:01 ` Ben Boeckel
2022-09-07 7:22 ` [EXT] " Pankaj Gupta
2022-09-06 6:51 ` [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added to the tfm Pankaj Gupta
2022-09-06 6:43 ` Herbert Xu [this message]
2022-09-07 7:22 ` [EXT] " Pankaj Gupta
2022-09-07 7:26 ` Herbert Xu
2022-09-07 9:58 ` Pankaj Gupta
2022-09-07 10:10 ` Herbert Xu
2022-09-12 17:19 ` Varun Sethi
2022-09-13 2:05 ` Herbert Xu
2022-09-13 10:01 ` Varun Sethi
2022-09-13 10:28 ` Herbert Xu
2022-09-21 11:07 ` Varun Sethi
2022-09-06 6:51 ` [RFC PATCH HBK: 3/8] sk_cipher: checking for hw bound operation Pankaj Gupta
2022-09-06 6:51 ` [RFC PATCH HBK: 4/8] keys-trusted: re-factored caam based trusted key Pankaj Gupta
2022-09-06 6:51 ` [RFC PATCH HBK: 5/8] caam blob-gen: moving blob_priv to caam_drv_private Pankaj Gupta
2022-09-06 6:51 ` [RFC PATCH HBK: 6/8] KEYS: trusted: caam based black key Pankaj Gupta
2022-09-06 13:03 ` Ben Boeckel
2022-09-07 7:22 ` [EXT] " Pankaj Gupta
2022-09-06 6:51 ` [RFC PATCH HBK: 7/8] caam alg: symmetric key ciphers are updated Pankaj Gupta
2022-09-06 6:51 ` [RFC PATCH HBK: 8/8] dm-crypt: consumer-app setting the flag-is_hbk Pankaj Gupta
2022-09-06 7:12 ` [RFC PATCH HBK: 0/8] HW BOUND KEY as TRUSTED KEY Michael Walle
2022-09-07 7:22 ` [EXT] " Pankaj Gupta
2022-09-07 7:29 ` Michael Walle
2022-09-07 7:46 ` [EXT] " David Gstir
2022-09-07 8:11 ` Michael Walle
2022-09-07 9:57 ` Pankaj Gupta
2022-09-06 8:58 ` Jarkko Sakkinen
2022-09-07 7:22 ` [EXT] " Pankaj Gupta
2022-09-07 8:10 ` Jan Lübbe
2022-09-07 9:57 ` Pankaj Gupta
-- strict thread matches above, loose matches on Subject: below --
2022-09-05 14:36 Pankaj Gupta
2022-09-05 14:36 ` [RFC PATCH HBK: 2/8] hw-bound-key: flag-is_hbk added to the tfm Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxbsBiCrIQT/0xz6@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jason@zx2c4.com \
--cc=V.Sethi@nxp.com \
--cc=a.fatoum@pengutronix.de \
--cc=davem@davemloft.net \
--cc=david@sigma-star.at \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=horia.geanta@nxp.com \
--cc=j.luebbe@pengutronix.de \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=john.ernberg@actia.se \
--cc=keyrings@vger.kernel.org \
--cc=kshitiz.varshney@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=michael@walle.cc \
--cc=pankaj.gupta@nxp.com \
--cc=richard@nod.at \
--cc=sahil.malhotra@nxp.com \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).