From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Alessandro Zummo <a.zummo@towertech.it>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/8] rtc: isl12022: implement RTC_VL_READ ioctl
Date: Wed, 14 Jun 2023 15:16:14 +0300 [thread overview]
Message-ID: <ZImvjj34YILrNJU5@smile.fi.intel.com> (raw)
In-Reply-To: <20230613212651c8770218@mail.local>
On Tue, Jun 13, 2023 at 11:26:51PM +0200, Alexandre Belloni wrote:
> On 13/06/2023 18:20:56+0300, Andy Shevchenko wrote:
> > On Tue, Jun 13, 2023 at 03:00:07PM +0200, Rasmus Villemoes wrote:
...
> > > + ret = regmap_read(regmap, ISL12022_REG_SR, &val);
> > > + if (ret < 0)
> >
> > I always feel uneasy with ' < 0' — Does positive error makes sense?
> > Is it even possible? OTOH if the entire driver uses this idiom...
> > oh well, let's make it consistent.
>
> /**
> * regmap_read() - Read a value from a single register
> *
> * @map: Register map to read from
> * @reg: Register to be read from
> * @val: Pointer to store read value
> *
> * A value of zero will be returned on success, a negative errno will
> * be returned in error cases.
> */
I'm not sure what you meant by this. Yes, I know that there is no
possibility that regmap API returns positive value. Do you mean that
regmap API documentation is unclear?
> > > + return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-14 12:16 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 11:30 [PATCH 0/8] rtc: isl12022: battery backup voltage and clock support Rasmus Villemoes
2023-06-12 11:30 ` [PATCH 1/8] rtc: isl12022: remove wrong warning for low battery level Rasmus Villemoes
2023-06-12 11:30 ` [PATCH 2/8] dt-bindings: rtc: Move isil,isl12022 from trivial-rtc.yaml into own schema file Rasmus Villemoes
2023-06-12 12:26 ` Rob Herring
2023-06-12 12:36 ` Rasmus Villemoes
2023-06-12 13:54 ` Alexandre Belloni
2023-06-12 14:20 ` Rob Herring
2023-06-13 8:13 ` Rasmus Villemoes
2023-06-12 11:30 ` [PATCH 3/8] dt-bindings: rtc: isl12022: add bindings for battery alarm trip levels Rasmus Villemoes
2023-06-12 11:30 ` [PATCH 4/8] rtc: isl12022: add support for trip level DT bindings Rasmus Villemoes
2023-06-12 15:44 ` Andy Shevchenko
2023-06-12 18:10 ` kernel test robot
2023-06-12 18:58 ` kernel test robot
2023-06-12 11:30 ` [PATCH 5/8] rtc: isl12022: implement RTC_VL_READ and RTC_VL_CLR ioctls Rasmus Villemoes
2023-06-12 14:07 ` Alexandre Belloni
2023-06-13 7:27 ` Rasmus Villemoes
2023-06-12 15:48 ` Andy Shevchenko
2023-06-12 16:10 ` Alexandre Belloni
2023-06-13 7:53 ` Rasmus Villemoes
2023-06-13 9:00 ` Alexandre Belloni
2023-06-12 11:30 ` [PATCH 6/8] rtc: isl12022: trigger battery level detection during probe Rasmus Villemoes
2023-06-12 12:30 ` Rasmus Villemoes
2023-06-12 14:17 ` Alexandre Belloni
2023-06-13 7:51 ` Rasmus Villemoes
2023-06-12 14:15 ` Alexandre Belloni
2023-06-13 7:44 ` Rasmus Villemoes
2023-06-13 8:58 ` Alexandre Belloni
2023-06-12 11:30 ` [PATCH 7/8] dt-bindings: rtc: isl12022: add #clock-cells property Rasmus Villemoes
2023-06-13 7:41 ` Krzysztof Kozlowski
2023-06-12 11:30 ` [PATCH 8/8] rtc: isl12022: implement support for the #clock-cells DT property Rasmus Villemoes
2023-06-13 13:00 ` [PATCH v2 0/8] rtc: isl12022: battery backup voltage and clock support Rasmus Villemoes
2023-06-13 13:00 ` [PATCH v2 1/8] rtc: isl12022: remove wrong warning for low battery level Rasmus Villemoes
2023-06-13 13:00 ` [PATCH v2 2/8] dt-bindings: rtc: Move isil,isl12022 from trivial-rtc.yaml into own schema file Rasmus Villemoes
2023-06-13 19:06 ` Krzysztof Kozlowski
2023-06-13 13:00 ` [PATCH v2 3/8] dt-bindings: rtc: isl12022: add bindings for battery alarm trip levels Rasmus Villemoes
2023-06-13 19:09 ` Krzysztof Kozlowski
2023-06-13 19:51 ` Rasmus Villemoes
2023-06-13 21:37 ` Krzysztof Kozlowski
2023-06-13 13:00 ` [PATCH v2 4/8] rtc: isl12022: add support for trip level DT bindings Rasmus Villemoes
2023-06-13 13:00 ` [PATCH v2 5/8] rtc: isl12022: implement RTC_VL_READ ioctl Rasmus Villemoes
2023-06-13 15:20 ` Andy Shevchenko
2023-06-13 21:26 ` Alexandre Belloni
2023-06-14 12:16 ` Andy Shevchenko [this message]
2023-06-14 13:50 ` Alexandre Belloni
2023-06-14 15:13 ` Andy Shevchenko
2023-06-15 10:53 ` Rasmus Villemoes
2023-06-15 10:58 ` Andy Shevchenko
2023-06-13 13:00 ` [PATCH v2 6/8] rtc: isl12022: trigger battery level detection during probe Rasmus Villemoes
2023-06-13 13:00 ` [PATCH v2 7/8] dt-bindings: rtc: isl12022: add #clock-cells property Rasmus Villemoes
2023-06-13 19:10 ` Krzysztof Kozlowski
2023-06-13 20:25 ` Rasmus Villemoes
2023-06-13 21:38 ` Krzysztof Kozlowski
2023-06-13 13:00 ` [PATCH v2 8/8] rtc: isl12022: implement support for the #clock-cells DT property Rasmus Villemoes
2023-06-13 15:25 ` Andy Shevchenko
2023-06-14 10:51 ` Rasmus Villemoes
2023-06-14 12:13 ` Andy Shevchenko
2023-06-13 19:10 ` kernel test robot
2023-06-14 5:27 ` kernel test robot
2023-06-13 15:26 ` [PATCH v2 0/8] rtc: isl12022: battery backup voltage and clock support Andy Shevchenko
2023-06-13 19:06 ` Krzysztof Kozlowski
2023-06-15 11:03 ` Rasmus Villemoes
2023-06-15 10:58 ` [PATCH v3 " Rasmus Villemoes
2023-06-15 10:58 ` [PATCH v3 1/8] rtc: isl12022: remove wrong warning for low battery level Rasmus Villemoes
2023-06-15 10:58 ` [PATCH v3 2/8] dt-bindings: rtc: Move isil,isl12022 from trivial-rtc.yaml into own schema file Rasmus Villemoes
2023-06-15 10:58 ` [PATCH v3 3/8] dt-bindings: rtc: isl12022: add bindings for battery alarm trip levels Rasmus Villemoes
2023-06-17 8:12 ` Krzysztof Kozlowski
2023-06-15 10:58 ` [PATCH v3 4/8] rtc: isl12022: add support for trip level DT binding Rasmus Villemoes
2023-06-15 11:11 ` Andy Shevchenko
2023-06-19 7:27 ` Rasmus Villemoes
2023-06-15 10:58 ` [PATCH v3 5/8] rtc: isl12022: implement RTC_VL_READ ioctl Rasmus Villemoes
2023-06-15 10:58 ` [PATCH v3 6/8] rtc: isl12022: trigger battery level detection during probe Rasmus Villemoes
2023-06-15 10:58 ` [PATCH v3 7/8] dt-bindings: rtc: isl12022: add #clock-cells property Rasmus Villemoes
2023-06-17 8:13 ` Krzysztof Kozlowski
2023-06-15 10:58 ` [PATCH v3 8/8] rtc: isl12022: implement support for the #clock-cells DT property Rasmus Villemoes
2023-07-28 14:31 ` [PATCH v3 0/8] rtc: isl12022: battery backup voltage and clock support Rasmus Villemoes
2023-08-03 6:45 ` Rasmus Villemoes
2023-08-09 12:28 ` Rasmus Villemoes
2023-08-15 23:28 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZImvjj34YILrNJU5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).