* [PATCH] kexec: use list_for_each_entry_safe in kimage_free_page_list
@ 2015-12-08 16:08 Geliang Tang
2015-12-11 2:55 ` Baoquan He
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2015-12-08 16:08 UTC (permalink / raw)
To: Andrew Morton, Dave Young, Vivek Goyal, Baoquan He
Cc: Geliang Tang, linux-kernel
Use list_for_each_entry_safe() instead of list_for_each_safe() to
simplify the code.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
kernel/kexec_core.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 11b64a6..f3951c7 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -310,12 +310,9 @@ static void kimage_free_pages(struct page *page)
void kimage_free_page_list(struct list_head *list)
{
- struct list_head *pos, *next;
+ struct page *page, *next;
- list_for_each_safe(pos, next, list) {
- struct page *page;
-
- page = list_entry(pos, struct page, lru);
+ list_for_each_entry_safe(page, next, list, lru) {
list_del(&page->lru);
kimage_free_pages(page);
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kexec: use list_for_each_entry_safe in kimage_free_page_list
2015-12-08 16:08 [PATCH] kexec: use list_for_each_entry_safe in kimage_free_page_list Geliang Tang
@ 2015-12-11 2:55 ` Baoquan He
0 siblings, 0 replies; 2+ messages in thread
From: Baoquan He @ 2015-12-11 2:55 UTC (permalink / raw)
To: Geliang Tang; +Cc: Andrew Morton, Dave Young, Vivek Goyal, linux-kernel
On 12/09/15 at 12:08am, Geliang Tang wrote:
> Use list_for_each_entry_safe() instead of list_for_each_safe() to
> simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> kernel/kexec_core.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 11b64a6..f3951c7 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -310,12 +310,9 @@ static void kimage_free_pages(struct page *page)
>
> void kimage_free_page_list(struct list_head *list)
> {
> - struct list_head *pos, *next;
> + struct page *page, *next;
>
> - list_for_each_safe(pos, next, list) {
> - struct page *page;
> -
> - page = list_entry(pos, struct page, lru);
> + list_for_each_entry_safe(page, next, list, lru) {
A small improvement, seems better. Ack it.
Please also send kexec mailing list if you have kexec related patchs so
that more people are attracted:
kexec@lists.infradead.org
Acked-by: Baoquan He <bhe@redhat.com>
Thanks
Baoquan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-11 2:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-08 16:08 [PATCH] kexec: use list_for_each_entry_safe in kimage_free_page_list Geliang Tang
2015-12-11 2:55 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).