From: Julian Wiedmann <jwi@linux.ibm.com>
To: "Clément Léger" <clement.leger@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com, "Andrew Lunn" <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 1/6] net: ocelot: add support to get port mac from device-tree
Date: Mon, 15 Nov 2021 13:19:49 +0200 [thread overview]
Message-ID: <a12f593a-a9e4-44bf-1740-92303ceb1dc3@linux.ibm.com> (raw)
In-Reply-To: <20211103091943.3878621-2-clement.leger@bootlin.com>
On 03.11.21 11:19, Clément Léger wrote:
> Add support to get mac from device-tree using of_get_mac_address.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
> drivers/net/ethernet/mscc/ocelot_net.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/ethernet/mscc/ocelot_net.c
> index eaeba60b1bba..d76def435b23 100644
> --- a/drivers/net/ethernet/mscc/ocelot_net.c
> +++ b/drivers/net/ethernet/mscc/ocelot_net.c
> @@ -1704,7 +1704,10 @@ int ocelot_probe_port(struct ocelot *ocelot, int port, struct regmap *target,
> NETIF_F_HW_TC;
> dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_HW_TC;
>
> - eth_hw_addr_gen(dev, ocelot->base_mac, port);
> + err = of_get_mac_address(portnp, dev->dev_addr);
of_get_ethdev_address() maybe, so that this gets routed through Jakub's fancy
new eth_hw_addr_set() infrastructure?
> + if (err)
> + eth_hw_addr_gen(dev, ocelot->base_mac, port);
> +
> ocelot_mact_learn(ocelot, PGID_CPU, dev->dev_addr,
> OCELOT_VLAN_UNAWARE_PVID, ENTRYTYPE_LOCKED);
>
>
next prev parent reply other threads:[~2021-11-15 11:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 9:19 [PATCH v2 0/6] Add FDMA support on ocelot switch driver Clément Léger
2021-11-03 9:19 ` [PATCH v2 1/6] net: ocelot: add support to get port mac from device-tree Clément Léger
2021-11-03 10:26 ` Vladimir Oltean
2021-11-15 11:19 ` Julian Wiedmann [this message]
2021-11-15 11:24 ` Clément Léger
2021-11-03 9:19 ` [PATCH v2 2/6] dt-bindings: net: convert mscc,vsc7514-switch bindings to yaml Clément Léger
2021-11-03 10:45 ` Vladimir Oltean
2021-11-08 11:13 ` Clément Léger
2021-11-12 20:06 ` Rob Herring
2021-11-03 9:19 ` [PATCH v2 3/6] net: ocelot: pre-compute injection frame header content Clément Léger
2021-11-03 12:38 ` Vladimir Oltean
2021-11-03 13:53 ` Clément Léger
2021-11-15 10:13 ` Clément Léger
2021-11-15 10:51 ` Vladimir Oltean
2021-11-15 10:58 ` Clément Léger
2021-11-15 14:08 ` Jakub Kicinski
2021-11-15 14:06 ` Clément Léger
2021-11-15 14:31 ` Vladimir Oltean
2021-11-15 16:03 ` Clément Léger
2021-11-03 9:19 ` [PATCH v2 4/6] net: ocelot: add support for ndo_change_mtu Clément Léger
2021-11-03 12:40 ` Vladimir Oltean
2021-11-03 13:07 ` Clément Léger
2021-11-03 9:19 ` [PATCH v2 5/6] net: ocelot: add FDMA support Clément Léger
2021-11-03 11:25 ` Denis Kirjanov
2021-11-03 12:31 ` Vladimir Oltean
2021-11-03 14:22 ` Clément Léger
2021-11-03 9:19 ` [PATCH v2 6/6] net: ocelot: add jumbo frame support for FDMA Clément Léger
2021-11-03 12:43 ` Vladimir Oltean
2021-11-03 14:30 ` Clément Léger
2021-11-03 10:46 ` [PATCH v2 0/6] Add FDMA support on ocelot switch driver Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a12f593a-a9e4-44bf-1740-92303ceb1dc3@linux.ibm.com \
--to=jwi@linux.ibm.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).