* [PATCH] bluetooth: btusb: Add device ID for RTL8822BE
@ 2017-11-11 17:43 Larry Finger
2017-11-11 18:51 ` Marcel Holtmann
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Larry Finger @ 2017-11-11 17:43 UTC (permalink / raw)
To: Marcel Holtmann, Gustavo Padovan, Johan Hedberg
Cc: linux-kernel, linux-bluetooth, Larry Finger, Hon Weng Chong
The Asus Z370-I contains a Realtek RTL8822BE device with an associated
BT chip using a USB ID of 0b05:185c. This device is added to the driver.
Signed-off-by: Hon Weng Chong <honwchong@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/bluetooth/btusb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 7a5c06aaa181..c265ef63cab7 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -373,6 +373,9 @@ static const struct usb_device_id blacklist_table[] = {
{ USB_DEVICE(0x13d3, 0x3461), .driver_info = BTUSB_REALTEK },
{ USB_DEVICE(0x13d3, 0x3462), .driver_info = BTUSB_REALTEK },
+ /* Additional Realtek 8822BE Bluetooth devices */
+ { USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
+
/* Silicon Wave based devices */
{ USB_DEVICE(0x0c10, 0x0000), .driver_info = BTUSB_SWAVE },
--
2.15.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE
2017-11-11 17:43 [PATCH] bluetooth: btusb: Add device ID for RTL8822BE Larry Finger
@ 2017-11-11 18:51 ` Marcel Holtmann
2017-11-11 19:10 ` Larry Finger
2017-11-12 13:45 ` Bjørn Mork
2017-11-14 9:22 ` kbuild test robot
2017-11-14 9:30 ` kbuild test robot
2 siblings, 2 replies; 7+ messages in thread
From: Marcel Holtmann @ 2017-11-11 18:51 UTC (permalink / raw)
To: Larry Finger
Cc: Gustavo F. Padovan, Johan Hedberg, Linux Kernel Mailing List,
linux-bluetooth, Hon Weng Chong
Hi Larry,
> The Asus Z370-I contains a Realtek RTL8822BE device with an associated
> BT chip using a USB ID of 0b05:185c. This device is added to the driver.
>
> Signed-off-by: Hon Weng Chong <honwchong@gmail.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/bluetooth/btusb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 7a5c06aaa181..c265ef63cab7 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -373,6 +373,9 @@ static const struct usb_device_id blacklist_table[] = {
> { USB_DEVICE(0x13d3, 0x3461), .driver_info = BTUSB_REALTEK },
> { USB_DEVICE(0x13d3, 0x3462), .driver_info = BTUSB_REALTEK },
>
> + /* Additional Realtek 8822BE Bluetooth devices */
> + { USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
> +
I prefer to have /sys/kernel/debug/usb/devices for the device included in the commit message.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE
2017-11-11 18:51 ` Marcel Holtmann
@ 2017-11-11 19:10 ` Larry Finger
2017-11-14 23:40 ` Hon Weng Chong
2017-11-12 13:45 ` Bjørn Mork
1 sibling, 1 reply; 7+ messages in thread
From: Larry Finger @ 2017-11-11 19:10 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Gustavo F. Padovan, Johan Hedberg, Linux Kernel Mailing List,
linux-bluetooth, Hon Weng Chong
On 11/11/2017 12:51 PM, Marcel Holtmann wrote:
> Hi Larry,
>
>> The Asus Z370-I contains a Realtek RTL8822BE device with an associated
>> BT chip using a USB ID of 0b05:185c. This device is added to the driver.
>>
>> Signed-off-by: Hon Weng Chong <honwchong@gmail.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>> drivers/bluetooth/btusb.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index 7a5c06aaa181..c265ef63cab7 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -373,6 +373,9 @@ static const struct usb_device_id blacklist_table[] = {
>> { USB_DEVICE(0x13d3, 0x3461), .driver_info = BTUSB_REALTEK },
>> { USB_DEVICE(0x13d3, 0x3462), .driver_info = BTUSB_REALTEK },
>>
>> + /* Additional Realtek 8822BE Bluetooth devices */
>> + { USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
>> +
>
> I prefer to have /sys/kernel/debug/usb/devices for the device included in the commit message.
>
> Regards
>
> Marcel
>
>
Hon,
Please provide the data.
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE
2017-11-11 18:51 ` Marcel Holtmann
2017-11-11 19:10 ` Larry Finger
@ 2017-11-12 13:45 ` Bjørn Mork
1 sibling, 0 replies; 7+ messages in thread
From: Bjørn Mork @ 2017-11-12 13:45 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Larry Finger, Gustavo F. Padovan, Johan Hedberg,
Linux Kernel Mailing List, linux-bluetooth, Hon Weng Chong
Marcel Holtmann <marcel@holtmann.org> writes:
>> + { USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
>> +
>
> I prefer to have /sys/kernel/debug/usb/devices for the device included in the commit message.
...and 0x1185c is a typp
Bjørn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE
2017-11-11 17:43 [PATCH] bluetooth: btusb: Add device ID for RTL8822BE Larry Finger
2017-11-11 18:51 ` Marcel Holtmann
@ 2017-11-14 9:22 ` kbuild test robot
2017-11-14 9:30 ` kbuild test robot
2 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2017-11-14 9:22 UTC (permalink / raw)
To: Larry Finger
Cc: kbuild-all, Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
linux-kernel, linux-bluetooth, Larry Finger, Hon Weng Chong
[-- Attachment #1: Type: text/plain, Size: 12102 bytes --]
Hi Larry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v4.14 next-20171114]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Larry-Finger/bluetooth-btusb-Add-device-ID-for-RTL8822BE/20171114-152910
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All warnings (new ones prefixed by >>):
>> drivers/bluetooth/btusb.c:373:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
{ USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
^
vim +373 drivers/bluetooth/btusb.c
181
182 static const struct usb_device_id blacklist_table[] = {
183 /* CSR BlueCore devices */
184 { USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
185
186 /* Broadcom BCM2033 without firmware */
187 { USB_DEVICE(0x0a5c, 0x2033), .driver_info = BTUSB_IGNORE },
188
189 /* Broadcom BCM2045 devices */
190 { USB_DEVICE(0x0a5c, 0x2045), .driver_info = BTUSB_BCM2045 },
191
192 /* Atheros 3011 with sflash firmware */
193 { USB_DEVICE(0x0489, 0xe027), .driver_info = BTUSB_IGNORE },
194 { USB_DEVICE(0x0489, 0xe03d), .driver_info = BTUSB_IGNORE },
195 { USB_DEVICE(0x04f2, 0xaff1), .driver_info = BTUSB_IGNORE },
196 { USB_DEVICE(0x0930, 0x0215), .driver_info = BTUSB_IGNORE },
197 { USB_DEVICE(0x0cf3, 0x3002), .driver_info = BTUSB_IGNORE },
198 { USB_DEVICE(0x0cf3, 0xe019), .driver_info = BTUSB_IGNORE },
199 { USB_DEVICE(0x13d3, 0x3304), .driver_info = BTUSB_IGNORE },
200
201 /* Atheros AR9285 Malbec with sflash firmware */
202 { USB_DEVICE(0x03f0, 0x311d), .driver_info = BTUSB_IGNORE },
203
204 /* Atheros 3012 with sflash firmware */
205 { USB_DEVICE(0x0489, 0xe04d), .driver_info = BTUSB_ATH3012 },
206 { USB_DEVICE(0x0489, 0xe04e), .driver_info = BTUSB_ATH3012 },
207 { USB_DEVICE(0x0489, 0xe056), .driver_info = BTUSB_ATH3012 },
208 { USB_DEVICE(0x0489, 0xe057), .driver_info = BTUSB_ATH3012 },
209 { USB_DEVICE(0x0489, 0xe05f), .driver_info = BTUSB_ATH3012 },
210 { USB_DEVICE(0x0489, 0xe076), .driver_info = BTUSB_ATH3012 },
211 { USB_DEVICE(0x0489, 0xe078), .driver_info = BTUSB_ATH3012 },
212 { USB_DEVICE(0x0489, 0xe095), .driver_info = BTUSB_ATH3012 },
213 { USB_DEVICE(0x04c5, 0x1330), .driver_info = BTUSB_ATH3012 },
214 { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
215 { USB_DEVICE(0x04ca, 0x3005), .driver_info = BTUSB_ATH3012 },
216 { USB_DEVICE(0x04ca, 0x3006), .driver_info = BTUSB_ATH3012 },
217 { USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
218 { USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
219 { USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
220 { USB_DEVICE(0x04ca, 0x300d), .driver_info = BTUSB_ATH3012 },
221 { USB_DEVICE(0x04ca, 0x300f), .driver_info = BTUSB_ATH3012 },
222 { USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
223 { USB_DEVICE(0x04ca, 0x3014), .driver_info = BTUSB_ATH3012 },
224 { USB_DEVICE(0x04ca, 0x3018), .driver_info = BTUSB_ATH3012 },
225 { USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
226 { USB_DEVICE(0x0930, 0x021c), .driver_info = BTUSB_ATH3012 },
227 { USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
228 { USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },
229 { USB_DEVICE(0x0b05, 0x17d0), .driver_info = BTUSB_ATH3012 },
230 { USB_DEVICE(0x0cf3, 0x0036), .driver_info = BTUSB_ATH3012 },
231 { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
232 { USB_DEVICE(0x0cf3, 0x3008), .driver_info = BTUSB_ATH3012 },
233 { USB_DEVICE(0x0cf3, 0x311d), .driver_info = BTUSB_ATH3012 },
234 { USB_DEVICE(0x0cf3, 0x311e), .driver_info = BTUSB_ATH3012 },
235 { USB_DEVICE(0x0cf3, 0x311f), .driver_info = BTUSB_ATH3012 },
236 { USB_DEVICE(0x0cf3, 0x3121), .driver_info = BTUSB_ATH3012 },
237 { USB_DEVICE(0x0cf3, 0x817a), .driver_info = BTUSB_ATH3012 },
238 { USB_DEVICE(0x0cf3, 0x817b), .driver_info = BTUSB_ATH3012 },
239 { USB_DEVICE(0x0cf3, 0xe003), .driver_info = BTUSB_ATH3012 },
240 { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },
241 { USB_DEVICE(0x0cf3, 0xe005), .driver_info = BTUSB_ATH3012 },
242 { USB_DEVICE(0x0cf3, 0xe006), .driver_info = BTUSB_ATH3012 },
243 { USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
244 { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
245 { USB_DEVICE(0x13d3, 0x3393), .driver_info = BTUSB_ATH3012 },
246 { USB_DEVICE(0x13d3, 0x3395), .driver_info = BTUSB_ATH3012 },
247 { USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
248 { USB_DEVICE(0x13d3, 0x3408), .driver_info = BTUSB_ATH3012 },
249 { USB_DEVICE(0x13d3, 0x3423), .driver_info = BTUSB_ATH3012 },
250 { USB_DEVICE(0x13d3, 0x3432), .driver_info = BTUSB_ATH3012 },
251 { USB_DEVICE(0x13d3, 0x3472), .driver_info = BTUSB_ATH3012 },
252 { USB_DEVICE(0x13d3, 0x3474), .driver_info = BTUSB_ATH3012 },
253 { USB_DEVICE(0x13d3, 0x3487), .driver_info = BTUSB_ATH3012 },
254 { USB_DEVICE(0x13d3, 0x3490), .driver_info = BTUSB_ATH3012 },
255
256 /* Atheros AR5BBU12 with sflash firmware */
257 { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
258
259 /* Atheros AR5BBU12 with sflash firmware */
260 { USB_DEVICE(0x0489, 0xe036), .driver_info = BTUSB_ATH3012 },
261 { USB_DEVICE(0x0489, 0xe03c), .driver_info = BTUSB_ATH3012 },
262
263 /* QCA ROME chipset */
264 { USB_DEVICE(0x0cf3, 0xe007), .driver_info = BTUSB_QCA_ROME },
265 { USB_DEVICE(0x0cf3, 0xe009), .driver_info = BTUSB_QCA_ROME },
266 { USB_DEVICE(0x0cf3, 0xe300), .driver_info = BTUSB_QCA_ROME },
267 { USB_DEVICE(0x0cf3, 0xe301), .driver_info = BTUSB_QCA_ROME },
268 { USB_DEVICE(0x0cf3, 0xe360), .driver_info = BTUSB_QCA_ROME },
269 { USB_DEVICE(0x0489, 0xe092), .driver_info = BTUSB_QCA_ROME },
270 { USB_DEVICE(0x0489, 0xe09f), .driver_info = BTUSB_QCA_ROME },
271 { USB_DEVICE(0x0489, 0xe0a2), .driver_info = BTUSB_QCA_ROME },
272 { USB_DEVICE(0x04ca, 0x3011), .driver_info = BTUSB_QCA_ROME },
273 { USB_DEVICE(0x04ca, 0x3016), .driver_info = BTUSB_QCA_ROME },
274
275 /* Broadcom BCM2035 */
276 { USB_DEVICE(0x0a5c, 0x2009), .driver_info = BTUSB_BCM92035 },
277 { USB_DEVICE(0x0a5c, 0x200a), .driver_info = BTUSB_WRONG_SCO_MTU },
278 { USB_DEVICE(0x0a5c, 0x2035), .driver_info = BTUSB_WRONG_SCO_MTU },
279
280 /* Broadcom BCM2045 */
281 { USB_DEVICE(0x0a5c, 0x2039), .driver_info = BTUSB_WRONG_SCO_MTU },
282 { USB_DEVICE(0x0a5c, 0x2101), .driver_info = BTUSB_WRONG_SCO_MTU },
283
284 /* IBM/Lenovo ThinkPad with Broadcom chip */
285 { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
286 { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
287
288 /* HP laptop with Broadcom chip */
289 { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
290
291 /* Dell laptop with Broadcom chip */
292 { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_WRONG_SCO_MTU },
293
294 /* Dell Wireless 370 and 410 devices */
295 { USB_DEVICE(0x413c, 0x8152), .driver_info = BTUSB_WRONG_SCO_MTU },
296 { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_WRONG_SCO_MTU },
297
298 /* Belkin F8T012 and F8T013 devices */
299 { USB_DEVICE(0x050d, 0x0012), .driver_info = BTUSB_WRONG_SCO_MTU },
300 { USB_DEVICE(0x050d, 0x0013), .driver_info = BTUSB_WRONG_SCO_MTU },
301
302 /* Asus WL-BTD202 device */
303 { USB_DEVICE(0x0b05, 0x1715), .driver_info = BTUSB_WRONG_SCO_MTU },
304
305 /* Kensington Bluetooth USB adapter */
306 { USB_DEVICE(0x047d, 0x105e), .driver_info = BTUSB_WRONG_SCO_MTU },
307
308 /* RTX Telecom based adapters with buggy SCO support */
309 { USB_DEVICE(0x0400, 0x0807), .driver_info = BTUSB_BROKEN_ISOC },
310 { USB_DEVICE(0x0400, 0x080a), .driver_info = BTUSB_BROKEN_ISOC },
311
312 /* CONWISE Technology based adapters with buggy SCO support */
313 { USB_DEVICE(0x0e5e, 0x6622),
314 .driver_info = BTUSB_BROKEN_ISOC | BTUSB_CW6622},
315
316 /* Roper Class 1 Bluetooth Dongle (Silicon Wave based) */
317 { USB_DEVICE(0x1310, 0x0001), .driver_info = BTUSB_SWAVE },
318
319 /* Digianswer devices */
320 { USB_DEVICE(0x08fd, 0x0001), .driver_info = BTUSB_DIGIANSWER },
321 { USB_DEVICE(0x08fd, 0x0002), .driver_info = BTUSB_IGNORE },
322
323 /* CSR BlueCore Bluetooth Sniffer */
324 { USB_DEVICE(0x0a12, 0x0002),
325 .driver_info = BTUSB_SNIFFER | BTUSB_BROKEN_ISOC },
326
327 /* Frontline ComProbe Bluetooth Sniffer */
328 { USB_DEVICE(0x16d3, 0x0002),
329 .driver_info = BTUSB_SNIFFER | BTUSB_BROKEN_ISOC },
330
331 /* Marvell Bluetooth devices */
332 { USB_DEVICE(0x1286, 0x2044), .driver_info = BTUSB_MARVELL },
333 { USB_DEVICE(0x1286, 0x2046), .driver_info = BTUSB_MARVELL },
334 { USB_DEVICE(0x1286, 0x204e), .driver_info = BTUSB_MARVELL },
335
336 /* Intel Bluetooth devices */
337 { USB_DEVICE(0x8087, 0x0025), .driver_info = BTUSB_INTEL_NEW },
338 { USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
339 { USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL },
340 { USB_DEVICE(0x8087, 0x0a2a), .driver_info = BTUSB_INTEL },
341 { USB_DEVICE(0x8087, 0x0a2b), .driver_info = BTUSB_INTEL_NEW },
342 { USB_DEVICE(0x8087, 0x0aa7), .driver_info = BTUSB_INTEL },
343 { USB_DEVICE(0x8087, 0x0aaa), .driver_info = BTUSB_INTEL_NEW },
344
345 /* Other Intel Bluetooth devices */
346 { USB_VENDOR_AND_INTERFACE_INFO(0x8087, 0xe0, 0x01, 0x01),
347 .driver_info = BTUSB_IGNORE },
348
349 /* Realtek Bluetooth devices */
350 { USB_VENDOR_AND_INTERFACE_INFO(0x0bda, 0xe0, 0x01, 0x01),
351 .driver_info = BTUSB_REALTEK },
352
353 /* Additional Realtek 8723AE Bluetooth devices */
354 { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
355 { USB_DEVICE(0x13d3, 0x3394), .driver_info = BTUSB_REALTEK },
356
357 /* Additional Realtek 8723BE Bluetooth devices */
358 { USB_DEVICE(0x0489, 0xe085), .driver_info = BTUSB_REALTEK },
359 { USB_DEVICE(0x0489, 0xe08b), .driver_info = BTUSB_REALTEK },
360 { USB_DEVICE(0x13d3, 0x3410), .driver_info = BTUSB_REALTEK },
361 { USB_DEVICE(0x13d3, 0x3416), .driver_info = BTUSB_REALTEK },
362 { USB_DEVICE(0x13d3, 0x3459), .driver_info = BTUSB_REALTEK },
363 { USB_DEVICE(0x13d3, 0x3494), .driver_info = BTUSB_REALTEK },
364
365 /* Additional Realtek 8821AE Bluetooth devices */
366 { USB_DEVICE(0x0b05, 0x17dc), .driver_info = BTUSB_REALTEK },
367 { USB_DEVICE(0x13d3, 0x3414), .driver_info = BTUSB_REALTEK },
368 { USB_DEVICE(0x13d3, 0x3458), .driver_info = BTUSB_REALTEK },
369 { USB_DEVICE(0x13d3, 0x3461), .driver_info = BTUSB_REALTEK },
370 { USB_DEVICE(0x13d3, 0x3462), .driver_info = BTUSB_REALTEK },
371
372 /* Additional Realtek 8822BE Bluetooth devices */
> 373 { USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
374
375 /* Silicon Wave based devices */
376 { USB_DEVICE(0x0c10, 0x0000), .driver_info = BTUSB_SWAVE },
377
378 { } /* Terminating entry */
379 };
380
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51688 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE
2017-11-11 17:43 [PATCH] bluetooth: btusb: Add device ID for RTL8822BE Larry Finger
2017-11-11 18:51 ` Marcel Holtmann
2017-11-14 9:22 ` kbuild test robot
@ 2017-11-14 9:30 ` kbuild test robot
2 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2017-11-14 9:30 UTC (permalink / raw)
To: Larry Finger
Cc: kbuild-all, Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
linux-kernel, linux-bluetooth, Larry Finger, Hon Weng Chong
[-- Attachment #1: Type: text/plain, Size: 12544 bytes --]
Hi Larry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v4.14 next-20171114]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Larry-Finger/bluetooth-btusb-Add-device-ID-for-RTL8822BE/20171114-152910
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: i386-randconfig-x002-201746 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from drivers/bluetooth/btusb.c:25:0:
>> include/linux/usb.h:927:15: warning: large integer implicitly truncated to unsigned type [-Woverflow]
.idProduct = (prod)
^
>> drivers/bluetooth/btusb.c:373:4: note: in expansion of macro 'USB_DEVICE'
{ USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
^~~~~~~~~~
--
In file included from drivers//bluetooth/btusb.c:25:0:
>> include/linux/usb.h:927:15: warning: large integer implicitly truncated to unsigned type [-Woverflow]
.idProduct = (prod)
^
drivers//bluetooth/btusb.c:373:4: note: in expansion of macro 'USB_DEVICE'
{ USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
^~~~~~~~~~
vim +/USB_DEVICE +373 drivers/bluetooth/btusb.c
181
182 static const struct usb_device_id blacklist_table[] = {
183 /* CSR BlueCore devices */
184 { USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
185
186 /* Broadcom BCM2033 without firmware */
187 { USB_DEVICE(0x0a5c, 0x2033), .driver_info = BTUSB_IGNORE },
188
189 /* Broadcom BCM2045 devices */
190 { USB_DEVICE(0x0a5c, 0x2045), .driver_info = BTUSB_BCM2045 },
191
192 /* Atheros 3011 with sflash firmware */
193 { USB_DEVICE(0x0489, 0xe027), .driver_info = BTUSB_IGNORE },
194 { USB_DEVICE(0x0489, 0xe03d), .driver_info = BTUSB_IGNORE },
195 { USB_DEVICE(0x04f2, 0xaff1), .driver_info = BTUSB_IGNORE },
196 { USB_DEVICE(0x0930, 0x0215), .driver_info = BTUSB_IGNORE },
197 { USB_DEVICE(0x0cf3, 0x3002), .driver_info = BTUSB_IGNORE },
198 { USB_DEVICE(0x0cf3, 0xe019), .driver_info = BTUSB_IGNORE },
199 { USB_DEVICE(0x13d3, 0x3304), .driver_info = BTUSB_IGNORE },
200
201 /* Atheros AR9285 Malbec with sflash firmware */
202 { USB_DEVICE(0x03f0, 0x311d), .driver_info = BTUSB_IGNORE },
203
204 /* Atheros 3012 with sflash firmware */
205 { USB_DEVICE(0x0489, 0xe04d), .driver_info = BTUSB_ATH3012 },
206 { USB_DEVICE(0x0489, 0xe04e), .driver_info = BTUSB_ATH3012 },
207 { USB_DEVICE(0x0489, 0xe056), .driver_info = BTUSB_ATH3012 },
208 { USB_DEVICE(0x0489, 0xe057), .driver_info = BTUSB_ATH3012 },
209 { USB_DEVICE(0x0489, 0xe05f), .driver_info = BTUSB_ATH3012 },
210 { USB_DEVICE(0x0489, 0xe076), .driver_info = BTUSB_ATH3012 },
211 { USB_DEVICE(0x0489, 0xe078), .driver_info = BTUSB_ATH3012 },
212 { USB_DEVICE(0x0489, 0xe095), .driver_info = BTUSB_ATH3012 },
213 { USB_DEVICE(0x04c5, 0x1330), .driver_info = BTUSB_ATH3012 },
214 { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
215 { USB_DEVICE(0x04ca, 0x3005), .driver_info = BTUSB_ATH3012 },
216 { USB_DEVICE(0x04ca, 0x3006), .driver_info = BTUSB_ATH3012 },
217 { USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
218 { USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
219 { USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
220 { USB_DEVICE(0x04ca, 0x300d), .driver_info = BTUSB_ATH3012 },
221 { USB_DEVICE(0x04ca, 0x300f), .driver_info = BTUSB_ATH3012 },
222 { USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
223 { USB_DEVICE(0x04ca, 0x3014), .driver_info = BTUSB_ATH3012 },
224 { USB_DEVICE(0x04ca, 0x3018), .driver_info = BTUSB_ATH3012 },
225 { USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
226 { USB_DEVICE(0x0930, 0x021c), .driver_info = BTUSB_ATH3012 },
227 { USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
228 { USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },
229 { USB_DEVICE(0x0b05, 0x17d0), .driver_info = BTUSB_ATH3012 },
230 { USB_DEVICE(0x0cf3, 0x0036), .driver_info = BTUSB_ATH3012 },
231 { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
232 { USB_DEVICE(0x0cf3, 0x3008), .driver_info = BTUSB_ATH3012 },
233 { USB_DEVICE(0x0cf3, 0x311d), .driver_info = BTUSB_ATH3012 },
234 { USB_DEVICE(0x0cf3, 0x311e), .driver_info = BTUSB_ATH3012 },
235 { USB_DEVICE(0x0cf3, 0x311f), .driver_info = BTUSB_ATH3012 },
236 { USB_DEVICE(0x0cf3, 0x3121), .driver_info = BTUSB_ATH3012 },
237 { USB_DEVICE(0x0cf3, 0x817a), .driver_info = BTUSB_ATH3012 },
238 { USB_DEVICE(0x0cf3, 0x817b), .driver_info = BTUSB_ATH3012 },
239 { USB_DEVICE(0x0cf3, 0xe003), .driver_info = BTUSB_ATH3012 },
240 { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },
241 { USB_DEVICE(0x0cf3, 0xe005), .driver_info = BTUSB_ATH3012 },
242 { USB_DEVICE(0x0cf3, 0xe006), .driver_info = BTUSB_ATH3012 },
243 { USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
244 { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
245 { USB_DEVICE(0x13d3, 0x3393), .driver_info = BTUSB_ATH3012 },
246 { USB_DEVICE(0x13d3, 0x3395), .driver_info = BTUSB_ATH3012 },
247 { USB_DEVICE(0x13d3, 0x3402), .driver_info = BTUSB_ATH3012 },
248 { USB_DEVICE(0x13d3, 0x3408), .driver_info = BTUSB_ATH3012 },
249 { USB_DEVICE(0x13d3, 0x3423), .driver_info = BTUSB_ATH3012 },
250 { USB_DEVICE(0x13d3, 0x3432), .driver_info = BTUSB_ATH3012 },
251 { USB_DEVICE(0x13d3, 0x3472), .driver_info = BTUSB_ATH3012 },
252 { USB_DEVICE(0x13d3, 0x3474), .driver_info = BTUSB_ATH3012 },
253 { USB_DEVICE(0x13d3, 0x3487), .driver_info = BTUSB_ATH3012 },
254 { USB_DEVICE(0x13d3, 0x3490), .driver_info = BTUSB_ATH3012 },
255
256 /* Atheros AR5BBU12 with sflash firmware */
257 { USB_DEVICE(0x0489, 0xe02c), .driver_info = BTUSB_IGNORE },
258
259 /* Atheros AR5BBU12 with sflash firmware */
260 { USB_DEVICE(0x0489, 0xe036), .driver_info = BTUSB_ATH3012 },
261 { USB_DEVICE(0x0489, 0xe03c), .driver_info = BTUSB_ATH3012 },
262
263 /* QCA ROME chipset */
264 { USB_DEVICE(0x0cf3, 0xe007), .driver_info = BTUSB_QCA_ROME },
265 { USB_DEVICE(0x0cf3, 0xe009), .driver_info = BTUSB_QCA_ROME },
266 { USB_DEVICE(0x0cf3, 0xe300), .driver_info = BTUSB_QCA_ROME },
267 { USB_DEVICE(0x0cf3, 0xe301), .driver_info = BTUSB_QCA_ROME },
268 { USB_DEVICE(0x0cf3, 0xe360), .driver_info = BTUSB_QCA_ROME },
269 { USB_DEVICE(0x0489, 0xe092), .driver_info = BTUSB_QCA_ROME },
270 { USB_DEVICE(0x0489, 0xe09f), .driver_info = BTUSB_QCA_ROME },
271 { USB_DEVICE(0x0489, 0xe0a2), .driver_info = BTUSB_QCA_ROME },
272 { USB_DEVICE(0x04ca, 0x3011), .driver_info = BTUSB_QCA_ROME },
273 { USB_DEVICE(0x04ca, 0x3016), .driver_info = BTUSB_QCA_ROME },
274
275 /* Broadcom BCM2035 */
276 { USB_DEVICE(0x0a5c, 0x2009), .driver_info = BTUSB_BCM92035 },
277 { USB_DEVICE(0x0a5c, 0x200a), .driver_info = BTUSB_WRONG_SCO_MTU },
278 { USB_DEVICE(0x0a5c, 0x2035), .driver_info = BTUSB_WRONG_SCO_MTU },
279
280 /* Broadcom BCM2045 */
281 { USB_DEVICE(0x0a5c, 0x2039), .driver_info = BTUSB_WRONG_SCO_MTU },
282 { USB_DEVICE(0x0a5c, 0x2101), .driver_info = BTUSB_WRONG_SCO_MTU },
283
284 /* IBM/Lenovo ThinkPad with Broadcom chip */
285 { USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU },
286 { USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU },
287
288 /* HP laptop with Broadcom chip */
289 { USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU },
290
291 /* Dell laptop with Broadcom chip */
292 { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_WRONG_SCO_MTU },
293
294 /* Dell Wireless 370 and 410 devices */
295 { USB_DEVICE(0x413c, 0x8152), .driver_info = BTUSB_WRONG_SCO_MTU },
296 { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_WRONG_SCO_MTU },
297
298 /* Belkin F8T012 and F8T013 devices */
299 { USB_DEVICE(0x050d, 0x0012), .driver_info = BTUSB_WRONG_SCO_MTU },
300 { USB_DEVICE(0x050d, 0x0013), .driver_info = BTUSB_WRONG_SCO_MTU },
301
302 /* Asus WL-BTD202 device */
303 { USB_DEVICE(0x0b05, 0x1715), .driver_info = BTUSB_WRONG_SCO_MTU },
304
305 /* Kensington Bluetooth USB adapter */
306 { USB_DEVICE(0x047d, 0x105e), .driver_info = BTUSB_WRONG_SCO_MTU },
307
308 /* RTX Telecom based adapters with buggy SCO support */
309 { USB_DEVICE(0x0400, 0x0807), .driver_info = BTUSB_BROKEN_ISOC },
310 { USB_DEVICE(0x0400, 0x080a), .driver_info = BTUSB_BROKEN_ISOC },
311
312 /* CONWISE Technology based adapters with buggy SCO support */
313 { USB_DEVICE(0x0e5e, 0x6622),
314 .driver_info = BTUSB_BROKEN_ISOC | BTUSB_CW6622},
315
316 /* Roper Class 1 Bluetooth Dongle (Silicon Wave based) */
317 { USB_DEVICE(0x1310, 0x0001), .driver_info = BTUSB_SWAVE },
318
319 /* Digianswer devices */
320 { USB_DEVICE(0x08fd, 0x0001), .driver_info = BTUSB_DIGIANSWER },
321 { USB_DEVICE(0x08fd, 0x0002), .driver_info = BTUSB_IGNORE },
322
323 /* CSR BlueCore Bluetooth Sniffer */
324 { USB_DEVICE(0x0a12, 0x0002),
325 .driver_info = BTUSB_SNIFFER | BTUSB_BROKEN_ISOC },
326
327 /* Frontline ComProbe Bluetooth Sniffer */
328 { USB_DEVICE(0x16d3, 0x0002),
329 .driver_info = BTUSB_SNIFFER | BTUSB_BROKEN_ISOC },
330
331 /* Marvell Bluetooth devices */
332 { USB_DEVICE(0x1286, 0x2044), .driver_info = BTUSB_MARVELL },
333 { USB_DEVICE(0x1286, 0x2046), .driver_info = BTUSB_MARVELL },
334 { USB_DEVICE(0x1286, 0x204e), .driver_info = BTUSB_MARVELL },
335
336 /* Intel Bluetooth devices */
337 { USB_DEVICE(0x8087, 0x0025), .driver_info = BTUSB_INTEL_NEW },
338 { USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
339 { USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL },
340 { USB_DEVICE(0x8087, 0x0a2a), .driver_info = BTUSB_INTEL },
341 { USB_DEVICE(0x8087, 0x0a2b), .driver_info = BTUSB_INTEL_NEW },
342 { USB_DEVICE(0x8087, 0x0aa7), .driver_info = BTUSB_INTEL },
343 { USB_DEVICE(0x8087, 0x0aaa), .driver_info = BTUSB_INTEL_NEW },
344
345 /* Other Intel Bluetooth devices */
346 { USB_VENDOR_AND_INTERFACE_INFO(0x8087, 0xe0, 0x01, 0x01),
347 .driver_info = BTUSB_IGNORE },
348
349 /* Realtek Bluetooth devices */
350 { USB_VENDOR_AND_INTERFACE_INFO(0x0bda, 0xe0, 0x01, 0x01),
351 .driver_info = BTUSB_REALTEK },
352
353 /* Additional Realtek 8723AE Bluetooth devices */
354 { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
355 { USB_DEVICE(0x13d3, 0x3394), .driver_info = BTUSB_REALTEK },
356
357 /* Additional Realtek 8723BE Bluetooth devices */
358 { USB_DEVICE(0x0489, 0xe085), .driver_info = BTUSB_REALTEK },
359 { USB_DEVICE(0x0489, 0xe08b), .driver_info = BTUSB_REALTEK },
360 { USB_DEVICE(0x13d3, 0x3410), .driver_info = BTUSB_REALTEK },
361 { USB_DEVICE(0x13d3, 0x3416), .driver_info = BTUSB_REALTEK },
362 { USB_DEVICE(0x13d3, 0x3459), .driver_info = BTUSB_REALTEK },
363 { USB_DEVICE(0x13d3, 0x3494), .driver_info = BTUSB_REALTEK },
364
365 /* Additional Realtek 8821AE Bluetooth devices */
366 { USB_DEVICE(0x0b05, 0x17dc), .driver_info = BTUSB_REALTEK },
367 { USB_DEVICE(0x13d3, 0x3414), .driver_info = BTUSB_REALTEK },
368 { USB_DEVICE(0x13d3, 0x3458), .driver_info = BTUSB_REALTEK },
369 { USB_DEVICE(0x13d3, 0x3461), .driver_info = BTUSB_REALTEK },
370 { USB_DEVICE(0x13d3, 0x3462), .driver_info = BTUSB_REALTEK },
371
372 /* Additional Realtek 8822BE Bluetooth devices */
> 373 { USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
374
375 /* Silicon Wave based devices */
376 { USB_DEVICE(0x0c10, 0x0000), .driver_info = BTUSB_SWAVE },
377
378 { } /* Terminating entry */
379 };
380
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33642 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE
2017-11-11 19:10 ` Larry Finger
@ 2017-11-14 23:40 ` Hon Weng Chong
0 siblings, 0 replies; 7+ messages in thread
From: Hon Weng Chong @ 2017-11-14 23:40 UTC (permalink / raw)
To: Larry Finger
Cc: Marcel Holtmann, Gustavo F. Padovan, Johan Hedberg,
Linux Kernel Mailing List, linux-bluetooth
Hi Larry,
Apologies for the delayed reply. Here's the data for the Realtek Bluetooth Device:
T: Bus=01 Lev=01 Prnt=01 Port=13 Cnt=07 Dev#= 14 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=0b05 ProdID=185c Rev= 1.10
S: Manufacturer=Realtek
S: Product=Bluetooth Radio
S: SerialNumber=00e04c000001
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
> On 12 Nov 2017, at 6:10 am, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 11/11/2017 12:51 PM, Marcel Holtmann wrote:
>> Hi Larry,
>>> The Asus Z370-I contains a Realtek RTL8822BE device with an associated
>>> BT chip using a USB ID of 0b05:185c. This device is added to the driver.
>>>
>>> Signed-off-by: Hon Weng Chong <honwchong@gmail.com>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> ---
>>> drivers/bluetooth/btusb.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>>> index 7a5c06aaa181..c265ef63cab7 100644
>>> --- a/drivers/bluetooth/btusb.c
>>> +++ b/drivers/bluetooth/btusb.c
>>> @@ -373,6 +373,9 @@ static const struct usb_device_id blacklist_table[] = {
>>> { USB_DEVICE(0x13d3, 0x3461), .driver_info = BTUSB_REALTEK },
>>> { USB_DEVICE(0x13d3, 0x3462), .driver_info = BTUSB_REALTEK },
>>>
>>> + /* Additional Realtek 8822BE Bluetooth devices */
>>> + { USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK },
>>> +
>> I prefer to have /sys/kernel/debug/usb/devices for the device included in the commit message.
>> Regards
>> Marcel
> Hon,
>
> Please provide the data.
>
> Larry
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-14 23:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-11 17:43 [PATCH] bluetooth: btusb: Add device ID for RTL8822BE Larry Finger
2017-11-11 18:51 ` Marcel Holtmann
2017-11-11 19:10 ` Larry Finger
2017-11-14 23:40 ` Hon Weng Chong
2017-11-12 13:45 ` Bjørn Mork
2017-11-14 9:22 ` kbuild test robot
2017-11-14 9:30 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).