From: Javier Martinez Canillas <javierm@redhat.com>
To: Maxime Ripard <maxime@cerno.tech>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
kunit-dev@googlegroups.com, linux-media@vger.kernel.org,
linux-kselftest@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"Maíra Canal" <mairacanal@riseup.net>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
linux-kernel@vger.kernel.org, "David Gow" <davidgow@google.com>
Subject: Re: [PATCH v2 08/17] drm/tests: helpers: Allow for a custom device struct to be allocated
Date: Wed, 30 Nov 2022 10:13:39 +0100 [thread overview]
Message-ID: <a86a67d8-59dc-1af8-4176-b3236ef0f0a1@redhat.com> (raw)
In-Reply-To: <20221123-rpi-kunit-tests-v2-8-efe5ed518b63@cerno.tech>
On 11/28/22 15:53, Maxime Ripard wrote:
> The current helper to allocate a DRM device doesn't allow for any
> subclassing by drivers, which is going to be troublesome as we work on
> getting some kunit testing on atomic modesetting code.
>
> Let's use a similar pattern to the other allocation helpers by providing
> the structure size and offset as arguments.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
[...]
> -EXPORT_SYMBOL(drm_kunit_helper_alloc_drm_device);
> +EXPORT_SYMBOL(__drm_kunit_helper_alloc_drm_device);
>
I'm not sure if I would add a __ prefix to exported symbols, but I see that
this is a convention in the DRM subsystem so I'm OK with it.
Another thing that came to mind is if we want to use EXPORT_SYMBOL_GPL()
instead for the DRM KUnit helpers. But that's not related to this series.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2022-11-30 9:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221123-rpi-kunit-tests-v2-0-efe5ed518b63@cerno.tech>
[not found] ` <20221123-rpi-kunit-tests-v2-2-efe5ed518b63@cerno.tech>
2022-11-28 19:30 ` [PATCH v2 02/17] drm/tests: helpers: Document drm_kunit_device_init() Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-4-efe5ed518b63@cerno.tech>
2022-11-28 19:37 ` [PATCH v2 04/17] drm/tests: helpers: Remove the name parameter Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-5-efe5ed518b63@cerno.tech>
2022-11-28 19:48 ` [PATCH v2 05/17] drm/tests: helpers: Create the device in another function Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-6-efe5ed518b63@cerno.tech>
2022-11-28 20:01 ` [PATCH v2 06/17] drm/tests: helpers: Switch to a platform_device Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-7-efe5ed518b63@cerno.tech>
2022-11-28 20:09 ` [PATCH v2 07/17] drm/tests: helpers: Make sure the device is bound Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-10-efe5ed518b63@cerno.tech>
2022-11-28 20:14 ` [PATCH v2 10/17] drm/tests: Add a test for DRM managed actions Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-11-efe5ed518b63@cerno.tech>
2022-11-28 20:16 ` [PATCH v2 11/17] drm/vc4: Move HVS state to main header Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-12-efe5ed518b63@cerno.tech>
2022-11-28 20:23 ` [PATCH v2 12/17] drm/vc4: crtc: Introduce a lower-level crtc init helper Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-13-efe5ed518b63@cerno.tech>
2022-11-28 20:26 ` [PATCH v2 13/17] drm/vc4: crtc: Make encoder lookup helper public Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-15-efe5ed518b63@cerno.tech>
2022-11-28 20:35 ` [PATCH v2 15/17] drm/vc4: tests: Introduce a mocking infrastructure Maíra Canal
2022-11-30 9:59 ` Javier Martinez Canillas
2022-12-01 13:03 ` Maxime Ripard
[not found] ` <20221123-rpi-kunit-tests-v2-3-efe5ed518b63@cerno.tech>
2022-11-28 20:36 ` [PATCH v2 03/17] drm/tests: helpers: Rename the device init helper Maíra Canal
2022-11-28 20:48 ` [PATCH v2 00/17] drm: Introduce Kunit Tests to VC4 Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-1-efe5ed518b63@cerno.tech>
2022-11-30 8:00 ` [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm Javier Martinez Canillas
2022-12-01 10:27 ` Maxime Ripard
2022-12-01 10:38 ` Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-8-efe5ed518b63@cerno.tech>
2022-11-30 9:13 ` Javier Martinez Canillas [this message]
[not found] ` <20221123-rpi-kunit-tests-v2-9-efe5ed518b63@cerno.tech>
2022-11-30 9:27 ` [PATCH v2 09/17] drm/tests: helpers: Allow to pass a custom drm_driver Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-16-efe5ed518b63@cerno.tech>
2022-11-30 10:09 ` [PATCH v2 16/17] drm/vc4: tests: Fail the current test if we access a register Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-17-efe5ed518b63@cerno.tech>
2022-11-30 10:15 ` [PATCH v2 17/17] drm/vc4: tests: Add unit test suite for the PV muxing Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86a67d8-59dc-1af8-4176-b3236ef0f0a1@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mairacanal@riseup.net \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).