From: "Maíra Canal" <mcanal@igalia.com>
To: Maxime Ripard <maxime@cerno.tech>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Gow <davidgow@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linaro-mm-sig@lists.linaro.org,
Brendan Higgins <brendan.higgins@linux.dev>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 10/17] drm/tests: Add a test for DRM managed actions
Date: Mon, 28 Nov 2022 17:14:21 -0300 [thread overview]
Message-ID: <b48c4585-52b9-5311-5210-fd5679bda90f@igalia.com> (raw)
In-Reply-To: <20221123-rpi-kunit-tests-v2-10-efe5ed518b63@cerno.tech>
On 11/28/22 11:53, Maxime Ripard wrote:
> DRM-managed actions are supposed to be ran whenever the device is
> released. Let's introduce a basic unit test to make sure it happens.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Best Regards,
- Maíra Canal
> ---
> drivers/gpu/drm/tests/Makefile | 1 +
> drivers/gpu/drm/tests/drm_managed_test.c | 71 ++++++++++++++++++++++++++++++++
> 2 files changed, 72 insertions(+)
>
> diff --git a/drivers/gpu/drm/tests/Makefile b/drivers/gpu/drm/tests/Makefile
> index 94fe546d937d..486053052ba9 100644
> --- a/drivers/gpu/drm/tests/Makefile
> +++ b/drivers/gpu/drm/tests/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \
> drm_format_test.o \
> drm_framebuffer_test.o \
> drm_kunit_helpers.o \
> + drm_managed_test.o \
> drm_mm_test.o \
> drm_modes_test.o \
> drm_plane_helper_test.o \
> diff --git a/drivers/gpu/drm/tests/drm_managed_test.c b/drivers/gpu/drm/tests/drm_managed_test.c
> new file mode 100644
> index 000000000000..1652dca11d30
> --- /dev/null
> +++ b/drivers/gpu/drm/tests/drm_managed_test.c
> @@ -0,0 +1,71 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <drm/drm_drv.h>
> +#include <drm/drm_kunit_helpers.h>
> +#include <drm/drm_managed.h>
> +
> +#include <kunit/resource.h>
> +
> +#include <linux/device.h>
> +
> +/* Ought to be enough for anybody */
> +#define TEST_TIMEOUT_MS 100
> +
> +struct managed_test_priv {
> + bool action_done;
> + wait_queue_head_t action_wq;
> +};
> +
> +static void drm_action(struct drm_device *drm, void *ptr)
> +{
> + struct managed_test_priv *priv = ptr;
> +
> + priv->action_done = true;
> + wake_up_interruptible(&priv->action_wq);
> +}
> +
> +static void drm_test_managed_run_action(struct kunit *test)
> +{
> + struct managed_test_priv *priv;
> + struct drm_device *drm;
> + struct device *dev;
> + int ret;
> +
> + priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
> + init_waitqueue_head(&priv->action_wq);
> +
> + dev = drm_kunit_helper_alloc_device(test);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
> +
> + drm = __drm_kunit_helper_alloc_drm_device(test, dev, sizeof(*drm), 0, DRIVER_MODESET);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm);
> +
> + ret = drmm_add_action_or_reset(drm, drm_action, priv);
> + KUNIT_EXPECT_EQ(test, ret, 0);
> +
> + ret = drm_dev_register(drm, 0);
> + KUNIT_ASSERT_EQ(test, ret, 0);
> +
> + drm_dev_unregister(drm);
> + drm_kunit_helper_free_device(test, dev);
> +
> + ret = wait_event_interruptible_timeout(priv->action_wq, priv->action_done,
> + msecs_to_jiffies(TEST_TIMEOUT_MS));
> + KUNIT_EXPECT_GT(test, ret, 0);
> +}
> +
> +static struct kunit_case drm_managed_tests[] = {
> + KUNIT_CASE(drm_test_managed_run_action),
> + {}
> +};
> +
> +static struct kunit_suite drm_managed_test_suite = {
> + .name = "drm-test-managed",
> + .test_cases = drm_managed_tests
> +};
> +
> +kunit_test_suite(drm_managed_test_suite);
> +
> +MODULE_AUTHOR("Maxime Ripard <maxime@cerno.tech>");
> +MODULE_LICENSE("GPL");
>
next prev parent reply other threads:[~2022-11-28 20:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221123-rpi-kunit-tests-v2-0-efe5ed518b63@cerno.tech>
[not found] ` <20221123-rpi-kunit-tests-v2-2-efe5ed518b63@cerno.tech>
2022-11-28 19:30 ` [PATCH v2 02/17] drm/tests: helpers: Document drm_kunit_device_init() Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-4-efe5ed518b63@cerno.tech>
2022-11-28 19:37 ` [PATCH v2 04/17] drm/tests: helpers: Remove the name parameter Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-5-efe5ed518b63@cerno.tech>
2022-11-28 19:48 ` [PATCH v2 05/17] drm/tests: helpers: Create the device in another function Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-6-efe5ed518b63@cerno.tech>
2022-11-28 20:01 ` [PATCH v2 06/17] drm/tests: helpers: Switch to a platform_device Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-7-efe5ed518b63@cerno.tech>
2022-11-28 20:09 ` [PATCH v2 07/17] drm/tests: helpers: Make sure the device is bound Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-10-efe5ed518b63@cerno.tech>
2022-11-28 20:14 ` Maíra Canal [this message]
[not found] ` <20221123-rpi-kunit-tests-v2-11-efe5ed518b63@cerno.tech>
2022-11-28 20:16 ` [PATCH v2 11/17] drm/vc4: Move HVS state to main header Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-12-efe5ed518b63@cerno.tech>
2022-11-28 20:23 ` [PATCH v2 12/17] drm/vc4: crtc: Introduce a lower-level crtc init helper Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-13-efe5ed518b63@cerno.tech>
2022-11-28 20:26 ` [PATCH v2 13/17] drm/vc4: crtc: Make encoder lookup helper public Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-15-efe5ed518b63@cerno.tech>
2022-11-28 20:35 ` [PATCH v2 15/17] drm/vc4: tests: Introduce a mocking infrastructure Maíra Canal
2022-11-30 9:59 ` Javier Martinez Canillas
2022-12-01 13:03 ` Maxime Ripard
[not found] ` <20221123-rpi-kunit-tests-v2-3-efe5ed518b63@cerno.tech>
2022-11-28 20:36 ` [PATCH v2 03/17] drm/tests: helpers: Rename the device init helper Maíra Canal
2022-11-28 20:48 ` [PATCH v2 00/17] drm: Introduce Kunit Tests to VC4 Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-1-efe5ed518b63@cerno.tech>
2022-11-30 8:00 ` [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm Javier Martinez Canillas
2022-12-01 10:27 ` Maxime Ripard
2022-12-01 10:38 ` Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-8-efe5ed518b63@cerno.tech>
2022-11-30 9:13 ` [PATCH v2 08/17] drm/tests: helpers: Allow for a custom device struct to be allocated Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-9-efe5ed518b63@cerno.tech>
2022-11-30 9:27 ` [PATCH v2 09/17] drm/tests: helpers: Allow to pass a custom drm_driver Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-16-efe5ed518b63@cerno.tech>
2022-11-30 10:09 ` [PATCH v2 16/17] drm/vc4: tests: Fail the current test if we access a register Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-17-efe5ed518b63@cerno.tech>
2022-11-30 10:15 ` [PATCH v2 17/17] drm/vc4: tests: Add unit test suite for the PV muxing Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48c4585-52b9-5311-5210-fd5679bda90f@igalia.com \
--to=mcanal@igalia.com \
--cc=airlied@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).