From: "Maíra Canal" <mcanal@igalia.com>
To: Maxime Ripard <maxime@cerno.tech>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Gow <davidgow@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linaro-mm-sig@lists.linaro.org,
Brendan Higgins <brendan.higgins@linux.dev>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 05/17] drm/tests: helpers: Create the device in another function
Date: Mon, 28 Nov 2022 16:48:45 -0300 [thread overview]
Message-ID: <eb318e69-3fc5-c041-cc17-e0549d6cf128@igalia.com> (raw)
In-Reply-To: <20221123-rpi-kunit-tests-v2-5-efe5ed518b63@cerno.tech>
On 11/28/22 11:53, Maxime Ripard wrote:
> We'll need in some tests to control when the device needs to be added
> and removed, so let's split the device creation from the DRM device
> creation function.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Just a small nit below,
Reviewed-by: Maíra Canal <mcanal@igalia.com>
>
> diff --git a/drivers/gpu/drm/tests/drm_probe_helper_test.c b/drivers/gpu/drm/tests/drm_probe_helper_test.c
> index be61a92b79d2..438b1d42b843 100644
> --- a/drivers/gpu/drm/tests/drm_probe_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_probe_helper_test.c
> @@ -17,6 +17,7 @@
>
> struct drm_probe_helper_test_priv {
> struct drm_device *drm;
> + struct device *dev;
> struct drm_connector connector;
> };
>
> @@ -39,7 +40,10 @@ static int drm_probe_helper_test_init(struct kunit *test)
> KUNIT_ASSERT_NOT_NULL(test, priv);
> test->priv = priv;
>
> - priv->drm = drm_kunit_helper_alloc_drm_device(test,
> + priv->dev = drm_kunit_helper_alloc_device(test);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev);
> +
> + priv->drm = drm_kunit_helper_alloc_drm_device(test, priv->dev,
> DRIVER_MODESET | DRIVER_ATOMIC);
> KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->drm);
>
> @@ -55,6 +59,13 @@ static int drm_probe_helper_test_init(struct kunit *test)
> return 0;
> }
>
> +static void drm_probe_helper_test_exit(struct kunit *test)
> +{
> + struct drm_probe_helper_test_priv *priv = test->priv;;
There are two semicolons by the end of this statement.
Best Regards,
- Maíra Canal
> +
> + drm_kunit_helper_free_device(test, priv->dev);
> +}
> +
> typedef struct drm_display_mode *(*expected_mode_func_t)(struct drm_device *);
>
> struct drm_connector_helper_tv_get_modes_test {
> @@ -195,6 +206,7 @@ static struct kunit_case drm_test_connector_helper_tv_get_modes_tests[] = {
> static struct kunit_suite drm_test_connector_helper_tv_get_modes_suite = {
> .name = "drm_connector_helper_tv_get_modes",
> .init = drm_probe_helper_test_init,
> + .exit = drm_probe_helper_test_exit,
> .test_cases = drm_test_connector_helper_tv_get_modes_tests,
> };
>
> diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helpers.h
> index 6c12b1426ba0..b4277fe92c38 100644
> --- a/include/drm/drm_kunit_helpers.h
> +++ b/include/drm/drm_kunit_helpers.h
> @@ -6,8 +6,11 @@
> struct drm_device;
> struct kunit;
>
> +struct device *drm_kunit_helper_alloc_device(struct kunit *test);
> +void drm_kunit_helper_free_device(struct kunit *test, struct device *dev);
> +
> struct drm_device *
> -drm_kunit_helper_alloc_drm_device(struct kunit *test,
> +drm_kunit_helper_alloc_drm_device(struct kunit *test, struct device *dev,
> u32 features);
>
> #endif // DRM_KUNIT_HELPERS_H_
>
next prev parent reply other threads:[~2022-11-28 19:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221123-rpi-kunit-tests-v2-0-efe5ed518b63@cerno.tech>
[not found] ` <20221123-rpi-kunit-tests-v2-2-efe5ed518b63@cerno.tech>
2022-11-28 19:30 ` [PATCH v2 02/17] drm/tests: helpers: Document drm_kunit_device_init() Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-4-efe5ed518b63@cerno.tech>
2022-11-28 19:37 ` [PATCH v2 04/17] drm/tests: helpers: Remove the name parameter Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-5-efe5ed518b63@cerno.tech>
2022-11-28 19:48 ` Maíra Canal [this message]
[not found] ` <20221123-rpi-kunit-tests-v2-6-efe5ed518b63@cerno.tech>
2022-11-28 20:01 ` [PATCH v2 06/17] drm/tests: helpers: Switch to a platform_device Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-7-efe5ed518b63@cerno.tech>
2022-11-28 20:09 ` [PATCH v2 07/17] drm/tests: helpers: Make sure the device is bound Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-10-efe5ed518b63@cerno.tech>
2022-11-28 20:14 ` [PATCH v2 10/17] drm/tests: Add a test for DRM managed actions Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-11-efe5ed518b63@cerno.tech>
2022-11-28 20:16 ` [PATCH v2 11/17] drm/vc4: Move HVS state to main header Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-12-efe5ed518b63@cerno.tech>
2022-11-28 20:23 ` [PATCH v2 12/17] drm/vc4: crtc: Introduce a lower-level crtc init helper Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-13-efe5ed518b63@cerno.tech>
2022-11-28 20:26 ` [PATCH v2 13/17] drm/vc4: crtc: Make encoder lookup helper public Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-15-efe5ed518b63@cerno.tech>
2022-11-28 20:35 ` [PATCH v2 15/17] drm/vc4: tests: Introduce a mocking infrastructure Maíra Canal
2022-11-30 9:59 ` Javier Martinez Canillas
2022-12-01 13:03 ` Maxime Ripard
[not found] ` <20221123-rpi-kunit-tests-v2-3-efe5ed518b63@cerno.tech>
2022-11-28 20:36 ` [PATCH v2 03/17] drm/tests: helpers: Rename the device init helper Maíra Canal
2022-11-28 20:48 ` [PATCH v2 00/17] drm: Introduce Kunit Tests to VC4 Maíra Canal
[not found] ` <20221123-rpi-kunit-tests-v2-1-efe5ed518b63@cerno.tech>
2022-11-30 8:00 ` [PATCH v2 01/17] drm/tests: helpers: Move the helper header to include/drm Javier Martinez Canillas
2022-12-01 10:27 ` Maxime Ripard
2022-12-01 10:38 ` Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-8-efe5ed518b63@cerno.tech>
2022-11-30 9:13 ` [PATCH v2 08/17] drm/tests: helpers: Allow for a custom device struct to be allocated Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-9-efe5ed518b63@cerno.tech>
2022-11-30 9:27 ` [PATCH v2 09/17] drm/tests: helpers: Allow to pass a custom drm_driver Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-16-efe5ed518b63@cerno.tech>
2022-11-30 10:09 ` [PATCH v2 16/17] drm/vc4: tests: Fail the current test if we access a register Javier Martinez Canillas
[not found] ` <20221123-rpi-kunit-tests-v2-17-efe5ed518b63@cerno.tech>
2022-11-30 10:15 ` [PATCH v2 17/17] drm/vc4: tests: Add unit test suite for the PV muxing Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb318e69-3fc5-c041-cc17-e0549d6cf128@igalia.com \
--to=mcanal@igalia.com \
--cc=airlied@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).