linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool
@ 2016-12-24  9:38 Rahul Krishnan
  2016-12-27 22:33 ` Tyrel Datwyler
  2017-01-11 20:55 ` Bjorn Helgaas
  0 siblings, 2 replies; 3+ messages in thread
From: Rahul Krishnan @ 2016-12-24  9:38 UTC (permalink / raw)
  To: benh; +Cc: paulus, mpe, bhelgaas, linuxppc-dev, linux-pci, linux-kernel


This patch removes unnecessary return statement using spatch tool

Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
---
 drivers/pci/hotplug/rpadlpar_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
index dc67f39..78ce2c7 100644
--- a/drivers/pci/hotplug/rpadlpar_core.c
+++ b/drivers/pci/hotplug/rpadlpar_core.c
@@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
 
 int __init rpadlpar_io_init(void)
 {
-	int rc = 0;
 
 	if (!is_dlpar_capable()) {
 		printk(KERN_WARNING "%s: partition not DLPAR capable\n",
@@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
 		return -EPERM;
 	}
 
-	rc = dlpar_sysfs_init();
-	return rc;
+	return dlpar_sysfs_init();
 }
 
 void rpadlpar_io_exit(void)
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool
  2016-12-24  9:38 [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool Rahul Krishnan
@ 2016-12-27 22:33 ` Tyrel Datwyler
  2017-01-11 20:55 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: Tyrel Datwyler @ 2016-12-27 22:33 UTC (permalink / raw)
  To: Rahul Krishnan, benh
  Cc: linux-kernel, paulus, linux-pci, bhelgaas, linuxppc-dev

On 12/24/2016 01:38 AM, Rahul Krishnan wrote:
> 
> This patch removes unnecessary return statement using spatch tool
> 
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>

Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>

> ---
>  drivers/pci/hotplug/rpadlpar_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
> index dc67f39..78ce2c7 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
> 
>  int __init rpadlpar_io_init(void)
>  {
> -	int rc = 0;
> 
>  	if (!is_dlpar_capable()) {
>  		printk(KERN_WARNING "%s: partition not DLPAR capable\n",
> @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
>  		return -EPERM;
>  	}
> 
> -	rc = dlpar_sysfs_init();
> -	return rc;
> +	return dlpar_sysfs_init();
>  }
> 
>  void rpadlpar_io_exit(void)
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool
  2016-12-24  9:38 [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool Rahul Krishnan
  2016-12-27 22:33 ` Tyrel Datwyler
@ 2017-01-11 20:55 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2017-01-11 20:55 UTC (permalink / raw)
  To: Rahul Krishnan
  Cc: benh, paulus, mpe, bhelgaas, linuxppc-dev, linux-pci, linux-kernel

On Sat, Dec 24, 2016 at 03:08:00PM +0530, Rahul Krishnan wrote:
> 
> This patch removes unnecessary return statement using spatch tool
> 
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>

Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thanks!

Are there other similar instances elsewhere in drivers/pci?  If so,
can you fix them all at once?

> ---
>  drivers/pci/hotplug/rpadlpar_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
> index dc67f39..78ce2c7 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
>  
>  int __init rpadlpar_io_init(void)
>  {
> -	int rc = 0;
>  
>  	if (!is_dlpar_capable()) {
>  		printk(KERN_WARNING "%s: partition not DLPAR capable\n",
> @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
>  		return -EPERM;
>  	}
>  
> -	rc = dlpar_sysfs_init();
> -	return rc;
> +	return dlpar_sysfs_init();
>  }
>  
>  void rpadlpar_io_exit(void)
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-11 20:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-24  9:38 [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool Rahul Krishnan
2016-12-27 22:33 ` Tyrel Datwyler
2017-01-11 20:55 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).