From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Chris Chiu <chiu@endlessm.com>, Jian-Hong Pan <jian-hong@endlessm.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jani Nikula <jani.nikula@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Adrian Salido <salidoa@google.com>,
Jason Gerecke <killertofu@gmail.com>,
linux-input@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Daniel Drake <drake@endlessm.com>,
Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD
Date: Tue, 8 May 2018 17:31:16 +0300 [thread overview]
Message-ID: <a9e1f1cb-b823-8690-930f-f7346798341a@linux.intel.com> (raw)
In-Reply-To: <CAB4CAwcKu88xP0R9P-3csd6SE2fZ-Vb6OrQD9AmBDh6p77VFDQ@mail.gmail.com>
Hi
On 05/07/2018 11:07 AM, Chris Chiu wrote:
>> Besides, according to ASUS's input, they observed that after entering
>> the OS, the frequency of SCL is too fast (about 600kHz) and the SCL High
>> time is around 450ns, not following I2C spec which is 0.6us.
>> https://pasteboard.co/HjzSWXd.png
>>
> Some update, we can make the touchpad work by simply modifying the
> clk_rate of spt_i2c_info from 120000000 to 133000000 in intel-lpss-pci.c for
> specific PCI ID 8086:a368 ~ a36a (CoffeeLake). Is the clock setting different
> for the CoffeeLake series?
>
Hmm.. at quick look it looks like to be 133 MHz but I want to double
check first from other specs. I'm also wondering why it results 600 kHz
instead of expected 133/120 * 400 kHz = 443 kHz. Need to check timing
parameters too.
--
Jarkko
next prev parent reply other threads:[~2018-05-08 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 6:55 [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD Jian-Hong Pan
2018-05-07 8:07 ` Chris Chiu
2018-05-08 14:31 ` Jarkko Nikula [this message]
2018-05-08 15:47 ` Daniel Drake
2018-05-10 12:03 ` Chris Chiu
2018-05-14 14:20 ` Jarkko Nikula
2018-05-15 3:22 ` Chris Chiu
2018-05-15 10:20 ` Jarkko Nikula
2018-05-17 7:48 ` Jarkko Nikula
2018-05-17 9:05 ` Chris Chiu
2018-05-18 7:48 ` Hans de Goede
2018-05-18 8:37 ` Andy Shevchenko
2018-05-18 10:20 ` Andy Shevchenko
2018-05-18 10:58 ` Jarkko Nikula
2018-05-18 13:09 ` Hans de Goede
2018-05-18 13:15 ` Jarkko Nikula
2018-05-18 13:26 ` Hans de Goede
2018-05-19 11:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9e1f1cb-b823-8690-930f-f7346798341a@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=chiu@endlessm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=drake@endlessm.com \
--cc=hdegoede@redhat.com \
--cc=jani.nikula@intel.com \
--cc=jian-hong@endlessm.com \
--cc=jikos@kernel.org \
--cc=killertofu@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=salidoa@google.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).