linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Chiu <chiu@endlessm.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Daniel Drake <drake@endlessm.com>,
	Jian-Hong Pan <jian-hong@endlessm.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Adrian Salido <salidoa@google.com>,
	Jason Gerecke <killertofu@gmail.com>,
	linux-input <linux-input@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD
Date: Thu, 17 May 2018 17:05:38 +0800	[thread overview]
Message-ID: <CAB4CAwdEYJncAxD30UxbFcdz57+AoJnda_L9X3kR6vs=z-dmdQ@mail.gmail.com> (raw)
In-Reply-To: <a3ce1af5-7b99-38db-fc51-4d580db1e87e@linux.intel.com>

On Thu, May 17, 2018 at 3:48 PM, Jarkko Nikula
<jarkko.nikula@linux.intel.com> wrote:
> Hi
>
> On 05/15/2018 01:20 PM, Jarkko Nikula wrote:
>>
>> On 05/15/2018 06:22 AM, Chris Chiu wrote:
>>>
>>> What if I change the 120MHz to 180MHz and then make sure that the I2C
>>> operates
>>> in target FS mode frequency 400kHz via scope? Would there be any side
>>> effect?
>>> Maybe some other busses frequency could be also affected and causing some
>>> other
>>> component malfunction?
>>>
>> Should be safe. It is only clock rate information when registering a fixed
>> clock with known rate in intel-lpss.c and i2c-designware uses that info when
>> calculating the timing parameters. I.e. it doesn't change any internal
>> clocks.
>>
>> I'm trying to find a contact who can confirm what is the expected rate of
>> I2C input clock and is it common to all Cannon Lake HW.
>>
> I got confirmation that input clock is actually even higher 216 Mhz.
>
> While checking does it cover all of those CNL CNL-LP and CNL-H PCI IDs may I
> add your Jian-Hong, Chris and Daniel email addresses to Repored-by tags in a
> fix patch?
>
> --
> Jarkko

No problem. Thanks

  reply	other threads:[~2018-05-17  9:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04  6:55 [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD Jian-Hong Pan
2018-05-07  8:07 ` Chris Chiu
2018-05-08 14:31   ` Jarkko Nikula
2018-05-08 15:47     ` Daniel Drake
2018-05-10 12:03       ` Chris Chiu
2018-05-14 14:20         ` Jarkko Nikula
2018-05-15  3:22           ` Chris Chiu
2018-05-15 10:20             ` Jarkko Nikula
2018-05-17  7:48               ` Jarkko Nikula
2018-05-17  9:05                 ` Chris Chiu [this message]
2018-05-18  7:48                 ` Hans de Goede
2018-05-18  8:37                   ` Andy Shevchenko
2018-05-18 10:20                     ` Andy Shevchenko
2018-05-18 10:58                       ` Jarkko Nikula
2018-05-18 13:09                         ` Hans de Goede
2018-05-18 13:15                   ` Jarkko Nikula
2018-05-18 13:26                     ` Hans de Goede
2018-05-19 11:58                     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB4CAwdEYJncAxD30UxbFcdz57+AoJnda_L9X3kR6vs=z-dmdQ@mail.gmail.com' \
    --to=chiu@endlessm.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=drake@endlessm.com \
    --cc=hdegoede@redhat.com \
    --cc=jani.nikula@intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jian-hong@endlessm.com \
    --cc=jikos@kernel.org \
    --cc=killertofu@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=salidoa@google.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).