From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>,
Jian-Hong Pan <jian-hong@endlessm.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jani Nikula <jani.nikula@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Adrian Salido <salidoa@google.com>,
Jason Gerecke <killertofu@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD
Date: Fri, 18 May 2018 11:37:41 +0300 [thread overview]
Message-ID: <822d5f47cad46ca308d511f7f24cdbc5f4af38b9.camel@linux.intel.com> (raw)
In-Reply-To: <ba99be8e-8e8b-87c1-8607-24ace8a01c64@redhat.com>
On Fri, 2018-05-18 at 09:48 +0200, Hans de Goede wrote:
> Could it be the i2c input clock definition in drivers/mfd/intel-lpss-
> pci.c
> is also wrong for Apollo Lake (N3450) ? There are lots of people
> having
> various issues with i2c attached touchpads on Apollo Lake devices,
> this bug:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1728244
>
> Is sort of a collection bug for these. Various models laptops, lots of
> reporters. Note not sure thie is an i2c-designware issue, but it would
> be good to double check the input clock on Apollo Lake.
>
> I've checked the datasheet and the datasheet mentions 133MHz as
> "serial input clk" in the lpio_bxt_regs Registers Summary, which is
> also part of the LPSS, no clk is mentioned in the "Summary of
> DW_apb_i2c_mem_map_DW_apb_i2c_addr_block1 Registers".
The internal datasheet we have access to mentioned in this case for
Broxton and Cannonlake together. So, your assumption might be quite
close to the truth and the issue is inherited from Broxton.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-05-18 8:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 6:55 [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD Jian-Hong Pan
2018-05-07 8:07 ` Chris Chiu
2018-05-08 14:31 ` Jarkko Nikula
2018-05-08 15:47 ` Daniel Drake
2018-05-10 12:03 ` Chris Chiu
2018-05-14 14:20 ` Jarkko Nikula
2018-05-15 3:22 ` Chris Chiu
2018-05-15 10:20 ` Jarkko Nikula
2018-05-17 7:48 ` Jarkko Nikula
2018-05-17 9:05 ` Chris Chiu
2018-05-18 7:48 ` Hans de Goede
2018-05-18 8:37 ` Andy Shevchenko [this message]
2018-05-18 10:20 ` Andy Shevchenko
2018-05-18 10:58 ` Jarkko Nikula
2018-05-18 13:09 ` Hans de Goede
2018-05-18 13:15 ` Jarkko Nikula
2018-05-18 13:26 ` Hans de Goede
2018-05-19 11:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=822d5f47cad46ca308d511f7f24cdbc5f4af38b9.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=chiu@endlessm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=drake@endlessm.com \
--cc=hdegoede@redhat.com \
--cc=jani.nikula@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jian-hong@endlessm.com \
--cc=jikos@kernel.org \
--cc=killertofu@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=salidoa@google.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).