From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Baole Ni <baolex.ni@intel.com>
Cc: jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Chuansheng Liu <chuansheng.liu@intel.com>
Subject: Re: [PATCH 1045/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 13:14:03 -0500 [thread overview]
Message-ID: <acf38de2-96c3-090f-9086-e111c9a4bc17@oracle.com> (raw)
In-Reply-To: <20160802121122.19777-1-baolex.ni@intel.com>
Trimming the cc list..
On 08/02/2016 07:11 AM, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
NACK for the same reasons that others have rejected companion patches.
0644 is much easier to read than S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> fs/jfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index cec8814..c348410 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread;
>
> #ifdef CONFIG_JFS_DEBUG
> int jfsloglevel = JFS_LOGLEVEL_WARN;
> -module_param(jfsloglevel, int, 0644);
> +module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)");
> #endif
prev parent reply other threads:[~2016-08-02 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 12:11 [PATCH 1045/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 18:14 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acf38de2-96c3-090f-9086-e111c9a4bc17@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).