* [PATCH 1045/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:11 Baole Ni
2016-08-02 18:14 ` Dave Kleikamp
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 12:11 UTC (permalink / raw)
To: shaggy, jack, david.vrabel, tomi.valkeinen, m.chehab, gregkh,
m.szyprowski, kyungmin.park, k.kozlowski
Cc: jfs-discussion, linux-kernel, chuansheng.liu, baolex.ni,
mhalcrow, kirill.shutemov, oneukum
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
fs/jfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index cec8814..c348410 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread;
#ifdef CONFIG_JFS_DEBUG
int jfsloglevel = JFS_LOGLEVEL_WARN;
-module_param(jfsloglevel, int, 0644);
+module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)");
#endif
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1045/1285] Replace numeric parameter like 0444 with macro
2016-08-02 12:11 [PATCH 1045/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 18:14 ` Dave Kleikamp
0 siblings, 0 replies; 2+ messages in thread
From: Dave Kleikamp @ 2016-08-02 18:14 UTC (permalink / raw)
To: Baole Ni; +Cc: jfs-discussion, linux-kernel, Chuansheng Liu
Trimming the cc list..
On 08/02/2016 07:11 AM, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
NACK for the same reasons that others have rejected companion patches.
0644 is much easier to read than S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> fs/jfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index cec8814..c348410 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread;
>
> #ifdef CONFIG_JFS_DEBUG
> int jfsloglevel = JFS_LOGLEVEL_WARN;
> -module_param(jfsloglevel, int, 0644);
> +module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)");
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:11 [PATCH 1045/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 18:14 ` Dave Kleikamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).