From: David Rientjes <rientjes@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Mike Galbraith <mgalbraith@suse.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Li Zefan <lizf@cn.fujitsu.com>, Paul Menage <paul@paulmenage.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] cgroups: disallow attaching kthreadd
Date: Wed, 4 Apr 2012 16:14:21 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1204041611430.18500@chino.kir.corp.google.com> (raw)
In-Reply-To: <20120404230922.GC2173@dhcp-172-17-108-109.mtv.corp.google.com>
On Wed, 4 Apr 2012, Tejun Heo wrote:
> I don't see much problem with the proposed solution and am gonna take
> it unless there are pretty good reasons not to.
>
The only cgroup that cannot allow kthreadd is cpusets and that's
illustrated by Mike's changelog. Restricting it for all cgroups is
completely unnecessary, as I've already said, and is the entire reason we
have ->can_attach() functions for each cgroup.
Also see Paul Menage's suggestion for only isolating this fix to cpusets
as well at
http://lkml.indiana.edu/hypermail/linux/kernel/1110.2/01280.html.
Thanks.
next prev parent reply other threads:[~2012-04-04 23:14 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 17:58 [patch] cgroups: disallow attaching kthreadd Mike Galbraith
2012-04-03 18:49 ` Tejun Heo
2012-04-04 2:34 ` Mike Galbraith
2012-04-04 23:06 ` Tejun Heo
2012-04-04 23:10 ` Tejun Heo
2012-04-04 7:15 ` David Rientjes
2012-04-04 10:38 ` Mike Galbraith
2012-04-04 11:29 ` David Rientjes
2012-04-04 12:30 ` Mike Galbraith
2012-04-04 21:17 ` David Rientjes
2012-04-04 23:09 ` Tejun Heo
2012-04-04 23:14 ` David Rientjes [this message]
2012-04-05 4:47 ` Mike Galbraith
2012-04-05 4:58 ` David Rientjes
2012-04-05 5:49 ` Mike Galbraith
2012-04-05 6:07 ` David Rientjes
2012-04-05 6:42 ` Mike Galbraith
2012-04-05 6:49 ` David Rientjes
2012-04-05 7:14 ` [patch 0/2] cpusets, cpu_cgroup: " David Rientjes
2012-04-05 7:14 ` [patch 1/2] cpusets: " David Rientjes
2012-04-05 7:14 ` [patch 2/2] cpu_cgroup: " David Rientjes
2012-04-05 16:08 ` [patch 0/2] cpusets, " Tejun Heo
2012-04-05 21:26 ` David Rientjes
2012-04-05 21:37 ` Tejun Heo
2012-04-05 21:46 ` Tejun Heo
2012-04-06 7:50 ` Li Zefan
2012-04-06 15:54 ` Tejun Heo
2012-04-05 22:03 ` David Rientjes
2012-04-05 22:24 ` Tejun Heo
2012-04-05 22:31 ` Tejun Heo
2012-04-05 22:55 ` David Rientjes
2012-04-05 22:58 ` Tejun Heo
2012-04-05 23:05 ` David Rientjes
2012-04-05 23:13 ` Tejun Heo
2012-04-05 23:40 ` David Rientjes
2012-04-06 15:52 ` Tejun Heo
2012-04-06 18:26 ` Peter Zijlstra
2012-04-06 20:49 ` David Rientjes
2012-04-07 15:02 ` Hiroyuki Kamezawa
2012-04-10 0:52 ` David Rientjes
2012-04-14 11:35 ` Peter Zijlstra
2012-04-20 17:55 ` Tejun Heo
2012-04-06 20:46 ` David Rientjes
2012-04-14 11:28 ` Peter Zijlstra
2012-04-05 7:36 ` [patch] cgroups: " Mike Galbraith
2012-04-05 8:00 ` David Rientjes
2012-04-14 11:17 ` Peter Zijlstra
2012-04-05 16:11 ` Tejun Heo
2012-04-20 17:57 ` Tejun Heo
2012-04-21 5:31 ` Mike Galbraith
2012-04-21 6:54 ` Li Zefan
2012-04-21 7:13 ` Mike Galbraith
2012-04-23 18:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1204041611430.18500@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mgalbraith@suse.de \
--cc=paul@paulmenage.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).