linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tejun Heo <tj@kernel.org>, Mike Galbraith <mgalbraith@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>, Paul Menage <paul@paulmenage.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Li Zefan <lizefan@huawei.com>
Subject: Re: [patch 0/2] cpusets, cpu_cgroup: disallow attaching kthreadd
Date: Fri, 6 Apr 2012 13:49:39 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1204061347180.23328@chino.kir.corp.google.com> (raw)
In-Reply-To: <1333736770.2960.114.camel@laptop>

On Fri, 6 Apr 2012, Peter Zijlstra wrote:

> Furthermore, the whole point of kthreadd's existence is so that we could
> create kthreads without context. Placing it in a cgroup will ensure all
> subsequently created kthreads do have context (including possible idle
> threads). This seems like a particularly bad idea.
> 

I don't see it as context if the only thing you're doing is accounting 
with memcg (for slab) or or cpu.  We're simply collecting statistics for a 
set of threads (possibly all kthreads, including kthreadd) and the best 
way to do this is leveraging the existing functionality of cgroups to 
setup the threads we want to collect for and the memcg kmem accounting is 
particularly a good indicator of kernel vs userjob-triggered slab 
allocation.

  reply	other threads:[~2012-04-06 20:49 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-03 17:58 [patch] cgroups: disallow attaching kthreadd Mike Galbraith
2012-04-03 18:49 ` Tejun Heo
2012-04-04  2:34   ` Mike Galbraith
2012-04-04 23:06     ` Tejun Heo
2012-04-04 23:10       ` Tejun Heo
2012-04-04  7:15 ` David Rientjes
2012-04-04 10:38   ` Mike Galbraith
2012-04-04 11:29     ` David Rientjes
2012-04-04 12:30       ` Mike Galbraith
2012-04-04 21:17         ` David Rientjes
2012-04-04 23:09           ` Tejun Heo
2012-04-04 23:14             ` David Rientjes
2012-04-05  4:47             ` Mike Galbraith
2012-04-05  4:58               ` David Rientjes
2012-04-05  5:49                 ` Mike Galbraith
2012-04-05  6:07                   ` David Rientjes
2012-04-05  6:42                     ` Mike Galbraith
2012-04-05  6:49                       ` David Rientjes
2012-04-05  7:14                         ` [patch 0/2] cpusets, cpu_cgroup: " David Rientjes
2012-04-05  7:14                           ` [patch 1/2] cpusets: " David Rientjes
2012-04-05  7:14                           ` [patch 2/2] cpu_cgroup: " David Rientjes
2012-04-05 16:08                           ` [patch 0/2] cpusets, " Tejun Heo
2012-04-05 21:26                             ` David Rientjes
2012-04-05 21:37                               ` Tejun Heo
2012-04-05 21:46                                 ` Tejun Heo
2012-04-06  7:50                                   ` Li Zefan
2012-04-06 15:54                                     ` Tejun Heo
2012-04-05 22:03                                 ` David Rientjes
2012-04-05 22:24                                   ` Tejun Heo
2012-04-05 22:31                                     ` Tejun Heo
2012-04-05 22:55                                     ` David Rientjes
2012-04-05 22:58                                       ` Tejun Heo
2012-04-05 23:05                                         ` David Rientjes
2012-04-05 23:13                                           ` Tejun Heo
2012-04-05 23:40                                             ` David Rientjes
2012-04-06 15:52                                               ` Tejun Heo
2012-04-06 18:26                                                 ` Peter Zijlstra
2012-04-06 20:49                                                   ` David Rientjes [this message]
2012-04-07 15:02                                                     ` Hiroyuki Kamezawa
2012-04-10  0:52                                                       ` David Rientjes
2012-04-14 11:35                                                         ` Peter Zijlstra
2012-04-20 17:55                                                         ` Tejun Heo
2012-04-06 20:46                                                 ` David Rientjes
2012-04-14 11:28                                                   ` Peter Zijlstra
2012-04-05  7:36                         ` [patch] cgroups: " Mike Galbraith
2012-04-05  8:00                           ` David Rientjes
2012-04-14 11:17                     ` Peter Zijlstra
2012-04-05 16:11               ` Tejun Heo
2012-04-20 17:57 ` Tejun Heo
2012-04-21  5:31   ` Mike Galbraith
2012-04-21  6:54     ` Li Zefan
2012-04-21  7:13       ` Mike Galbraith
2012-04-23 18:05         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1204061347180.23328@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mgalbraith@suse.de \
    --cc=mingo@redhat.com \
    --cc=paul@paulmenage.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).