From: David Rientjes <rientjes@google.com>
To: Mike Galbraith <mgalbraith@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Menage <paul@paulmenage.org>,
LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>
Subject: [patch 2/2] cpu_cgroup: disallow attaching kthreadd
Date: Thu, 5 Apr 2012 00:14:57 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1204050014100.9466@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204050011550.9466@chino.kir.corp.google.com>
From: Mike Galbraith <efault@gmx.de>
An RT workqueue worker thread spawned in a cpu cgroup with no rt_runtime
allocated is not schedulable. Simple user error, but harmful to the box.
Save the user some unexpected trouble, just say no.
Acked-by: Paul Menage <paul@paulmenage.org>
Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: David Rientjes <rientjes@google.com>
---
kernel/sched/core.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -72,6 +72,7 @@
#include <linux/slab.h>
#include <linux/init_task.h>
#include <linux/binfmts.h>
+#include <linux/kthread.h>
#include <asm/switch_to.h>
#include <asm/tlb.h>
@@ -7636,6 +7637,13 @@ static int cpu_cgroup_can_attach(struct cgroup *cgrp,
if (task->sched_class != &fair_sched_class)
return -EINVAL;
#endif
+ /*
+ * Disallow kthreadd since it can fork workers for an RT
+ * workqueue in a cgroup which may or may not have rt_runtime
+ * allocated.
+ */
+ if (task == kthreadd_task)
+ return -EINVAL;
}
return 0;
}
next prev parent reply other threads:[~2012-04-05 7:15 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 17:58 [patch] cgroups: disallow attaching kthreadd Mike Galbraith
2012-04-03 18:49 ` Tejun Heo
2012-04-04 2:34 ` Mike Galbraith
2012-04-04 23:06 ` Tejun Heo
2012-04-04 23:10 ` Tejun Heo
2012-04-04 7:15 ` David Rientjes
2012-04-04 10:38 ` Mike Galbraith
2012-04-04 11:29 ` David Rientjes
2012-04-04 12:30 ` Mike Galbraith
2012-04-04 21:17 ` David Rientjes
2012-04-04 23:09 ` Tejun Heo
2012-04-04 23:14 ` David Rientjes
2012-04-05 4:47 ` Mike Galbraith
2012-04-05 4:58 ` David Rientjes
2012-04-05 5:49 ` Mike Galbraith
2012-04-05 6:07 ` David Rientjes
2012-04-05 6:42 ` Mike Galbraith
2012-04-05 6:49 ` David Rientjes
2012-04-05 7:14 ` [patch 0/2] cpusets, cpu_cgroup: " David Rientjes
2012-04-05 7:14 ` [patch 1/2] cpusets: " David Rientjes
2012-04-05 7:14 ` David Rientjes [this message]
2012-04-05 16:08 ` [patch 0/2] cpusets, cpu_cgroup: " Tejun Heo
2012-04-05 21:26 ` David Rientjes
2012-04-05 21:37 ` Tejun Heo
2012-04-05 21:46 ` Tejun Heo
2012-04-06 7:50 ` Li Zefan
2012-04-06 15:54 ` Tejun Heo
2012-04-05 22:03 ` David Rientjes
2012-04-05 22:24 ` Tejun Heo
2012-04-05 22:31 ` Tejun Heo
2012-04-05 22:55 ` David Rientjes
2012-04-05 22:58 ` Tejun Heo
2012-04-05 23:05 ` David Rientjes
2012-04-05 23:13 ` Tejun Heo
2012-04-05 23:40 ` David Rientjes
2012-04-06 15:52 ` Tejun Heo
2012-04-06 18:26 ` Peter Zijlstra
2012-04-06 20:49 ` David Rientjes
2012-04-07 15:02 ` Hiroyuki Kamezawa
2012-04-10 0:52 ` David Rientjes
2012-04-14 11:35 ` Peter Zijlstra
2012-04-20 17:55 ` Tejun Heo
2012-04-06 20:46 ` David Rientjes
2012-04-14 11:28 ` Peter Zijlstra
2012-04-05 7:36 ` [patch] cgroups: " Mike Galbraith
2012-04-05 8:00 ` David Rientjes
2012-04-14 11:17 ` Peter Zijlstra
2012-04-05 16:11 ` Tejun Heo
2012-04-20 17:57 ` Tejun Heo
2012-04-21 5:31 ` Mike Galbraith
2012-04-21 6:54 ` Li Zefan
2012-04-21 7:13 ` Mike Galbraith
2012-04-23 18:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1204050014100.9466@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mgalbraith@suse.de \
--cc=mingo@redhat.com \
--cc=paul@paulmenage.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).