* [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions
@ 2016-05-24 13:08 Anna-Maria Gleixner
2016-05-24 18:15 ` David Daney
0 siblings, 1 reply; 3+ messages in thread
From: Anna-Maria Gleixner @ 2016-05-24 13:08 UTC (permalink / raw)
To: linux-kernel; +Cc: rt, Anna-Maria Gleixner, Ralf Baechle, linux-mips
The corresponding FROZEN hotplug notifier transitions used on
suspend/resume are ignored. Therefore the switch case action argument
is masked with the frozen hotplug notifier transition mask.
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
arch/mips/cavium-octeon/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no
{
unsigned int cpu = (unsigned long)hcpu;
- switch (action) {
+ switch (action & ~CPU_TASKS_FROZEN) {
case CPU_UP_PREPARE:
octeon_update_boot_vector(cpu);
break;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions
2016-05-24 13:08 [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions Anna-Maria Gleixner
@ 2016-05-24 18:15 ` David Daney
2016-05-25 9:51 ` Anna-Maria Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: David Daney @ 2016-05-24 18:15 UTC (permalink / raw)
To: Anna-Maria Gleixner; +Cc: linux-kernel, rt, Ralf Baechle, linux-mips
On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote:
> The corresponding FROZEN hotplug notifier transitions used on
> suspend/resume are ignored. Therefore the switch case action argument
> is masked with the frozen hotplug notifier transition mask.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
This seems sane, and I don't object, but can you tell us how this was
tested?
Thanks,
David Daney
> ---
> arch/mips/cavium-octeon/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no
> {
> unsigned int cpu = (unsigned long)hcpu;
>
> - switch (action) {
> + switch (action & ~CPU_TASKS_FROZEN) {
> case CPU_UP_PREPARE:
> octeon_update_boot_vector(cpu);
> break;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions
2016-05-24 18:15 ` David Daney
@ 2016-05-25 9:51 ` Anna-Maria Gleixner
0 siblings, 0 replies; 3+ messages in thread
From: Anna-Maria Gleixner @ 2016-05-25 9:51 UTC (permalink / raw)
To: David Daney; +Cc: linux-kernel, rt, Ralf Baechle, linux-mips
On Tue, 24 May 2016, David Daney wrote:
> On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote:
> > The corresponding FROZEN hotplug notifier transitions used on
> > suspend/resume are ignored. Therefore the switch case action argument
> > is masked with the frozen hotplug notifier transition mask.
> >
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: linux-mips@linux-mips.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
>
> This seems sane, and I don't object, but can you tell us how this was tested?
It is compile tested only due to lack of hardware.
Anna-Maria
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-25 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-24 13:08 [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions Anna-Maria Gleixner
2016-05-24 18:15 ` David Daney
2016-05-25 9:51 ` Anna-Maria Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).