From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code
Date: Mon, 18 Apr 2022 00:02:54 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2204172339300.9383@angie.orcam.me.uk> (raw)
In-Reply-To: <Ylk3HNZqnBLMMQCm@kroah.com>
On Fri, 15 Apr 2022, Greg Kroah-Hartman wrote:
> > Index: linux-macro/include/linux/pci_ids.h
> > ===================================================================
> > --- linux-macro.orig/include/linux/pci_ids.h
> > +++ linux-macro/include/linux/pci_ids.h
> > @@ -2622,6 +2622,9 @@
> > #define PCI_DEVICE_ID_DCI_PCCOM8 0x0002
> > #define PCI_DEVICE_ID_DCI_PCCOM2 0x0004
> >
> > +#define PCI_VENDOR_ID_ENDRUN 0x7401
> > +#define PCI_DEVICE_ID_ENDRUN_1588 0xe100
>
> As per the top of this file, this should not be needed here as you are
> only using it in one file. Please leave it as-is.
I find this requirement silly, but here it's not the place to discuss it,
so I have removed this part as requested. At least it's not inline magic
numbers here.
Maciej
next prev parent reply other threads:[~2022-04-17 23:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 7:11 [RESEND][PATCH v3 0/2] serial: 8250: Fixes for Oxford Semiconductor 950 UARTs Maciej W. Rozycki
2022-03-31 7:11 ` [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code Maciej W. Rozycki
2022-04-15 9:13 ` Greg Kroah-Hartman
2022-04-17 23:02 ` Maciej W. Rozycki [this message]
2022-04-20 14:48 ` Greg Kroah-Hartman
2022-04-21 21:38 ` Maciej W. Rozycki
2022-04-15 9:13 ` Greg Kroah-Hartman
2022-04-17 23:03 ` Maciej W. Rozycki
2022-03-31 7:11 ` [RESEND][PATCH v3 2/2] serial: 8250: Add proper clock handling for OxSemi PCIe devices Maciej W. Rozycki
2022-04-13 22:53 ` [PING][PATCH v3 0/2] serial: 8250: Fixes for Oxford Semiconductor 950 UARTs Maciej W. Rozycki
2022-04-14 12:45 ` Andy Shevchenko
2022-04-14 13:47 ` Maciej W. Rozycki
2022-04-14 13:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2204172339300.9383@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).