From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code
Date: Mon, 18 Apr 2022 00:03:00 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2204172341250.9383@angie.orcam.me.uk> (raw)
In-Reply-To: <Ylk3Q6HyaN/5+97/@kroah.com>
On Fri, 15 Apr 2022, Greg Kroah-Hartman wrote:
> > Remove redundant code then and factor out OxSemi Tornado device
> > detection. Also correct the baud base like with commit 6cbe45d8ac93
> > ("serial: 8250: Correct the clock for OxSemi PCIe devices") for the
> > value of 3906250 rather than 4000000, obtained by dividing the 62.5MHz
> > clock input by the default oversampling rate of 16. Finally move the
> > EndRun vendor:device ID to <linux/pci_ids.h>.
>
> That's a lot of different things happening all the same commit. Please
> break this out into one-patch-per-logical-change as is required.
The baud base fix is completely swallowed by the next change for EndRun
devices, but I guess someone may want to backport it on its own, however
unlikely.
I have posted v4 then with this change split off (and the other removed)
as per your request. I have also reconsidered the changes made in 2/2 and
split it into three, so that drivers/tty/serial/8250/8250_port.c updates
are separate and self-contained.
In the course of the respin, I have realised exporting the ICR access
helpers caused a code generation regression, so I have removed the inline
function specifier so as to let the compiler choose whether to inline the
functions or not. I have also realised that the change to the console
restorer is actually a fix for a preexisting bug in handling of the AFE
bit, so I have annotated the change accordingly.
Thank you for your review.
Maciej
next prev parent reply other threads:[~2022-04-17 23:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 7:11 [RESEND][PATCH v3 0/2] serial: 8250: Fixes for Oxford Semiconductor 950 UARTs Maciej W. Rozycki
2022-03-31 7:11 ` [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code Maciej W. Rozycki
2022-04-15 9:13 ` Greg Kroah-Hartman
2022-04-17 23:02 ` Maciej W. Rozycki
2022-04-20 14:48 ` Greg Kroah-Hartman
2022-04-21 21:38 ` Maciej W. Rozycki
2022-04-15 9:13 ` Greg Kroah-Hartman
2022-04-17 23:03 ` Maciej W. Rozycki [this message]
2022-03-31 7:11 ` [RESEND][PATCH v3 2/2] serial: 8250: Add proper clock handling for OxSemi PCIe devices Maciej W. Rozycki
2022-04-13 22:53 ` [PING][PATCH v3 0/2] serial: 8250: Fixes for Oxford Semiconductor 950 UARTs Maciej W. Rozycki
2022-04-14 12:45 ` Andy Shevchenko
2022-04-14 13:47 ` Maciej W. Rozycki
2022-04-14 13:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2204172341250.9383@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).