* [PATCH] mmc: remove unused 'mode' from the mmc_host structure
@ 2007-12-07 4:12 Nicolas Pitre
2007-12-09 17:01 ` Pierre Ossman
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Pitre @ 2007-12-07 4:12 UTC (permalink / raw)
To: Pierre Ossman; +Cc: lkml
This field and corresponding defines are simply never used anywhere
in the code. But its mere presence is enough to confuse some host
driver authors who attempt to rely on it. Let's eliminate the
possibility for confusion and remove it entirely.
Signed-off-by: Nicolas Pitre <nico@cam.org>
---
yes, it's the second host driver I'm reviewing with this issue...
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 125eee1..7ab962f 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -118,10 +118,6 @@ struct mmc_host {
unsigned int removed:1; /* host is being removed */
#endif
- unsigned int mode; /* current card mode of host */
-#define MMC_MODE_MMC 0
-#define MMC_MODE_SD 1
-
struct mmc_card *card; /* device attached to this host */
wait_queue_head_t wq;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-09 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-07 4:12 [PATCH] mmc: remove unused 'mode' from the mmc_host structure Nicolas Pitre
2007-12-09 17:01 ` Pierre Ossman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).