From: Julian Anastasov <ja@ssi.bg>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Simon Horman <horms@verge.net.au>,
Eric Dumazet <eric.dumazet@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Dipankar Sarma <dipankar@in.ibm.com>
Subject: Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper
Date: Sat, 4 May 2013 10:23:31 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1305041018520.1645@ja.ssi.bg> (raw)
In-Reply-To: <20130503163045.GE3780@linux.vnet.ibm.com>
Hello,
On Fri, 3 May 2013, Paul E. McKenney wrote:
> static inline int cond_resched_rcu(void)
> {
> #if defined(CONFIG_DEBUG_ATOMIC_SLEEP) || !defined(CONFIG_PREEMPT_RCU)
> rcu_read_unlock();
> cond_resched();
> rcu_read_lock();
> #endif
> }
>
> This adds absolutely no overhead in non-debug builds of CONFIG_PREEMPT_RCU,
> does the checking in debug builds, and allows voluntary preemption in
> !CONFIG_PREEMPT_RCU builds. CONFIG_PROVE_RCU builds will check for an
> (illegal) outer rcu_read_lock() in CONFIG_PREEMPT_RCU builds, and you
> will get "scheduling while atomic" in response to an outer rcu_read_lock()
> in !CONFIG_PREEMPT_RCU builds.
>
> It also seems to me a lot simpler.
>
> Does this work, or am I still missing something?
Works perfectly. Thanks! Tested CONFIG_PREEMPT_RCU=y/n,
the errors messages with extra RCU lock.
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2013-05-04 7:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 2:52 [PATCH v2 0/2] sched: Add cond_resched_rcu_lock() helper Simon Horman
2013-04-30 2:52 ` [PATCH v2 1/2] " Simon Horman
2013-04-30 7:12 ` Julian Anastasov
2013-04-30 7:29 ` Simon Horman
2013-04-30 7:52 ` Julian Anastasov
2013-05-01 9:10 ` Peter Zijlstra
2013-05-01 12:46 ` Paul E. McKenney
2013-05-01 14:32 ` Paul E. McKenney
2013-05-02 7:27 ` Peter Zijlstra
2013-05-01 15:17 ` Peter Zijlstra
2013-05-01 15:29 ` Eric Dumazet
2013-05-01 15:59 ` Peter Zijlstra
2013-05-01 16:02 ` Paul E. McKenney
2013-05-01 16:57 ` Peter Zijlstra
2013-05-01 17:30 ` Paul E. McKenney
2013-05-01 14:22 ` Julian Anastasov
2013-05-01 15:55 ` Peter Zijlstra
2013-05-01 18:22 ` Julian Anastasov
2013-05-01 19:04 ` Paul E. McKenney
2013-05-02 7:26 ` Peter Zijlstra
2013-05-02 10:06 ` Julian Anastasov
2013-05-02 15:54 ` Julian Anastasov
2013-05-02 17:32 ` Paul E. McKenney
2013-05-02 18:55 ` Julian Anastasov
2013-05-02 19:24 ` Julian Anastasov
2013-05-02 19:34 ` Paul E. McKenney
2013-05-02 20:19 ` Julian Anastasov
2013-05-02 22:31 ` Paul E. McKenney
2013-05-03 7:52 ` Julian Anastasov
2013-05-03 16:30 ` Paul E. McKenney
2013-05-03 17:04 ` Peter Zijlstra
2013-05-03 17:34 ` Paul E. McKenney
2013-05-03 18:09 ` Peter Zijlstra
2013-05-03 17:47 ` Julian Anastasov
2013-05-04 7:23 ` Julian Anastasov [this message]
2013-05-04 18:03 ` Paul E. McKenney
2013-04-30 2:52 ` [PATCH v2 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1305041018520.1645@ja.ssi.bg \
--to=ja@ssi.bg \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).