* [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC
@ 2020-03-03 11:05 Enric Balletbo i Serra
2020-03-03 16:54 ` Randy Dunlap
2020-03-03 17:07 ` Applied "ASoC: amd: AMD RV RT5682 should depends on CROS_EC" to the asoc tree Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-03-03 11:05 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, Randy Dunlap, Jaroslav Kysela, alsa-devel,
Akshu Agrawal, Mark Brown, Thomas Gleixner, Takashi Iwai,
Liam Girdwood, Greg Kroah-Hartman, YueHaibing
If SND_SOC_AMD_RV_RT5682_MACH=y, below kconfig and build errors can be seen:
WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
WARNING: unmet direct dependencies detected for I2C_CROS_EC_TUNNEL
ld: drivers/i2c/busses/i2c-cros-ec-tunnel.o: in function `ec_i2c_xfer':
i2c-cros-ec-tunnel.c:(.text+0x2fc): undefined reference to `cros_ec_cmd_xfer_status'
ld: sound/soc/codecs/cros_ec_codec.o: in function `wov_host_event':
cros_ec_codec.c:(.text+0x4fb): undefined reference to `cros_ec_get_host_event'
ld: sound/soc/codecs/cros_ec_codec.o: in function `send_ec_host_command':
cros_ec_codec.c:(.text+0x831): undefined reference to `cros_ec_cmd_xfer_status'
This is because it will select SND_SOC_CROS_EC_CODEC and I2c_CROS_EC_TUNNEL but
both depends on CROS_EC.
Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index b29ef1373946..bce4cee5cb54 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -33,6 +33,6 @@ config SND_SOC_AMD_RV_RT5682_MACH
select SND_SOC_MAX98357A
select SND_SOC_CROS_EC_CODEC
select I2C_CROS_EC_TUNNEL
- depends on SND_SOC_AMD_ACP3x && I2C
+ depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
help
This option enables machine driver for RT5682 and MAX9835.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC
2020-03-03 11:05 [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC Enric Balletbo i Serra
@ 2020-03-03 16:54 ` Randy Dunlap
2020-03-03 17:07 ` Applied "ASoC: amd: AMD RV RT5682 should depends on CROS_EC" to the asoc tree Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-03-03 16:54 UTC (permalink / raw)
To: Enric Balletbo i Serra, linux-kernel
Cc: Collabora Kernel ML, Jaroslav Kysela, alsa-devel, Akshu Agrawal,
Mark Brown, Thomas Gleixner, Takashi Iwai, Liam Girdwood,
Greg Kroah-Hartman, YueHaibing
On 3/3/20 3:05 AM, Enric Balletbo i Serra wrote:
> If SND_SOC_AMD_RV_RT5682_MACH=y, below kconfig and build errors can be seen:
>
> WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
> WARNING: unmet direct dependencies detected for I2C_CROS_EC_TUNNEL
>
> ld: drivers/i2c/busses/i2c-cros-ec-tunnel.o: in function `ec_i2c_xfer':
> i2c-cros-ec-tunnel.c:(.text+0x2fc): undefined reference to `cros_ec_cmd_xfer_status'
> ld: sound/soc/codecs/cros_ec_codec.o: in function `wov_host_event':
> cros_ec_codec.c:(.text+0x4fb): undefined reference to `cros_ec_get_host_event'
> ld: sound/soc/codecs/cros_ec_codec.o: in function `send_ec_host_command':
> cros_ec_codec.c:(.text+0x831): undefined reference to `cros_ec_cmd_xfer_status'
>
> This is because it will select SND_SOC_CROS_EC_CODEC and I2c_CROS_EC_TUNNEL but
> both depends on CROS_EC.
>
> Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
>
> sound/soc/amd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index b29ef1373946..bce4cee5cb54 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -33,6 +33,6 @@ config SND_SOC_AMD_RV_RT5682_MACH
> select SND_SOC_MAX98357A
> select SND_SOC_CROS_EC_CODEC
> select I2C_CROS_EC_TUNNEL
> - depends on SND_SOC_AMD_ACP3x && I2C
> + depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
> help
> This option enables machine driver for RT5682 and MAX9835.
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Applied "ASoC: amd: AMD RV RT5682 should depends on CROS_EC" to the asoc tree
2020-03-03 11:05 [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC Enric Balletbo i Serra
2020-03-03 16:54 ` Randy Dunlap
@ 2020-03-03 17:07 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-03-03 17:07 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Akshu Agrawal, alsa-devel, Collabora Kernel ML,
Greg Kroah-Hartman, Liam Girdwood, linux-kernel, Mark Brown,
Randy Dunlap, Takashi Iwai, Thomas Gleixner, YueHaibing
The patch
ASoC: amd: AMD RV RT5682 should depends on CROS_EC
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From e7e2afeacaa6e6b3d428ca8dd0507f1098bafe5d Mon Sep 17 00:00:00 2001
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Date: Tue, 3 Mar 2020 12:05:14 +0100
Subject: [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC
If SND_SOC_AMD_RV_RT5682_MACH=y, below kconfig and build errors can be seen:
WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
WARNING: unmet direct dependencies detected for I2C_CROS_EC_TUNNEL
ld: drivers/i2c/busses/i2c-cros-ec-tunnel.o: in function `ec_i2c_xfer':
i2c-cros-ec-tunnel.c:(.text+0x2fc): undefined reference to `cros_ec_cmd_xfer_status'
ld: sound/soc/codecs/cros_ec_codec.o: in function `wov_host_event':
cros_ec_codec.c:(.text+0x4fb): undefined reference to `cros_ec_get_host_event'
ld: sound/soc/codecs/cros_ec_codec.o: in function `send_ec_host_command':
cros_ec_codec.c:(.text+0x831): undefined reference to `cros_ec_cmd_xfer_status'
This is because it will select SND_SOC_CROS_EC_CODEC and I2c_CROS_EC_TUNNEL but
both depends on CROS_EC.
Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200303110514.3267126-1-enric.balletbo@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index b29ef1373946..bce4cee5cb54 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -33,6 +33,6 @@ config SND_SOC_AMD_RV_RT5682_MACH
select SND_SOC_MAX98357A
select SND_SOC_CROS_EC_CODEC
select I2C_CROS_EC_TUNNEL
- depends on SND_SOC_AMD_ACP3x && I2C
+ depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
help
This option enables machine driver for RT5682 and MAX9835.
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-03 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 11:05 [PATCH] ASoC: amd: AMD RV RT5682 should depends on CROS_EC Enric Balletbo i Serra
2020-03-03 16:54 ` Randy Dunlap
2020-03-03 17:07 ` Applied "ASoC: amd: AMD RV RT5682 should depends on CROS_EC" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).