From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: <arnd@arndb.de>, <robh+dt@kernel.org>,
Marek Vasut <marex@denx.de>, <jagan@amarulasolutions.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Marcin Sloniewski <marcin.sloniewski@gmail.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-kernel@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>,
<kuba@kernel.org>
Subject: Re: [PATCH 09/13] ARM: dts: stm32: fix stpmic node for stm32mp1 boards
Date: Thu, 10 Jun 2021 16:33:26 +0200 [thread overview]
Message-ID: <b155f309-0bfb-3fa5-4b2b-c0128f6981b5@foss.st.com> (raw)
In-Reply-To: <20210415101037.1465-10-alexandre.torgue@foss.st.com>
On 4/15/21 12:10 PM, Alexandre Torgue wrote:
> On some STM32 MP15 boards, stpmic node is not correct which generates
> warnings running "make dtbs_check W=1" command. Issues are:
>
> -"regulator-active-discharge" is not a boolean but an uint32.
> -"regulator-over-current-protection" is not a valid entry for vref_ddr.
> -LDO4 has a fixed voltage (3v3) so min/max entries are not allowed.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
Applied on stm32-next.
Thanks.
Alex
>
> diff --git a/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi b/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi
> index 113c48b2ef93..a4b14ef3caee 100644
> --- a/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157a-stinger96.dtsi
> @@ -184,8 +184,6 @@
>
> vdd_usb: ldo4 {
> regulator-name = "vdd_usb";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> interrupts = <IT_CURLIM_LDO4 0>;
> };
>
> @@ -208,7 +206,6 @@
> vref_ddr: vref_ddr {
> regulator-name = "vref_ddr";
> regulator-always-on;
> - regulator-over-current-protection;
> };
>
> bst_out: boost {
> @@ -219,13 +216,13 @@
> vbus_otg: pwr_sw1 {
> regulator-name = "vbus_otg";
> interrupts = <IT_OCP_OTG 0>;
> - regulator-active-discharge;
> + regulator-active-discharge = <1>;
> };
>
> vbus_sw: pwr_sw2 {
> regulator-name = "vbus_sw";
> interrupts = <IT_OCP_SWOUT 0>;
> - regulator-active-discharge;
> + regulator-active-discharge = <1>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi b/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi
> index 6cf49a0a9e69..0c0b66788ea1 100644
> --- a/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c-odyssey-som.dtsi
> @@ -173,8 +173,6 @@
>
> vdd_usb: ldo4 {
> regulator-name = "vdd_usb";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> interrupts = <IT_CURLIM_LDO4 0>;
> };
>
> @@ -197,7 +195,6 @@
> vref_ddr: vref_ddr {
> regulator-name = "vref_ddr";
> regulator-always-on;
> - regulator-over-current-protection;
> };
>
> bst_out: boost {
> @@ -213,7 +210,7 @@
> vbus_sw: pwr_sw2 {
> regulator-name = "vbus_sw";
> interrupts = <IT_OCP_SWOUT 0>;
> - regulator-active-discharge;
> + regulator-active-discharge = <1>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
> index 272a1a67a9ad..769fcf74685a 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
> @@ -327,8 +327,6 @@
>
> vdd_usb: ldo4 {
> regulator-name = "vdd_usb";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> interrupts = <IT_CURLIM_LDO4 0>;
> };
>
> @@ -350,7 +348,6 @@
> vref_ddr: vref_ddr {
> regulator-name = "vref_ddr";
> regulator-always-on;
> - regulator-over-current-protection;
> };
>
> bst_out: boost {
> @@ -366,7 +363,7 @@
> vbus_sw: pwr_sw2 {
> regulator-name = "vbus_sw";
> interrupts = <IT_OCP_SWOUT 0>;
> - regulator-active-discharge;
> + regulator-active-discharge = <1>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index 713485a95795..6706d8311a66 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -146,8 +146,6 @@
>
> vdd_usb: ldo4 {
> regulator-name = "vdd_usb";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> interrupts = <IT_CURLIM_LDO4 0>;
> };
>
> @@ -171,7 +169,6 @@
> vref_ddr: vref_ddr {
> regulator-name = "vref_ddr";
> regulator-always-on;
> - regulator-over-current-protection;
> };
>
> bst_out: boost {
> @@ -182,13 +179,13 @@
> vbus_otg: pwr_sw1 {
> regulator-name = "vbus_otg";
> interrupts = <IT_OCP_OTG 0>;
> - regulator-active-discharge;
> + regulator-active-discharge = <1>;
> };
>
> vbus_sw: pwr_sw2 {
> regulator-name = "vbus_sw";
> interrupts = <IT_OCP_SWOUT 0>;
> - regulator-active-discharge;
> + regulator-active-discharge = <1>;
> };
> };
>
>
next prev parent reply other threads:[~2021-06-10 14:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:10 [PATCH 00/13] ARM: dts: stm32: fix "make dtbs_check W=1" round1 Alexandre Torgue
2021-04-15 10:10 ` [PATCH 01/13] ARM: dts: stm32: fix gpio-keys node on STM32 MCU boards Alexandre Torgue
2021-04-15 10:10 ` [PATCH 02/13] ARM: dts: stm32: fix RCC node name on stm32f429 MCU Alexandre Torgue
2021-04-15 10:10 ` [PATCH 03/13] ARM: dts: stm32: fix timer nodes on STM32 MCU to prevent warnings Alexandre Torgue
2021-04-16 15:52 ` [Linux-stm32] " Fabrice Gasnier
2021-04-15 10:10 ` [PATCH 04/13] dt-bindings: mfd: stm32-timers: remove #address/size cells from required properties Alexandre Torgue
2021-04-16 15:52 ` [Linux-stm32] " Fabrice Gasnier
2021-04-20 20:04 ` Rob Herring
2021-06-01 16:26 ` Lee Jones
2021-04-15 10:10 ` [PATCH 05/13] ARM: dts: stm32: update pinctrl node name on STM32 MCU to prevent warnings Alexandre Torgue
2021-04-15 10:10 ` [PATCH 06/13] ARM: dts: stm32: fix i2c node name on stm32f746 " Alexandre Torgue
2021-04-15 10:10 ` [PATCH 07/13] ARM: dts: stm32: move stmmac axi config in ethernet node on stm32mp15 Alexandre Torgue
2021-04-15 10:10 ` [PATCH 08/13] dt-bindings: net: document ptp_ref clk in dwmac Alexandre Torgue
2021-04-20 20:05 ` Rob Herring
2021-04-15 10:10 ` [PATCH 09/13] ARM: dts: stm32: fix stpmic node for stm32mp1 boards Alexandre Torgue
2021-06-10 14:33 ` Alexandre TORGUE [this message]
2021-04-15 10:10 ` [PATCH 10/13] dt-bindings: mfd: add vref_ddr-supply to st,stpmic1 yaml Alexandre Torgue
2021-04-15 10:51 ` Ahmad Fatoum
2021-04-15 12:12 ` Alexandre TORGUE
2021-04-15 10:10 ` [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU Alexandre Torgue
2021-04-15 13:21 ` Marek Vasut
2021-04-15 13:34 ` Alexandre TORGUE
2021-04-15 14:30 ` Marek Vasut
2021-04-15 14:35 ` Alexandre TORGUE
2021-04-15 14:59 ` Marek Vasut
2021-04-15 10:10 ` [PATCH 12/13] ARM: dts: stm32: fix DSI port node on STM32MP15 Alexandre Torgue
2021-04-15 10:43 ` Ahmad Fatoum
2021-04-15 12:23 ` Alexandre TORGUE
2021-04-19 13:57 ` Arnd Bergmann
2021-04-19 14:04 ` Alexandre TORGUE
2021-05-04 13:16 ` Ahmad Fatoum
2021-04-15 10:10 ` [PATCH 13/13] ARM: dts: stm32: fix ltdc pinctrl on microdev2.0-of7 Alexandre Torgue
2021-06-01 10:37 ` [PATCH 00/13] ARM: dts: stm32: fix "make dtbs_check W=1" round1 Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b155f309-0bfb-3fa5-4b2b-c0128f6981b5@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=a.fatoum@pengutronix.de \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marcin.sloniewski@gmail.com \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).