From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Wang Qing <wangqing@vivo.com>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Mark Brown <broonie@kernel.org>,
Tzung-Bi Shih <tzungbi@google.com>,
Pi-Hsun Shih <pihsun@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform_data: ti: fix a typo
Date: Tue, 29 Sep 2020 09:54:59 +0200 [thread overview]
Message-ID: <b2b61349-db5c-07dd-0d55-84d7a7d54492@collabora.com> (raw)
In-Reply-To: <1601088620-16070-1-git-send-email-wangqing@vivo.com>
Hi Wang Qing,
Thank you for your patch.
On 26/9/20 4:49, Wang Qing wrote:
> Modify the typo: "compliment" -> "complement".
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> include/linux/platform_data/cros_ec_commands.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index 1fcfe9e..42203ce
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -261,12 +261,12 @@
> /* Memory space version; set to EC_ACPI_MEM_VERSION_CURRENT */
> #define EC_ACPI_MEM_VERSION 0x00
> /*
> - * Test location; writing value here updates test compliment byte to (0xff -
> + * Test location; writing value here updates test complement byte to (0xff -
> * value).
> */
> #define EC_ACPI_MEM_TEST 0x01
> -/* Test compliment; writes here are ignored. */
> -#define EC_ACPI_MEM_TEST_COMPLIMENT 0x02
> +/* Test complement; writes here are ignored. */
> +#define EC_ACPI_MEM_TEST_COMPLEMENT 0x02
>
Although there is a typo, we did an effort to have cros_ec_command synced with
ec commands in the firmware code, so I'd like to see this change also applied on
the EC code. Do you mind to populate this change in the EC firmware code [1], please
[1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master
Thanks,
Enric
> /* Keyboard backlight brightness percent (0 - 100) */
> #define EC_ACPI_MEM_KEYBOARD_BACKLIGHT 0x03
>
prev parent reply other threads:[~2020-09-29 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 2:49 [PATCH] platform_data: ti: fix a typo Wang Qing
2020-09-29 7:54 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b61349-db5c-07dd-0d55-84d7a7d54492@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pihsun@chromium.org \
--cc=pmalani@chromium.org \
--cc=tzungbi@google.com \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).