* [PATCH] platform_data: ti: fix a typo
@ 2020-09-26 2:49 Wang Qing
2020-09-29 7:54 ` Enric Balletbo i Serra
0 siblings, 1 reply; 2+ messages in thread
From: Wang Qing @ 2020-09-26 2:49 UTC (permalink / raw)
To: Benson Leung, Enric Balletbo i Serra, Guenter Roeck, Mark Brown,
Tzung-Bi Shih, Pi-Hsun Shih, Prashant Malani, Wang Qing,
linux-kernel
Modify the typo: "compliment" -> "complement".
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
include/linux/platform_data/cros_ec_commands.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
index 1fcfe9e..42203ce
--- a/include/linux/platform_data/cros_ec_commands.h
+++ b/include/linux/platform_data/cros_ec_commands.h
@@ -261,12 +261,12 @@
/* Memory space version; set to EC_ACPI_MEM_VERSION_CURRENT */
#define EC_ACPI_MEM_VERSION 0x00
/*
- * Test location; writing value here updates test compliment byte to (0xff -
+ * Test location; writing value here updates test complement byte to (0xff -
* value).
*/
#define EC_ACPI_MEM_TEST 0x01
-/* Test compliment; writes here are ignored. */
-#define EC_ACPI_MEM_TEST_COMPLIMENT 0x02
+/* Test complement; writes here are ignored. */
+#define EC_ACPI_MEM_TEST_COMPLEMENT 0x02
/* Keyboard backlight brightness percent (0 - 100) */
#define EC_ACPI_MEM_KEYBOARD_BACKLIGHT 0x03
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform_data: ti: fix a typo
2020-09-26 2:49 [PATCH] platform_data: ti: fix a typo Wang Qing
@ 2020-09-29 7:54 ` Enric Balletbo i Serra
0 siblings, 0 replies; 2+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-29 7:54 UTC (permalink / raw)
To: Wang Qing, Benson Leung, Guenter Roeck, Mark Brown,
Tzung-Bi Shih, Pi-Hsun Shih, Prashant Malani, linux-kernel
Hi Wang Qing,
Thank you for your patch.
On 26/9/20 4:49, Wang Qing wrote:
> Modify the typo: "compliment" -> "complement".
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> include/linux/platform_data/cros_ec_commands.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index 1fcfe9e..42203ce
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -261,12 +261,12 @@
> /* Memory space version; set to EC_ACPI_MEM_VERSION_CURRENT */
> #define EC_ACPI_MEM_VERSION 0x00
> /*
> - * Test location; writing value here updates test compliment byte to (0xff -
> + * Test location; writing value here updates test complement byte to (0xff -
> * value).
> */
> #define EC_ACPI_MEM_TEST 0x01
> -/* Test compliment; writes here are ignored. */
> -#define EC_ACPI_MEM_TEST_COMPLIMENT 0x02
> +/* Test complement; writes here are ignored. */
> +#define EC_ACPI_MEM_TEST_COMPLEMENT 0x02
>
Although there is a typo, we did an effort to have cros_ec_command synced with
ec commands in the firmware code, so I'd like to see this change also applied on
the EC code. Do you mind to populate this change in the EC firmware code [1], please
[1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master
Thanks,
Enric
> /* Keyboard backlight brightness percent (0 - 100) */
> #define EC_ACPI_MEM_KEYBOARD_BACKLIGHT 0x03
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-29 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26 2:49 [PATCH] platform_data: ti: fix a typo Wang Qing
2020-09-29 7:54 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).