From: Julian Wiedmann <jwiedmann.dev@gmail.com>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Shay Agroskin <shayagr@amazon.com>
Cc: netdev@vger.kernel.org, Arthur Kiyanovski <akiyano@amazon.com>,
David Arinzon <darinzon@amazon.com>,
Noam Dagan <ndagan@amazon.com>, Saeed Bishara <saeedb@amazon.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Wei Yongjun <weiyongjun1@huawei.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ena: Do not waste napi skb cache
Date: Tue, 25 Jan 2022 15:50:30 +0200 [thread overview]
Message-ID: <bad34ba9-eacf-f325-7ebc-6fdd43414945@gmail.com> (raw)
In-Reply-To: <Ye/EQgqCBogZR87T@ip-172-31-19-208.ap-northeast-1.compute.internal>
On 25.01.22 11:34, Hyeonggon Yoo wrote:
> On Mon, Jan 24, 2022 at 10:50:05PM +0200, Shay Agroskin wrote:
>>
[...]
>>
>> I agree that the netdev_alloc_skb_ip_align() can become napi_alloc_skb().
>> Hyeonggon Yoo, can you please apply this change as well to this patch?
>>
>
> Okay. I'll update and test it again.
>
> BTW, It seems netdev_alloc_skb_ip_align() is used to make some fields
> be aligned. It's okay to just ignore this?
>
napi_alloc_skb() adds NET_IP_ALIGN internally, so you end up with the same alignment as before.
> Thanks,
> Hyeonggon.
>
>> Thanks,
>> Shay
>>
>>
>>>>> else
>>>>> - skb = build_skb(first_frag, ENA_PAGE_SIZE);
>>>>> + skb = napi_build_skb(first_frag, ENA_PAGE_SIZE);
>>>>> if (unlikely(!skb)) {
>>>>> ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail, 1,
>>>>
next prev parent reply other threads:[~2022-01-25 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 11:56 [PATCH] net: ena: Do not waste napi skb cache Hyeonggon Yoo
2022-01-24 8:57 ` Julian Wiedmann
2022-01-24 9:29 ` Julian Wiedmann
2022-01-24 20:50 ` Shay Agroskin
2022-01-25 9:34 ` Hyeonggon Yoo
2022-01-25 13:50 ` Julian Wiedmann [this message]
2022-01-29 8:56 ` Hyeonggon Yoo
2022-01-25 13:45 ` Julian Wiedmann
2022-01-26 13:16 ` [PATCH v2] " Hyeonggon Yoo
2022-01-26 15:16 ` Shay Agroskin
2022-01-26 15:52 ` Jakub Kicinski
2022-01-29 8:55 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bad34ba9-eacf-f325-7ebc-6fdd43414945@gmail.com \
--to=jwiedmann.dev@gmail.com \
--cc=42.hyeyoo@gmail.com \
--cc=akiyano@amazon.com \
--cc=daniel@iogearbox.net \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).