From: Shay Agroskin <shayagr@amazon.com>
To: Julian Wiedmann <jwiedmann.dev@gmail.com>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, <netdev@vger.kernel.org>,
"Arthur Kiyanovski" <akiyano@amazon.com>,
David Arinzon <darinzon@amazon.com>,
"Noam Dagan" <ndagan@amazon.com>,
Saeed Bishara <saeedb@amazon.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
Sameeh Jubran <sameehj@amazon.com>,
"Wei Yongjun" <weiyongjun1@huawei.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ena: Do not waste napi skb cache
Date: Mon, 24 Jan 2022 22:50:05 +0200 [thread overview]
Message-ID: <pj41zlmtjk7t9a.fsf@u570694869fb251.ant.amazon.com> (raw)
In-Reply-To: <5cca8bdd-bed0-f26a-6c96-d18947d3a50b@gmail.com>
Julian Wiedmann <jwiedmann.dev@gmail.com> writes:
> On 24.01.22 10:57, Julian Wiedmann wrote:
>> On 23.01.22 13:56, Hyeonggon Yoo wrote:
>>> By profiling, discovered that ena device driver allocates skb
>>> by
>>> build_skb() and frees by napi_skb_cache_put(). Because the
>>> driver
>>> does not use napi skb cache in allocation path, napi skb cache
>>> is
>>> periodically filled and flushed. This is waste of napi skb
>>> cache.
>>>
>>> As ena_alloc_skb() is called only in napi, Use
>>> napi_build_skb()
>>> instead of build_skb() to when allocating skb.
>>>
>>> This patch was tested on aws a1.metal instance.
>>>
>>> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
>>> ---
>>> drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
>>> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
>>> index c72f0c7ff4aa..2c67fb1703c5 100644
>>> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
>>> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
>>> @@ -1407,7 +1407,7 @@ static struct sk_buff
>>> *ena_alloc_skb(struct ena_ring *rx_ring, void *first_frag)
>>> skb = netdev_alloc_skb_ip_align(rx_ring->netdev,
>>> rx_ring->rx_copybreak);
>>
>> To keep things consistent, this should then also be
>> napi_alloc_skb().
>>
>
> And on closer look, this copybreak path also looks buggy. If
> rx_copybreak
> gets reduced _while_ receiving a frame, the allocated skb can
> end up too
> small to take all the data.
>
> @ ena maintainers: can you please fix this?
>
Updating the copybreak value is done through ena_ethtool.c
(ena_set_tunable()) which updates `adapter->rx_copybreak`.
The adapter->rx_copybreak value is "propagated back" to the ring
local attributes (rx_ring->rx_copybreak) only after an interface
toggle which stops the napi routine first.
Unless I'm missing something here I don't think the bug you're
describing exists.
I agree that the netdev_alloc_skb_ip_align() can become
napi_alloc_skb(). Hyeonggon Yoo, can you please apply this change
as well to this patch?
Thanks,
Shay
>>> else
>>> - skb = build_skb(first_frag, ENA_PAGE_SIZE);
>>> + skb = napi_build_skb(first_frag, ENA_PAGE_SIZE);
>>>
>>> if (unlikely(!skb)) {
>>> ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail,
>>> 1,
>>
next prev parent reply other threads:[~2022-01-24 21:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 11:56 [PATCH] net: ena: Do not waste napi skb cache Hyeonggon Yoo
2022-01-24 8:57 ` Julian Wiedmann
2022-01-24 9:29 ` Julian Wiedmann
2022-01-24 20:50 ` Shay Agroskin [this message]
2022-01-25 9:34 ` Hyeonggon Yoo
2022-01-25 13:50 ` Julian Wiedmann
2022-01-29 8:56 ` Hyeonggon Yoo
2022-01-25 13:45 ` Julian Wiedmann
2022-01-26 13:16 ` [PATCH v2] " Hyeonggon Yoo
2022-01-26 15:16 ` Shay Agroskin
2022-01-26 15:52 ` Jakub Kicinski
2022-01-29 8:55 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pj41zlmtjk7t9a.fsf@u570694869fb251.ant.amazon.com \
--to=shayagr@amazon.com \
--cc=42.hyeyoo@gmail.com \
--cc=akiyano@amazon.com \
--cc=daniel@iogearbox.net \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=jwiedmann.dev@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).