* [PATCH] virtio-balloon: Use virtio_find_vqs() helper
@ 2021-07-13 15:38 Xianting Tian
2021-07-16 12:46 ` tianxianting
0 siblings, 1 reply; 8+ messages in thread
From: Xianting Tian @ 2021-07-13 15:38 UTC (permalink / raw)
To: mst, jasowang, david; +Cc: virtualization, linux-kernel, Xianting Tian
From: Xianting Tian <xianting.tian@linux.alibaba.com>
Use the helper virtio_find_vqs().
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
drivers/virtio/virtio_balloon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 510e931..18e0bf3 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
}
- err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX,
- vqs, callbacks, names, NULL, NULL);
+ err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
+ callbacks, names, NULL);
if (err)
return err;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
2021-07-13 15:38 [PATCH] virtio-balloon: Use virtio_find_vqs() helper Xianting Tian
@ 2021-07-16 12:46 ` tianxianting
2021-07-16 12:53 ` David Hildenbrand
2021-07-19 3:46 ` Jason Wang
0 siblings, 2 replies; 8+ messages in thread
From: tianxianting @ 2021-07-16 12:46 UTC (permalink / raw)
To: Xianting Tian, mst, jasowang, david; +Cc: virtualization, linux-kernel
Do you interest in this patch? just little improvment:)
在 2021/7/13 下午11:38, Xianting Tian 写道:
> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>
> Use the helper virtio_find_vqs().
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---
> drivers/virtio/virtio_balloon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 510e931..18e0bf3 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
> }
>
> - err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX,
> - vqs, callbacks, names, NULL, NULL);
> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
> + callbacks, names, NULL);
> if (err)
> return err;
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
2021-07-16 12:46 ` tianxianting
@ 2021-07-16 12:53 ` David Hildenbrand
2021-07-16 13:10 ` David Hildenbrand
2021-07-19 3:46 ` Jason Wang
1 sibling, 1 reply; 8+ messages in thread
From: David Hildenbrand @ 2021-07-16 12:53 UTC (permalink / raw)
To: tianxianting, Xianting Tian, mst, jasowang; +Cc: virtualization, linux-kernel
On 16.07.21 14:46, tianxianting wrote:
> Do you interest in this patch? just little improvment:)
I am, especially when I'm cc'ed and aware of it ;)
Reviewed-by: David Hildenbrand <david@redhat.com>
One nit below
>
> 在 2021/7/13 下午11:38, Xianting Tian 写道:
>> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>>
>> Use the helper virtio_find_vqs().
>>
>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>> ---
>> drivers/virtio/virtio_balloon.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
>> index 510e931..18e0bf3 100644
>> --- a/drivers/virtio/virtio_balloon.c
>> +++ b/drivers/virtio/virtio_balloon.c
>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
>> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
>> }
>>
>> - err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX,
>> - vqs, callbacks, names, NULL, NULL);
>> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
>> + callbacks, names, NULL);
^
we tend to indent this such that it is aligned with the line above (see
the old code), unless the code becomes unreadable
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
2021-07-16 12:53 ` David Hildenbrand
@ 2021-07-16 13:10 ` David Hildenbrand
2021-07-16 14:18 ` tianxianting
0 siblings, 1 reply; 8+ messages in thread
From: David Hildenbrand @ 2021-07-16 13:10 UTC (permalink / raw)
To: tianxianting, Xianting Tian, mst, jasowang; +Cc: virtualization, linux-kernel
On 16.07.21 14:53, David Hildenbrand wrote:
> On 16.07.21 14:46, tianxianting wrote:
>> Do you interest in this patch? just little improvment:)
>
> I am, especially when I'm cc'ed and aware of it ;)
>
Sorry, just found it in my gmail spam folder ... WTH. Why does the
original one get filtered but not your ping ...
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
2021-07-16 13:10 ` David Hildenbrand
@ 2021-07-16 14:18 ` tianxianting
0 siblings, 0 replies; 8+ messages in thread
From: tianxianting @ 2021-07-16 14:18 UTC (permalink / raw)
To: David Hildenbrand, Xianting Tian, mst, jasowang
Cc: virtualization, linux-kernel
you really were in the “to” list of my original email：）
在 2021/7/16 下午9:10, David Hildenbrand 写道:
> On 16.07.21 14:53, David Hildenbrand wrote:
>> On 16.07.21 14:46, tianxianting wrote:
>>> Do you interest in this patch? just little improvment:)
>>
>> I am, especially when I'm cc'ed and aware of it ;)
>>
>
> Sorry, just found it in my gmail spam folder ... WTH. Why does the
> original one get filtered but not your ping ...
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
2021-07-16 12:46 ` tianxianting
2021-07-16 12:53 ` David Hildenbrand
@ 2021-07-19 3:46 ` Jason Wang
2021-07-19 4:22 ` tianxianting
1 sibling, 1 reply; 8+ messages in thread
From: Jason Wang @ 2021-07-19 3:46 UTC (permalink / raw)
To: tianxianting, Xianting Tian, mst, david; +Cc: virtualization, linux-kernel
在 2021/7/16 下午8:46, tianxianting 写道:
> Do you interest in this patch? just little improvment:)
>
> 在 2021/7/13 下午11:38, Xianting Tian 写道:
>> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>>
>> Use the helper virtio_find_vqs().
>>
>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>> ---
>> drivers/virtio/virtio_balloon.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_balloon.c
>> b/drivers/virtio/virtio_balloon.c
>> index 510e931..18e0bf3 100644
>> --- a/drivers/virtio/virtio_balloon.c
>> +++ b/drivers/virtio/virtio_balloon.c
>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
>> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
>> }
>> - err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX,
>> - vqs, callbacks, names, NULL, NULL);
>> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
>> + callbacks, names, NULL);
>> if (err)
>> return err;
>
Acked-by: Jason Wang <jasowang@redhat.com>
Maybe it's better to convert all the drivers that doesn't use
virtio_find_vqs{_ctx}.
Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
2021-07-19 3:46 ` Jason Wang
@ 2021-07-19 4:22 ` tianxianting
2021-07-20 2:41 ` Jason Wang
0 siblings, 1 reply; 8+ messages in thread
From: tianxianting @ 2021-07-19 4:22 UTC (permalink / raw)
To: Jason Wang, Xianting Tian, mst, david; +Cc: virtualization, linux-kernel
thanks,
I checked, actually all virtio drivers have switched to use the helper
after this one merged.
在 2021/7/19 上午11:46, Jason Wang 写道:
>
> 在 2021/7/16 下午8:46, tianxianting 写道:
>> Do you interest in this patch? just little improvment:)
>>
>> 在 2021/7/13 下午11:38, Xianting Tian 写道:
>>> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>>>
>>> Use the helper virtio_find_vqs().
>>>
>>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>>> ---
>>> drivers/virtio/virtio_balloon.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/virtio/virtio_balloon.c
>>> b/drivers/virtio/virtio_balloon.c
>>> index 510e931..18e0bf3 100644
>>> --- a/drivers/virtio/virtio_balloon.c
>>> +++ b/drivers/virtio/virtio_balloon.c
>>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
>>> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
>>> }
>>> - err = vb->vdev->config->find_vqs(vb->vdev,
>>> VIRTIO_BALLOON_VQ_MAX,
>>> - vqs, callbacks, names, NULL, NULL);
>>> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
>>> + callbacks, names, NULL);
>>> if (err)
>>> return err;
>>
>
> Acked-by: Jason Wang <jasowang@redhat.com>
>
> Maybe it's better to convert all the drivers that doesn't use
> virtio_find_vqs{_ctx}.
>
> Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper
2021-07-19 4:22 ` tianxianting
@ 2021-07-20 2:41 ` Jason Wang
0 siblings, 0 replies; 8+ messages in thread
From: Jason Wang @ 2021-07-20 2:41 UTC (permalink / raw)
To: tianxianting, Xianting Tian, mst, david; +Cc: virtualization, linux-kernel
在 2021/7/19 下午12:22, tianxianting 写道:
> thanks,
>
> I checked, actually all virtio drivers have switched to use the helper
> after this one merged.
Ok. Cool.
Thanks
>
> 在 2021/7/19 上午11:46, Jason Wang 写道:
>>
>> 在 2021/7/16 下午8:46, tianxianting 写道:
>>> Do you interest in this patch? just little improvment:)
>>>
>>> 在 2021/7/13 下午11:38, Xianting Tian 写道:
>>>> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>>>>
>>>> Use the helper virtio_find_vqs().
>>>>
>>>> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>>>> ---
>>>> drivers/virtio/virtio_balloon.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/virtio/virtio_balloon.c
>>>> b/drivers/virtio/virtio_balloon.c
>>>> index 510e931..18e0bf3 100644
>>>> --- a/drivers/virtio/virtio_balloon.c
>>>> +++ b/drivers/virtio/virtio_balloon.c
>>>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
>>>> callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
>>>> }
>>>> - err = vb->vdev->config->find_vqs(vb->vdev,
>>>> VIRTIO_BALLOON_VQ_MAX,
>>>> - vqs, callbacks, names, NULL, NULL);
>>>> + err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
>>>> + callbacks, names, NULL);
>>>> if (err)
>>>> return err;
>>>
>>
>> Acked-by: Jason Wang <jasowang@redhat.com>
>>
>> Maybe it's better to convert all the drivers that doesn't use
>> virtio_find_vqs{_ctx}.
>>
>> Thanks
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-20 2:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 15:38 [PATCH] virtio-balloon: Use virtio_find_vqs() helper Xianting Tian
2021-07-16 12:46 ` tianxianting
2021-07-16 12:53 ` David Hildenbrand
2021-07-16 13:10 ` David Hildenbrand
2021-07-16 14:18 ` tianxianting
2021-07-19 3:46 ` Jason Wang
2021-07-19 4:22 ` tianxianting
2021-07-20 2:41 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).