* [PATCH] video: fbdev: vesafb: fix indentation issue @ 2019-02-12 13:29 ` Colin King 2019-02-15 10:00 ` Joe Perches 2019-04-01 11:48 ` Bartlomiej Zolnierkiewicz 0 siblings, 2 replies; 3+ messages in thread From: Colin King @ 2019-02-12 13:29 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev Cc: kernel-janitors, linux-kernel From: Colin Ian King <colin.king@canonical.com> There are a couple of statements that are indented too deeply, fix this by removing tabs. Also add a space after a comma to clean up a cppcheck warning. Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/video/fbdev/vesafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c index 528fe917dd49..b7388e25aa2a 100644 --- a/drivers/video/fbdev/vesafb.c +++ b/drivers/video/fbdev/vesafb.c @@ -336,8 +336,8 @@ static int vesafb_probe(struct platform_device *dev) printk(KERN_INFO "vesafb: pmi: set display start = %p, set palette = %p\n",pmi_start,pmi_pal); if (pmi_base[3]) { printk(KERN_INFO "vesafb: pmi: ports = "); - for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++) - printk("%x ",pmi_base[i]); + for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++) + printk("%x ", pmi_base[i]); printk("\n"); if (pmi_base[i] != 0xffff) { /* -- 2.20.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: vesafb: fix indentation issue 2019-02-12 13:29 ` [PATCH] video: fbdev: vesafb: fix indentation issue Colin King @ 2019-02-15 10:00 ` Joe Perches 2019-04-01 11:48 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 3+ messages in thread From: Joe Perches @ 2019-02-15 10:00 UTC (permalink / raw) To: Colin King, Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev Cc: kernel-janitors, linux-kernel On Tue, 2019-02-12 at 13:29 +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are a couple of statements that are indented too deeply, fix > this by removing tabs. Also add a space after a comma to clean up > a cppcheck warning. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/video/fbdev/vesafb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c > index 528fe917dd49..b7388e25aa2a 100644 > --- a/drivers/video/fbdev/vesafb.c > +++ b/drivers/video/fbdev/vesafb.c > @@ -336,8 +336,8 @@ static int vesafb_probe(struct platform_device *dev) > printk(KERN_INFO "vesafb: pmi: set display start = %p, set palette = %p\n",pmi_start,pmi_pal); > if (pmi_base[3]) { > printk(KERN_INFO "vesafb: pmi: ports = "); > - for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++) > - printk("%x ",pmi_base[i]); > + for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++) > + printk("%x ", pmi_base[i]); > printk("\n"); > if (pmi_base[i] != 0xffff) { > /* Perhaps you could also use pr_cont too because otherwise this emits each printk on separate lines. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: vesafb: fix indentation issue 2019-02-12 13:29 ` [PATCH] video: fbdev: vesafb: fix indentation issue Colin King 2019-02-15 10:00 ` Joe Perches @ 2019-04-01 11:48 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 3+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-04-01 11:48 UTC (permalink / raw) To: Colin King; +Cc: dri-devel, linux-fbdev, kernel-janitors, linux-kernel On 02/12/2019 02:29 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are a couple of statements that are indented too deeply, fix > this by removing tabs. Also add a space after a comma to clean up > a cppcheck warning. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-01 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190212132918epcas1p4211cd6eb2d090c8ccd2996ee0d13ca78@epcas1p4.samsung.com>
2019-02-12 13:29 ` [PATCH] video: fbdev: vesafb: fix indentation issue Colin King
2019-02-15 10:00 ` Joe Perches
2019-04-01 11:48 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).