linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Julius Werner <jwerner@chromium.org>
Cc: Rob Herring <robh@kernel.org>,
	linux-tegra@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v5 3/9] dt-bindings: memory: lpddr2: Add revision-id properties
Date: Wed, 9 Feb 2022 14:49:10 +0300	[thread overview]
Message-ID: <c33c9de2-ff0f-0ba7-b424-728d316dcca2@gmail.com> (raw)
In-Reply-To: <6568fd31-113f-1581-4eff-45a4a1eb4e5d@canonical.com>

09.02.2022 11:58, Krzysztof Kozlowski пишет:
> On 09/02/2022 00:46, Julius Werner wrote:
>>> Unfortunately I have no clue what patch you talk about ("this patch").
>>> There is no context here, no link except the older LPDDR3.
>>
>> Sorry, I tried to reply to
>> https://lore.kernel.org/all/20211006224659.21434-4-digetx@gmail.com/
>> ([PATCH v5 3/9] dt-bindings: memory: lpddr2: Add revision-id
>> properties) and was hoping that would automatically provide context.
>> That patch added two one-cell properties `revision-id1` and
>> `revision-id2` to "jedec,lpddr2". Earlier in
>> https://www.spinics.net/lists/devicetree/msg413733.html ([PATCH]
>> dt-bindings: ddr: Add optional manufacturer and revision ID to
>> LPDDR3), I had added a single two-cell property `revision-id` for the
>> same purpose to "jedec,lpddr3".
>>
>> I think it would be better if this was consistent between the two
>> types of LPDDR memory. Should I just send a patch that replaces the
>> two revision IDs in "jedec,lpddr2" with a single one according to the
>> principle of "jedec,lpddr3"? Or is it too late for that now and the
>> binding already considered stable and unchangeable?
> 
> Hi Julius,
> 
> Having same bindings for revision ID makes sense. Sadly this was not
> spotted during review, eh, life... Unfortunately the bindings are
> already in a mainline release, so they are considered stable. You can
> however bring patches (bindings + drivers/memory/of + dts) which make
> the revision-id[12] deprecated and introduce new revision-id.
> 
> It should be something similar to what I did for max-freq:
> https://lore.kernel.org/all/20220206135807.211767-7-krzysztof.kozlowski@canonical.com/
> 
> Dmitry,
> Any early comments on such approach from you?

I don't mind, but I also don't see where the revision-id property of
LPDDR3 is used at all. I can't find any device-tree with LPDDR3
revision-id and don't see it being used in the code either. Maybe it's
the LPDDR3 binding that needs to be changed?
I made each LPDDR2 revision-id property to correspond to a dedicated MR
of LPDDR, which feels okay to me to since it matches h/w.

  reply	other threads:[~2022-02-09 12:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 22:46 [PATCH v5 0/9] tegra20-emc: Identify memory chip by LPDDR configuration Dmitry Osipenko
2021-10-06 22:46 ` [PATCH v5 1/9] dt-bindings: Relocate DDR bindings Dmitry Osipenko
2021-10-14 21:22   ` Rob Herring
2021-10-06 22:46 ` [PATCH v5 2/9] dt-bindings: memory: lpddr2: Convert to schema Dmitry Osipenko
2021-10-14 21:50   ` Rob Herring
2021-10-06 22:46 ` [PATCH v5 3/9] dt-bindings: memory: lpddr2: Add revision-id properties Dmitry Osipenko
2021-10-14 21:51   ` Rob Herring
2022-02-08  2:06     ` Julius Werner
2022-02-08  8:10       ` Krzysztof Kozlowski
2022-02-08 23:46         ` Julius Werner
2022-02-09  8:58           ` Krzysztof Kozlowski
2022-02-09 11:49             ` Dmitry Osipenko [this message]
2022-02-10  0:32               ` Julius Werner
2022-02-10 23:17                 ` Dmitry Osipenko
2022-02-11  7:55                   ` Krzysztof Kozlowski
2021-10-06 22:46 ` [PATCH v5 4/9] dt-bindings: memory: lpddr2: Document Elpida B8132B2PB-6D-F Dmitry Osipenko
2021-10-14 21:51   ` Rob Herring
2021-10-06 22:46 ` [PATCH v5 5/9] dt-bindings: Add vendor prefix for Elpida Memory Dmitry Osipenko
2021-10-14 21:51   ` Rob Herring
2021-10-06 22:46 ` [PATCH v5 6/9] ARM: dts: elpida_ecb240abacn: Change Elpida compatible Dmitry Osipenko
2021-10-06 22:46 ` [PATCH v5 7/9] dt-bindings: memory: tegra20: emc: Document new LPDDR2 sub-node Dmitry Osipenko
2021-10-14 21:52   ` Rob Herring
2021-10-06 22:46 ` [PATCH v5 8/9] memory: Add LPDDR2-info helpers Dmitry Osipenko
2021-10-06 22:46 ` [PATCH v5 9/9] memory: tegra20-emc: Support matching timings by LPDDR2 configuration Dmitry Osipenko
2021-10-15  7:20 ` [PATCH v5 0/9] tegra20-emc: Identify memory chip by LPDDR configuration Krzysztof Kozlowski
2021-10-18 18:10   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c33c9de2-ff0f-0ba7-b424-728d316dcca2@gmail.com \
    --to=digetx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=jwerner@chromium.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).