From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Atish Patra <atish.patra@wdc.com>,
Yash Shah <yash.shah@sifive.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Piotr Sroka <piotrs@cadence.com>,
Linux MMC List <linux-mmc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 4/6] riscv: microchip: mpfs: fix board compatible
Date: Tue, 24 Aug 2021 21:05:03 +0200 [thread overview]
Message-ID: <c9c9d21f-e820-de1e-b5a6-cd6054dda3ec@canonical.com> (raw)
In-Reply-To: <CAMuHMdX8dBiYadAN8OQpds_bMbLReJy+u6apGe=RZzfEE=BJbw@mail.gmail.com>
On 24/08/2021 17:29, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Thu, Aug 19, 2021 at 5:45 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>> According to bindings, the compatible must include microchip,mpfs. This
>> fixes dtbs_check warning:
>>
>> arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: /: compatible: ['microchip,mpfs-icicle-kit'] is too short
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Thanks for your patch!
>
>> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
>> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
>> @@ -10,7 +10,7 @@
>>
>> / {
>> model = "Microchip PolarFire-SoC Icicle Kit";
>> - compatible = "microchip,mpfs-icicle-kit";
>> + compatible = "microchip,mpfs-icicle-kit", "microchip,mpfs";
>
> I have the same change in my local tree, but didn't get to submit it
> yet, so this part is fine ;-)
>
>>
>> chosen {
>> stdout-path = &serial0;
>> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> index b9819570a7d1..cb54da0cc3c4 100644
>> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
>> @@ -7,7 +7,7 @@ / {
>> #address-cells = <2>;
>> #size-cells = <2>;
>> model = "Microchip MPFS Icicle Kit";
>> - compatible = "microchip,mpfs-icicle-kit";
>> + compatible = "microchip,mpfs-icicle-kit", "microchip,mpfs";
>
> As this file is the SoC .dtsi, not the board DTS for the full
> Icicle Kit, the compatible value should be just "microchip,mpfs"
> (to be augmented by the board DTS).
> And "model" should be "Microchip PolarFire SoC".
Sounds good, I'll fix it in v2.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-08-24 19:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 15:44 [PATCH 1/6] dt-bindings: riscv: correct e51 and u54-mc CPU bindings Krzysztof Kozlowski
2021-08-19 15:44 ` [PATCH 2/6] dt-bindings: mmc: cdns: match MPFS MMC/SDHCI controller Krzysztof Kozlowski
2021-08-24 14:33 ` Rob Herring
2021-08-24 19:02 ` Krzysztof Kozlowski
2021-08-30 15:09 ` Rob Herring
2021-09-06 8:38 ` Conor.Dooley
2021-09-08 7:37 ` Krzysztof Kozlowski
2021-08-19 15:44 ` [PATCH 3/6] riscv: microchip: mpfs: drop duplicated nodes Krzysztof Kozlowski
2021-08-19 16:21 ` Krzysztof Kozlowski
2021-08-24 15:32 ` Geert Uytterhoeven
2021-08-19 15:44 ` [PATCH 4/6] riscv: microchip: mpfs: fix board compatible Krzysztof Kozlowski
2021-08-24 15:29 ` Geert Uytterhoeven
2021-08-24 19:05 ` Krzysztof Kozlowski [this message]
2021-08-19 15:44 ` [PATCH 5/6] riscv: microchip: mpfs: drop duplicated MMC/SDHC node Krzysztof Kozlowski
2021-08-24 15:37 ` Geert Uytterhoeven
2021-08-24 19:07 ` Krzysztof Kozlowski
2021-08-19 15:44 ` [PATCH 6/6] riscv: microchip: mpfs: drop unused pinctrl-names Krzysztof Kozlowski
2021-08-24 15:34 ` Geert Uytterhoeven
2021-08-24 14:34 ` [PATCH 1/6] dt-bindings: riscv: correct e51 and u54-mc CPU bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c9d21f-e820-de1e-b5a6-cd6054dda3ec@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=piotrs@cadence.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).