From: Dan Murphy <dmurphy@ti.com>
To: Wolfgang Grandegger <wg@grandegger.com>, <mkl@pengutronix.de>,
<davem@davemloft.net>
Cc: <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 0/5] M_CAN Framework re-write
Date: Thu, 28 Feb 2019 10:44:18 -0600 [thread overview]
Message-ID: <caf997cb-25b9-e3b0-3767-173d7c9a4d22@ti.com> (raw)
In-Reply-To: <10baf726-7783-1783-caaa-d7b78be2d9a0@grandegger.com>
Wolfgang
On 2/28/19 10:40 AM, Wolfgang Grandegger wrote:
> Hello,
>
> Am 14.02.19 um 19:27 schrieb Dan Murphy:
>> Hello
>>
>> OK I did not give up on this patch series just got a little preoccupied with
>> some other kernel work. But here is the update per the comments.
>>
>> It should be understood I broke these out for reviewability.
>> For instance the first patch does not compile on its own as including this
>> patch should not change the current functionality and it pulls all the io-mapped
>> code from the m_can base file to a platfrom file.
>
> For git bisection, the code must compile!
>
So I can squash patch 1 and 2 then.
>> The next patch "Migrate the m_can code to use the framework"
>> is the change to the kernel for the io-mapped conversion from a flat file to use
>> the framework. Finally the rename patch just renames the m_can_priv to
>> m_can_classdev. I broke this change out specifically for readability of the
>> migration patch per comments on the code.
>>
>> AFAIC the first 3 patches can all be squashed into a single patch. Or the
>> first 2 patches in the series can be re-arranged but then m_can functionality is
>> affected in the migration patch.
>
> For the reason above, I would squash patch 1 and 2.
>
>>
>> Again the first 3 patches here are all just for readability and review purposes.>
>> Dan
>>
>> Dan Murphy (5):
>> can: m_can: Create a m_can platform framework
>> can: m_can: Migrate the m_can code to use the framework
>> can: m_can: Rename m_can_priv to m_can_classdev
>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver
>> can: tcan4x5x: Add tcan4x5x driver to the kernel
>>
>> .../devicetree/bindings/net/can/tcan4x5x.txt | 37 +
>> drivers/net/can/m_can/Kconfig | 14 +-
>> drivers/net/can/m_can/Makefile | 2 +
>> drivers/net/can/m_can/m_can.c | 788 +++++++++---------
>> drivers/net/can/m_can/m_can.h | 159 ++++
>> drivers/net/can/m_can/m_can_platform.c | 198 +++++
>> drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++
>> 7 files changed, 1320 insertions(+), 409 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> create mode 100644 drivers/net/can/m_can/m_can.h
>> create mode 100644 drivers/net/can/m_can/m_can_platform.c
>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c
>
> There are plenty of coding-style errors, e.g. white-space, indention,
> line too long, etc. Please use "checkpatch" to find and fix.
>
Ack. I missed running it on v5. I will update in v6.
> Wolfgang.
>
>
>
--
------------------
Dan Murphy
prev parent reply other threads:[~2019-02-28 16:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 18:27 [PATCH v5 0/5] M_CAN Framework re-write Dan Murphy
2019-02-14 18:27 ` [PATCH v5 1/5] can: m_can: Create a m_can platform framework Dan Murphy
2019-02-28 20:12 ` Wolfgang Grandegger
2019-02-28 20:18 ` Dan Murphy
2019-02-14 18:27 ` [PATCH v5 2/5] can: m_can: Migrate the m_can code to use the framework Dan Murphy
2019-02-28 17:33 ` Wolfgang Grandegger
2019-02-28 17:57 ` Dan Murphy
2019-02-28 19:41 ` Wolfgang Grandegger
2019-02-28 19:59 ` Dan Murphy
2019-02-14 18:27 ` [PATCH v5 3/5] can: m_can: Rename m_can_priv to m_can_classdev Dan Murphy
2019-02-14 18:27 ` [PATCH v5 4/5] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy
2019-02-14 18:27 ` [PATCH v5 5/5] can: tcan4x5x: Add tcan4x5x driver to the kernel Dan Murphy
2019-02-28 17:50 ` Wolfgang Grandegger
2019-02-28 18:03 ` Dan Murphy
2019-02-28 20:07 ` Wolfgang Grandegger
2019-02-28 20:14 ` Dan Murphy
2019-02-21 16:24 ` [PATCH v5 0/5] M_CAN Framework re-write Dan Murphy
2019-02-21 16:41 ` Wolfgang Grandegger
2019-02-22 9:38 ` Wolfgang Grandegger
2019-02-22 12:50 ` Dan Murphy
2019-02-22 17:05 ` Dan Murphy
2019-02-24 11:27 ` Wolfgang Grandegger
2019-02-28 15:39 ` Dan Murphy
2019-02-28 16:40 ` Wolfgang Grandegger
2019-02-28 16:44 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf997cb-25b9-e3b0-3767-173d7c9a4d22@ti.com \
--to=dmurphy@ti.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).