* [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD)
@ 2023-12-11 1:52 Michael T. Kloos
2023-12-11 2:03 ` Mario Limonciello
0 siblings, 1 reply; 3+ messages in thread
From: Michael T. Kloos @ 2023-12-11 1:52 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Mario Limonciello, Jeremy Soller, Syed Saba Kareem,
August Wikerfors, Vijendar Mukunda
Cc: linux-sound, linux-kernel, Michael T. Kloos
Added System Board to Quirks List using model number prefix.
Replaced/Removed a duplicate entry in the list.
Added Yellow Carp Coprocessor Revision number to PCI revision check.
Signed-off-by: Michael T. Kloos <michael@michaelkloos.com>
---
sound/soc/amd/yc/acp6x-mach.c | 2 +-
sound/soc/amd/yc/pci-acp6x.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index d83cb6e4c62a..c08605d99bc9 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -56,7 +56,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
.driver_data = &acp6x_card,
.matches = {
DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
- DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
}
},
{
diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 7af6a349b1d4..694b8e313902 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -162,6 +162,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
/* Yellow Carp device check */
switch (pci->revision) {
case 0x60:
+ case 0x63:
case 0x6f:
break;
default:
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD)
2023-12-11 1:52 [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD) Michael T. Kloos
@ 2023-12-11 2:03 ` Mario Limonciello
2023-12-11 2:48 ` Michael T. Kloos
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2023-12-11 2:03 UTC (permalink / raw)
To: Michael T. Kloos, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeremy Soller, Syed Saba Kareem, August Wikerfors,
Vijendar Mukunda
Cc: linux-sound, linux-kernel
On 12/10/2023 19:52, Michael T. Kloos wrote:
> Added System Board to Quirks List using model number prefix.
> Replaced/Removed a duplicate entry in the list.
> Added Yellow Carp Coprocessor Revision number to PCI revision check.
>
> Signed-off-by: Michael T. Kloos <michael@michaelkloos.com>
NAK.
This is supposed to be supported by ACP 6.3 (Pink Sardine). Did you
enable that driver?
Can you please share more about your problem?
> ---
> sound/soc/amd/yc/acp6x-mach.c | 2 +-
> sound/soc/amd/yc/pci-acp6x.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index d83cb6e4c62a..c08605d99bc9 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -56,7 +56,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
> .driver_data = &acp6x_card,
> .matches = {
> DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "21K5"),
> }
> },
> {
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 7af6a349b1d4..694b8e313902 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -162,6 +162,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> /* Yellow Carp device check */
> switch (pci->revision) {
> case 0x60:
> + case 0x63:
> case 0x6f:
> break;
> default:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD)
2023-12-11 2:03 ` Mario Limonciello
@ 2023-12-11 2:48 ` Michael T. Kloos
0 siblings, 0 replies; 3+ messages in thread
From: Michael T. Kloos @ 2023-12-11 2:48 UTC (permalink / raw)
To: Mario Limonciello, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Jeremy Soller, Syed Saba Kareem, August Wikerfors,
Vijendar Mukunda
Cc: linux-sound, linux-kernel
> This is supposed to be supported by ACP 6.3 (Pink Sardine). Did you
> enable that driver?
> Can you please share more about your problem?
Enabled it and it is now working. I wish I knew that 24 hours ago.
Would have saved a lot of time and effort. Haha. Disregard the patch.
Thank you, Mario.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-11 2:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 1:52 [PATCH] ASoC: Enable built-in microphone on Lenovo ThinkPad P14s Gen 4 (AMD) Michael T. Kloos
2023-12-11 2:03 ` Mario Limonciello
2023-12-11 2:48 ` Michael T. Kloos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).