From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode
Date: Fri, 16 Jun 2023 14:23:11 -0700 [thread overview]
Message-ID: <ccda5b11-b074-5500-7c0e-ebb4b025d960@quicinc.com> (raw)
In-Reply-To: <3a6cc492-6b54-2c70-402e-995c0b003c01@linaro.org>
On 6/14/2023 12:49 AM, Dmitry Baryshkov wrote:
> On 14/06/2023 04:57, Jessica Zhang wrote:
>> DSI 6G v2.5.x+ supports a data-bus widen mode that allows DSI to send
>> 48 bits of compressed data per pclk instead of 24.
>>
>> For all chipsets that support this mode, enable it whenever DSC is
>> enabled as recommend by the hardware programming guide.
>>
>> Only enable this for command mode as we are currently unable to validate
>> it for video mode.
>>
>> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>> ---
>>
>> Note: The dsi.xml.h changes were generated using the headergen2 script in
>> envytools [1], but the changes to the copyright and rules-ng-ng source
>> file
>> paths were dropped.
>>
>> [1] https://github.com/freedreno/envytools/
>>
>> drivers/gpu/drm/msm/dsi/dsi.xml.h | 1 +
>> drivers/gpu/drm/msm/dsi/dsi_host.c | 19 ++++++++++++++++++-
>> 2 files changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi.xml.h
>> b/drivers/gpu/drm/msm/dsi/dsi.xml.h
>> index a4a154601114..2a7d980e12c3 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi.xml.h
>> +++ b/drivers/gpu/drm/msm/dsi/dsi.xml.h
>> @@ -664,6 +664,7 @@ static inline uint32_t
>> DSI_CMD_MODE_MDP_CTRL2_INPUT_RGB_SWAP(enum dsi_rgb_swap v
>> return ((val) << DSI_CMD_MODE_MDP_CTRL2_INPUT_RGB_SWAP__SHIFT) &
>> DSI_CMD_MODE_MDP_CTRL2_INPUT_RGB_SWAP__MASK;
>> }
>> #define DSI_CMD_MODE_MDP_CTRL2_BURST_MODE 0x00010000
>> +#define DSI_CMD_MODE_MDP_CTRL2_DATABUS_WIDEN 0x00100000
>>
>> #define REG_DSI_CMD_MODE_MDP_STREAM2_CTRL 0x000001b8
>> #define DSI_CMD_MODE_MDP_STREAM2_CTRL_DATA_TYPE__MASK 0x0000003f
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> index 5d7b4409e4e9..1da5238e7105 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> @@ -927,6 +927,9 @@ static void dsi_timing_setup(struct msm_dsi_host
>> *msm_host, bool is_bonded_dsi)
>> u32 hdisplay = mode->hdisplay;
>> u32 wc;
>> int ret;
>> + bool widebus_supported = msm_host->cfg_hnd->major ==
>> MSM_DSI_VER_MAJOR_6G &&
>> + msm_host->cfg_hnd->minor >= MSM_DSI_6G_VER_MINOR_V2_5_0;
>> +
>>
>> DBG("");
>>
>> @@ -973,8 +976,15 @@ static void dsi_timing_setup(struct msm_dsi_host
>> *msm_host, bool is_bonded_dsi)
>> *
>> * hdisplay will be divided by 3 here to account for the fact
>> * that DPU sends 3 bytes per pclk cycle to DSI.
>> + *
>> + * If widebus is supported, set DATABUS_WIDEN register and
>> divide hdisplay by 6
>> + * instead of 3
>
> This is useless, it is already obvious from the code below. Instead
> there should be something like "wide bus extends that to 6 bytes per
> pclk cycle"
>
>> */
>> - hdisplay =
>> DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3);
>> + if (!(msm_host->mode_flags & MIPI_DSI_MODE_VIDEO) &&
>> widebus_supported)
>> + hdisplay =
>> DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 6);
>> + else
>> + hdisplay =
>> DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3);
>> +
>> h_total += hdisplay;
>> ha_end = ha_start + hdisplay;
>> }
>> @@ -1027,6 +1037,13 @@ static void dsi_timing_setup(struct
>> msm_dsi_host *msm_host, bool is_bonded_dsi)
>> dsi_write(msm_host, REG_DSI_CMD_MDP_STREAM0_TOTAL,
>> DSI_CMD_MDP_STREAM0_TOTAL_H_TOTAL(hdisplay) |
>> DSI_CMD_MDP_STREAM0_TOTAL_V_TOTAL(mode->vdisplay));
>> +
>> + if (msm_host->dsc && widebus_supported) {
>> + u32 mdp_ctrl2 = dsi_read(msm_host,
>> REG_DSI_CMD_MODE_MDP_CTRL2);
>> +
>> + mdp_ctrl2 |= DSI_CMD_MODE_MDP_CTRL2_DATABUS_WIDEN;
>> + dsi_write(msm_host, REG_DSI_CMD_MODE_MDP_CTRL2, mdp_ctrl2);
>
> Is widebus applicable only to the CMD mode, or video mode can employ it
> too?
Video mode can employ it too but like Jessica said in the commit text,
we dont have a setup to validate this for DSI video mode so it was
restricted to cmd mode.
We can leave a note here too.
>
>> + }
>> }
>> }
>>
>>
>> --
>> 2.40.1
>>
>
next prev parent reply other threads:[~2023-06-16 21:23 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 1:57 [PATCH 0/3] Add support for databus widen mode Jessica Zhang
2023-06-14 1:57 ` [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0 Jessica Zhang
2023-06-14 7:50 ` Dmitry Baryshkov
2023-06-14 11:42 ` Marijn Suijten
2023-06-14 12:01 ` Dmitry Baryshkov
2023-06-14 12:23 ` Marijn Suijten
2023-06-14 19:35 ` Abhinav Kumar
2023-06-14 19:54 ` Abhinav Kumar
2023-06-14 20:39 ` [Freedreno] " Abhinav Kumar
2023-06-14 20:43 ` Dmitry Baryshkov
2023-06-16 21:10 ` Abhinav Kumar
2023-06-17 0:37 ` Dmitry Baryshkov
2023-06-20 21:37 ` Jessica Zhang
2023-06-20 22:11 ` Dmitry Baryshkov
2023-06-20 23:37 ` Jessica Zhang
2023-06-14 21:41 ` Marijn Suijten
2023-06-16 21:13 ` Abhinav Kumar
2023-06-16 21:58 ` Marijn Suijten
2023-06-14 22:49 ` Marijn Suijten
2023-06-16 21:06 ` Abhinav Kumar
2023-06-16 22:00 ` Marijn Suijten
2023-06-14 1:57 ` [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders Jessica Zhang
2023-06-14 7:56 ` Dmitry Baryshkov
2023-06-16 21:18 ` Abhinav Kumar
2023-06-16 21:54 ` Marijn Suijten
2023-06-17 0:35 ` Dmitry Baryshkov
2023-06-20 21:38 ` Jessica Zhang
2023-06-20 22:10 ` Dmitry Baryshkov
2023-06-21 15:17 ` Marijn Suijten
2023-06-21 16:36 ` Dmitry Baryshkov
2023-06-21 19:00 ` Marijn Suijten
2023-06-21 23:01 ` Abhinav Kumar
2023-06-21 23:46 ` Dmitry Baryshkov
2023-06-22 22:37 ` Abhinav Kumar
2023-06-22 23:14 ` Dmitry Baryshkov
2023-06-22 23:37 ` [Freedreno] " Abhinav Kumar
2023-06-29 17:26 ` Abhinav Kumar
2023-06-29 17:37 ` Jessica Zhang
2023-06-14 1:57 ` [PATCH 3/3] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode Jessica Zhang
2023-06-14 7:49 ` Dmitry Baryshkov
2023-06-14 10:03 ` Marijn Suijten
2023-06-22 23:04 ` Abhinav Kumar
2023-06-23 7:02 ` Marijn Suijten
2023-06-16 21:23 ` Abhinav Kumar [this message]
2023-06-14 9:56 ` Marijn Suijten
2023-06-23 0:01 ` [Freedreno] " Abhinav Kumar
2023-06-23 0:41 ` Dmitry Baryshkov
2023-06-23 7:19 ` Marijn Suijten
2023-06-23 17:29 ` Abhinav Kumar
2023-06-23 20:14 ` Marijn Suijten
2023-06-23 20:34 ` Abhinav Kumar
2023-06-23 21:33 ` Marijn Suijten
2023-06-23 21:47 ` Abhinav Kumar
2023-06-14 10:09 ` [PATCH 0/3] Add support for databus widen mode Marijn Suijten
2023-06-16 11:30 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccda5b11-b074-5500-7c0e-ebb4b025d960@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).