From: Marijn Suijten <marijn.suijten@somainline.org>
To: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
quic_abhinavk@quicinc.com, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0
Date: Wed, 14 Jun 2023 13:42:41 +0200 [thread overview]
Message-ID: <wpjxrnhbcanbc5iatxnff25yrrdfrtmgb24sgwyo457dz2oyjz@e2docpcb6337> (raw)
In-Reply-To: <20230525-add-widebus-support-v1-1-c7069f2efca1@quicinc.com>
On 2023-06-13 18:57:11, Jessica Zhang wrote:
> DPU 5.x+ supports a databus widen mode that allows more data to be sent
> per pclk. Enable this feature flag on all relevant chipsets.
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 ++-
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 36ba3f58dcdf..0be7bf0bfc41 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -103,7 +103,8 @@
> (BIT(DPU_INTF_INPUT_CTRL) | \
> BIT(DPU_INTF_TE) | \
> BIT(DPU_INTF_STATUS_SUPPORTED) | \
> - BIT(DPU_DATA_HCTL_EN))
> + BIT(DPU_DATA_HCTL_EN) | \
> + BIT(DPU_INTF_DATABUS_WIDEN))
This doesn't work. DPU 5.0.0 is SM8150, which has DSI 6G 2.3. In the
last patch for DSI you state and enable widebus for DSI 6G 2.5+ only,
meaning DPU and DSI are now desynced, and the output is completely
corrupted.
Is the bound in dsi_host wrong, or do DPU and DSI need to communicate
when widebus will be enabled, based on DPU && DSI supporting it?
- Marijn
> #define INTF_SC7280_MASK (INTF_SC7180_MASK | BIT(DPU_INTF_DATA_COMPRESS))
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> index b860784ade72..b9939e00f5e0 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> @@ -182,6 +182,7 @@ enum {
> * than video timing
> * @DPU_INTF_STATUS_SUPPORTED INTF block has INTF_STATUS register
> * @DPU_INTF_DATA_COMPRESS INTF block has DATA_COMPRESS register
> + * @DPU_INTF_DATABUS_WIDEN INTF block has DATABUS_WIDEN register
> * @DPU_INTF_MAX
> */
> enum {
> @@ -190,6 +191,7 @@ enum {
> DPU_DATA_HCTL_EN,
> DPU_INTF_STATUS_SUPPORTED,
> DPU_INTF_DATA_COMPRESS,
> + DPU_INTF_DATABUS_WIDEN,
> DPU_INTF_MAX
> };
>
>
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-06-14 11:43 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 1:57 [PATCH 0/3] Add support for databus widen mode Jessica Zhang
2023-06-14 1:57 ` [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0 Jessica Zhang
2023-06-14 7:50 ` Dmitry Baryshkov
2023-06-14 11:42 ` Marijn Suijten [this message]
2023-06-14 12:01 ` Dmitry Baryshkov
2023-06-14 12:23 ` Marijn Suijten
2023-06-14 19:35 ` Abhinav Kumar
2023-06-14 19:54 ` Abhinav Kumar
2023-06-14 20:39 ` [Freedreno] " Abhinav Kumar
2023-06-14 20:43 ` Dmitry Baryshkov
2023-06-16 21:10 ` Abhinav Kumar
2023-06-17 0:37 ` Dmitry Baryshkov
2023-06-20 21:37 ` Jessica Zhang
2023-06-20 22:11 ` Dmitry Baryshkov
2023-06-20 23:37 ` Jessica Zhang
2023-06-14 21:41 ` Marijn Suijten
2023-06-16 21:13 ` Abhinav Kumar
2023-06-16 21:58 ` Marijn Suijten
2023-06-14 22:49 ` Marijn Suijten
2023-06-16 21:06 ` Abhinav Kumar
2023-06-16 22:00 ` Marijn Suijten
2023-06-14 1:57 ` [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders Jessica Zhang
2023-06-14 7:56 ` Dmitry Baryshkov
2023-06-16 21:18 ` Abhinav Kumar
2023-06-16 21:54 ` Marijn Suijten
2023-06-17 0:35 ` Dmitry Baryshkov
2023-06-20 21:38 ` Jessica Zhang
2023-06-20 22:10 ` Dmitry Baryshkov
2023-06-21 15:17 ` Marijn Suijten
2023-06-21 16:36 ` Dmitry Baryshkov
2023-06-21 19:00 ` Marijn Suijten
2023-06-21 23:01 ` Abhinav Kumar
2023-06-21 23:46 ` Dmitry Baryshkov
2023-06-22 22:37 ` Abhinav Kumar
2023-06-22 23:14 ` Dmitry Baryshkov
2023-06-22 23:37 ` [Freedreno] " Abhinav Kumar
2023-06-29 17:26 ` Abhinav Kumar
2023-06-29 17:37 ` Jessica Zhang
2023-06-14 1:57 ` [PATCH 3/3] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode Jessica Zhang
2023-06-14 7:49 ` Dmitry Baryshkov
2023-06-14 10:03 ` Marijn Suijten
2023-06-22 23:04 ` Abhinav Kumar
2023-06-23 7:02 ` Marijn Suijten
2023-06-16 21:23 ` Abhinav Kumar
2023-06-14 9:56 ` Marijn Suijten
2023-06-23 0:01 ` [Freedreno] " Abhinav Kumar
2023-06-23 0:41 ` Dmitry Baryshkov
2023-06-23 7:19 ` Marijn Suijten
2023-06-23 17:29 ` Abhinav Kumar
2023-06-23 20:14 ` Marijn Suijten
2023-06-23 20:34 ` Abhinav Kumar
2023-06-23 21:33 ` Marijn Suijten
2023-06-23 21:47 ` Abhinav Kumar
2023-06-14 10:09 ` [PATCH 0/3] Add support for databus widen mode Marijn Suijten
2023-06-16 11:30 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wpjxrnhbcanbc5iatxnff25yrrdfrtmgb24sgwyo457dz2oyjz@e2docpcb6337 \
--to=marijn.suijten@somainline.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).