[PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

[PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 26 Apr 2017 17:24:56 +0200

Three update suggestions were taken into account
from static source code analysis.

Markus Elfring (3):
  Use devm_kcalloc() in ti_bandgap_build()
  Delete error messages for failed memory allocations in ti_bandgap_build()
  Fix a typo in a comment line

 drivers/thermal/ti-soc-thermal/ti-bandgap.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

-- 
2.12.2

[PATCH 1/3] ti-soc-thermal: Use devm_kcalloc() in ti_bandgap_build()

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 26 Apr 2017 16:45:25 +0200

A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/thermal/ti-soc-thermal/ti-bandgap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index ba9c302454fb..f19cb7612a65 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -1224,8 +1224,8 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
 		bgp->conf = of_id->data;
 
 	/* register shadow for context save and restore */
-	bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) *
-				   bgp->conf->sensor_count, GFP_KERNEL);
+	bgp->regval = devm_kcalloc(&pdev->dev, bgp->conf->sensor_count,
+				   sizeof(*bgp->regval), GFP_KERNEL);
 	if (!bgp->regval) {
 		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
 		return ERR_PTR(-ENOMEM);
-- 
2.12.2

[PATCH 2/3] ti-soc-thermal: Delete error messages for failed memory allocations in ti_bandgap_build()

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 26 Apr 2017 17:03:07 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such statements here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/thermal/ti-soc-thermal/ti-bandgap.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index f19cb7612a65..109fb0a5f19f 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -1217,7 +1217,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
-	if (!bgp) {
-		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
+	if (!bgp)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	of_id = of_match_device(of_ti_bandgap_match, &pdev->dev);
 	if (of_id)
@@ -1229,7 +1227,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
-	if (!bgp->regval) {
-		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
+	if (!bgp->regval)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	i = 0;
 	do {
-- 
2.12.2

[PATCH 3/3] ti-soc-thermal: Fix a typo in a comment line

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 26 Apr 2017 17:11:28 +0200

Add a missing character in this description for a function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
index 109fb0a5f19f..696ab3046b87 100644
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -1010,7 +1010,7 @@ ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id)
 }
 
 /**
- * ti_bandgap_set_continous_mode() - One time enabling of continuous mode
+ * ti_bandgap_set_continuous_mode() - One time enabling of continuous mode
  * @bgp: pointer to struct ti_bandgap
  *
  * Call this function only if HAS(MODE_CONFIG) is set. As this driver may
-- 
2.12.2

Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

[Eduardo Valentin]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 26 Apr 2017 17:24:56 +0200
> 
> Three update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (3):
>   Use devm_kcalloc() in ti_bandgap_build()
>   Delete error messages for failed memory allocations in ti_bandgap_build()
>   Fix a typo in a comment line
> 

Keerthy,

Can you please give it a shot of this series on all supported OMAP chip
boards? I do not see any major issue with the series at all, but would
like to get it tested by you.

BR,

>  drivers/thermal/ti-soc-thermal/ti-bandgap.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> -- 
> 2.12.2
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

[Keerthy]

On Thursday 27 April 2017 09:50 PM, Eduardo Valentin wrote:
> On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Wed, 26 Apr 2017 17:24:56 +0200
>>
>> Three update suggestions were taken into account
>> from static source code analysis.
>>
>> Markus Elfring (3):
>>   Use devm_kcalloc() in ti_bandgap_build()
>>   Delete error messages for failed memory allocations in ti_bandgap_build()
>>   Fix a typo in a comment line
>>
> 
> Keerthy,
> 
> Can you please give it a shot of this series on all supported OMAP chip
> boards? I do not see any major issue with the series at all, but would
> like to get it tested by you.

Sure Eduardo. I will test and review this series.

> 
> BR,
> 
>>  drivers/thermal/ti-soc-thermal/ti-bandgap.c | 14 +++++---------
>>  1 file changed, 5 insertions(+), 9 deletions(-)
>>
>> -- 
>> 2.12.2
>>

Re: [PATCH 3/3] ti-soc-thermal: Fix a typo in a comment line

[Keerthy]

On Wednesday 26 April 2017 09:09 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 26 Apr 2017 17:11:28 +0200
> 
> Add a missing character in this description for a function.

Reviewed-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/thermal/ti-soc-thermal/ti-bandgap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index 109fb0a5f19f..696ab3046b87 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -1010,7 +1010,7 @@ ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id)
>  }
>  
>  /**
> - * ti_bandgap_set_continous_mode() - One time enabling of continuous mode
> + * ti_bandgap_set_continuous_mode() - One time enabling of continuous mode
>   * @bgp: pointer to struct ti_bandgap
>   *
>   * Call this function only if HAS(MODE_CONFIG) is set. As this driver may
> 

Re: [PATCH 2/3] ti-soc-thermal: Delete error messages for failed memory allocations in ti_bandgap_build()

[Keerthy]

On Wednesday 26 April 2017 09:07 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 26 Apr 2017 17:03:07 +0200
> 
> The script "checkpatch.pl" pointed information out like the following.
> 
> WARNING: Possible unnecessary 'out of memory' message
> 
> Thus remove such statements here.

Reviewed-by: Keerthy <j-keerthy@ti.com>

> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/thermal/ti-soc-thermal/ti-bandgap.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index f19cb7612a65..109fb0a5f19f 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -1217,7 +1217,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
> -	if (!bgp) {
> -		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
> +	if (!bgp)
>  		return ERR_PTR(-ENOMEM);
> -	}
>  
>  	of_id = of_match_device(of_ti_bandgap_match, &pdev->dev);
>  	if (of_id)
> @@ -1229,7 +1227,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
> -	if (!bgp->regval) {
> -		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
> +	if (!bgp->regval)
>  		return ERR_PTR(-ENOMEM);
> -	}
>  
>  	i = 0;
>  	do {
> 

Re: [PATCH 1/3] ti-soc-thermal: Use devm_kcalloc() in ti_bandgap_build()

[Keerthy]

On Wednesday 26 April 2017 09:04 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 26 Apr 2017 16:45:25 +0200
> 
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".

Reviewed-by: Keerthy <j-keerthy@ti.com>

> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/thermal/ti-soc-thermal/ti-bandgap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index ba9c302454fb..f19cb7612a65 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -1224,8 +1224,8 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
>  		bgp->conf = of_id->data;
>  
>  	/* register shadow for context save and restore */
> -	bgp->regval = devm_kzalloc(&pdev->dev, sizeof(*bgp->regval) *
> -				   bgp->conf->sensor_count, GFP_KERNEL);
> +	bgp->regval = devm_kcalloc(&pdev->dev, bgp->conf->sensor_count,
> +				   sizeof(*bgp->regval), GFP_KERNEL);
>  	if (!bgp->regval) {
>  		dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
>  		return ERR_PTR(-ENOMEM);
> 

Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

[Keerthy]

On Monday 01 May 2017 10:50 AM, Keerthy wrote:
> 
> 
> On Thursday 27 April 2017 09:50 PM, Eduardo Valentin wrote:
>> On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote:
>>> From: Markus Elfring <elfring@users.sourceforge.net>
>>> Date: Wed, 26 Apr 2017 17:24:56 +0200
>>>
>>> Three update suggestions were taken into account
>>> from static source code analysis.
>>>
>>> Markus Elfring (3):
>>>   Use devm_kcalloc() in ti_bandgap_build()
>>>   Delete error messages for failed memory allocations in ti_bandgap_build()
>>>   Fix a typo in a comment line
>>>
>>
>> Keerthy,
>>
>> Can you please give it a shot of this series on all supported OMAP chip
>> boards? I do not see any major issue with the series at all, but would
>> like to get it tested by you.
> 
> Sure Eduardo. I will test and review this series.

Tested for Temperatures of all the sensors and thermal shutdown
triggering using emul_temp on DRA7/DRA72 AM57xx-evm boards.


For the series:

Acked-by: Keerthy <j-keerthy@ti.com>
Tested-by: Keerthy <j-keerthy@ti.com>

- Keerthy

> 
>>
>> BR,
>>
>>>  drivers/thermal/ti-soc-thermal/ti-bandgap.c | 14 +++++---------
>>>  1 file changed, 5 insertions(+), 9 deletions(-)
>>>
>>> -- 
>>> 2.12.2
>>>