From: David Laight <David.Laight@ACULAB.COM>
To: 'Stefano Garzarella' <sgarzare@redhat.com>
Cc: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] vsock: ratelimit unknown ioctl error message
Date: Mon, 26 Oct 2020 09:13:23 +0000 [thread overview]
Message-ID: <d893e3251f804cffa797b6eb814944fd@AcuMS.aculab.com> (raw)
In-Reply-To: <20201026084300.5ag24vck3zeb4mcz@steredhat>
From: Stefano Garzarella
> Sent: 26 October 2020 08:43
...
> >Isn't the canonical error for unknown ioctl codes -ENOTTY?
> >
>
> Oh, thanks for pointing that out!
>
> I had not paid attention to the error returned, but looking at it I
> noticed that perhaps the most appropriate would be -ENOIOCTLCMD.
> In the ioctl syscall we return -ENOTTY, if the callback returns
> -ENOIOCTLCMD.
>
> What do you think?
It is 729 v 443 in favour of ENOTTY (based on grep).
No idea where ENOIOCTLCMD comes from, but ENOTTY probably
goes back to the early 1970s.
The fact that the ioctl wrapper converts the value is a good
hint that userspace expects ENOTTY.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-10-26 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 12:21 [PATCH] vsock: ratelimit unknown ioctl error message Colin King
2020-10-23 14:09 ` Stefano Garzarella
2020-10-23 20:25 ` Jakub Kicinski
2020-10-23 21:30 ` David Laight
2020-10-26 8:43 ` Stefano Garzarella
2020-10-26 9:13 ` David Laight [this message]
2020-10-26 9:39 ` Stefano Garzarella
2020-10-26 9:46 ` David Laight
2020-10-26 10:01 ` Stefano Garzarella
2020-10-26 17:55 ` Jakub Kicinski
2020-10-26 18:24 ` Stefano Garzarella
2020-10-26 18:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d893e3251f804cffa797b6eb814944fd@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).