From: Daniel Scally <djrscally@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lee Jones <lee.jones@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
platform-driver-x86@vger.kernel.org, devel@acpica.org,
Len Brown <lenb@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Wolfram Sang <wsa@kernel.org>,
Mark Gross <mgross@linux.intel.com>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
laurent.pinchart@ideasonboard.com,
kieran.bingham@ideasonboard.com
Subject: Re: [PATCH v5 3/6] gpiolib: acpi: Export acpi_get_gpiod()
Date: Fri, 4 Jun 2021 15:09:17 +0100 [thread overview]
Message-ID: <d8eb43b6-c842-6b1f-5840-f558d54f1498@gmail.com> (raw)
In-Reply-To: <YLojymirRB5HpFQY@smile.fi.intel.com>
Hi Andy
On 04/06/2021 13:59, Andy Shevchenko wrote:
> On Thu, Jun 03, 2021 at 11:40:04PM +0100, Daniel Scally wrote:
>> We need to be able to translate GPIO resources in an ACPI device's _CRS
>> into GPIO descriptor array. Those are represented in _CRS as a pathname
>> to a GPIO device plus the pin's index number: the acpi_get_gpiod()
>> function is perfect for that purpose.
>>
>> As it's currently only used internally within the GPIO layer, provide and
>> export a wrapper function that additionally holds a reference to the GPIO
>> device.
> The subject is wrong, it should be "Introduce acpi_get_and_request_gpiod()
> helper" or so. I can fix when applying.
Ah! That was sloppy, sorry.
> Btw, do I understand correctly that I may push GPIO ACPI patches independently
> (of the ACPI changes)?
They're independent yes.
>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Signed-off-by: Daniel Scally <djrscally@gmail.com>
>> ---
>> Changes since v4:
>> - None
>>
>> drivers/gpio/gpiolib-acpi.c | 28 ++++++++++++++++++++++++++++
>> include/linux/gpio/consumer.h | 2 ++
>> 2 files changed, 30 insertions(+)
>>
>> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
>> index 5b4111e4be3f..684ddb35d83b 100644
>> --- a/drivers/gpio/gpiolib-acpi.c
>> +++ b/drivers/gpio/gpiolib-acpi.c
>> @@ -128,6 +128,34 @@ static struct gpio_desc *acpi_get_gpiod(char *path, int pin)
>> return gpiochip_get_desc(chip, pin);
>> }
>>
>> +/**
>> + * acpi_get_and_request_gpiod() - Translate ACPI GPIO pin to GPIO descriptor
>> + * and hold a refcount to the GPIO device.
>> + * @path: ACPI GPIO controller full path name, (e.g. "\\_SB.GPO1")
>> + * @pin: ACPI GPIO pin number (0-based, controller-relative)
>> + * @label: Label to pass to gpiod_request()
>> + *
>> + * This function is a simple pass-through to acpi_get_gpiod(), except that
>> + * as it is intended for use outside of the GPIO layer (in a similar fashion to
>> + * gpiod_get_index() for example) it also holds a reference to the GPIO device.
>> + */
>> +struct gpio_desc *acpi_get_and_request_gpiod(char *path, int pin, char *label)
>> +{
>> + struct gpio_desc *gpio;
>> + int ret;
>> +
>> + gpio = acpi_get_gpiod(path, pin);
>> + if (IS_ERR(gpio))
>> + return gpio;
>> +
>> + ret = gpiod_request(gpio, label);
>> + if (ret)
>> + return ERR_PTR(ret);
>> +
>> + return gpio;
>> +}
>> +EXPORT_SYMBOL_GPL(acpi_get_and_request_gpiod);
>> +
>> static irqreturn_t acpi_gpio_irq_handler(int irq, void *data)
>> {
>> struct acpi_gpio_event *event = data;
>> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
>> index c73b25bc9213..566feb56601f 100644
>> --- a/include/linux/gpio/consumer.h
>> +++ b/include/linux/gpio/consumer.h
>> @@ -692,6 +692,8 @@ int devm_acpi_dev_add_driver_gpios(struct device *dev,
>> const struct acpi_gpio_mapping *gpios);
>> void devm_acpi_dev_remove_driver_gpios(struct device *dev);
>>
>> +struct gpio_desc *acpi_get_and_request_gpiod(char *path, int pin, char *label);
>> +
>> #else /* CONFIG_GPIOLIB && CONFIG_ACPI */
>>
>> struct acpi_device;
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2021-06-04 14:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 22:40 [PATCH v5 0/6] Introduce intel_skl_int3472 module Daniel Scally
2021-06-03 22:40 ` [PATCH v5 1/6] ACPI: scan: Extend acpi_walk_dep_device_list() Daniel Scally
2021-06-03 22:40 ` [PATCH v5 2/6] ACPI: scan: Add function to fetch dependent of acpi device Daniel Scally
2021-06-07 14:52 ` Rafael J. Wysocki
2021-06-03 22:40 ` [PATCH v5 3/6] gpiolib: acpi: Export acpi_get_gpiod() Daniel Scally
2021-06-04 12:59 ` Andy Shevchenko
2021-06-04 14:09 ` Daniel Scally [this message]
2021-06-03 22:40 ` [PATCH v5 4/6] gpiolib: acpi: Add acpi_gpio_get_io_resource() Daniel Scally
2021-06-04 13:01 ` Andy Shevchenko
2021-06-04 14:09 ` Daniel Scally
2021-06-04 14:33 ` Andy Shevchenko
2021-06-04 16:54 ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 5/6] platform/x86: Add intel_skl_int3472 driver Daniel Scally
2021-06-04 1:31 ` kernel test robot
2021-06-05 23:07 ` Daniel Scally
2021-06-04 6:49 ` kernel test robot
2021-06-16 17:58 ` Hans de Goede
2021-06-16 18:08 ` Andy Shevchenko
2021-06-16 18:13 ` Hans de Goede
2021-06-16 21:42 ` Daniel Scally
2021-06-03 22:40 ` [PATCH v5 6/6] mfd: tps68470: Remove tps68470 MFD driver Daniel Scally
2021-06-17 11:14 ` Hans de Goede
2021-06-08 9:00 ` [PATCH v5 0/6] Introduce intel_skl_int3472 module Hans de Goede
2021-06-08 9:33 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8eb43b6-c842-6b1f-5840-f558d54f1498@gmail.com \
--to=djrscally@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=hdegoede@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).